From: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
To: sj@kernel.org, akpm@linux-foundation.org
Cc: damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, donggeunyoo.kernel@gmail.com
Subject: [PATCH 0/2] mm/damon: fix the temporal goal tuner's size quota conversion
Date: Sat, 19 Sep 2026 16:13:22 +0900 [thread overview]
Message-ID: <20260919071324.1583280-1-donggeunyoo.kernel@gmail.com> (raw)
damos_goal_tune_esz_bp_temporal() hands the size quota to
damos_set_effective_quota() through quota->esz_bp in basis points, and the
multiply that gets it there is unchecked. On 32-bit it wraps from 429497
bytes on, and wraps to exactly zero at the 1 GiB that
Documentation/admin-guide/mm/damon/usage.rst uses as its example, since
1 GiB * 10000 is 2500 * 2^32. A zero effective quota makes
damos_quota_is_full() true on the first test of every charge window, so the
scheme applies nothing for as long as the goal is unachieved.
Patch 1 saturates the conversion. Patch 2 pins the boundary in the core
kunit suite, where it fails without patch 1 on any word size.
DAMON kunit: 36 tests, all passing with both patches; 35 passing and
damos_test_esz_goal_temporal failing with patch 2 alone. The DAMON
selftests do not reach the changed function: a build with a print at its
entry stayed silent through all fifteen of them and fired as soon as a
scheme was configured with the temporal tuner.
Donggeun Yoo (2):
mm/damon/core: prevent size quota overflow in the temporal goal tuner
mm/damon/tests/core-kunit: test the temporal tuner's size quota
conversion
mm/damon/core.c | 6 +++---
mm/damon/tests/core-kunit.h | 35 +++++++++++++++++++++++++++++++++++
2 files changed, 38 insertions(+), 3 deletions(-)
base-commit: 498ee28e5ec4727f829507c4a1bde3ab1b7704cd
--
2.53.0
next reply other threads:[~2026-09-19 7:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 7:13 Donggeun Yoo [this message]
2026-09-19 7:13 ` [PATCH v1 1/2] mm/damon/core: prevent size quota overflow in the temporal goal tuner Donggeun Yoo
2026-09-19 7:20 ` sashiko-bot
2026-09-19 16:55 ` SJ Park
2026-09-20 2:37 ` Donggeun Yoo
2026-09-19 7:13 ` [PATCH v1 2/2] mm/damon/tests/core-kunit: test the temporal tuner's size quota conversion Donggeun Yoo
2026-09-19 7:20 ` sashiko-bot
2026-09-19 17:01 ` SJ Park
2026-09-20 2:37 ` Donggeun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260919071324.1583280-1-donggeunyoo.kernel@gmail.com \
--to=donggeunyoo.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.