Re: [PATCH] Input: gpio_mouse - remove driver that has never been used in the kernel

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] input: gpio_mouse: driver removal speculatively breaks device tree ABI
- [Low] input: gpio_mouse: incomplete cleanup leaves orphaned DT binding
--

commit ff6ae0c9a42236905d35103b1b6b9ce3be08070e
Author: Ethan Nelson-Moore <enelsonmoore@gmail.com>

Input: gpio_mouse - remove driver that has never been used in the kernel

This commit removes the gpio_mouse driver. The driver has been present since
2007 but lacks any in-tree references from platform data, device tree files,
or ACPI probing.

> diff --git a/drivers/input/mouse/gpio_mouse.c b/drivers/input/mouse/gpio_mouse.c
> deleted file mode 100644
> index 18ccbd45004ad..0000000000000
> --- a/drivers/input/mouse/gpio_mouse.c
> +++ /dev/null
> @@ -1,170 +0,0 @@
[ ... ]
> -static const struct of_device_id gpio_mouse_of_match[] = {
> -	{ .compatible = "gpio-mouse", },
> -	{ },
> -};
> -MODULE_DEVICE_TABLE(of, gpio_mouse_of_match);

[Severity: Medium]
Could removing this driver break the Device Tree ABI for any out-of-tree
boards that currently rely on the "gpio-mouse" compatible string?

If a system bootloader or firmware passes a DTB with the "gpio-mouse"
compatible string, the driver will no longer exist to bind to it.

[Severity: Low]
Does this patch also need to remove the devicetree binding schema for
"gpio-mouse"?

The schema file Documentation/devicetree/bindings/input/gpio-mouse.yaml
appears to be left behind, leaving it as an orphaned document now that
the driver is removed.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919083655.586922-1-enelsonmoore@gmail.com?part=1