From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
Cc: jic23@kernel.org, gregkh@linuxfoundation.org, nuno.sa@analog.com,
Michael.Hennerich@analog.com, dlechner@baylibre.com,
andy@kernel.org, linux@analog.com, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: adc: ad7816: Protect sysfs attributes with mutex
Date: Sat, 19 Sep 2026 11:31:18 +0200 [thread overview]
Message-ID: <20260919113118.51036850@systembl0wer> (raw)
In-Reply-To: <20260919085513.9173-1-abdelnasserhussein11@gmail.com>
On Sat, 19 Sep 2026 11:55:13 +0300
Abdelnasser Hussein <abdelnasserhussein11@gmail.com> wrote:
...
> @@ -143,6 +143,7 @@ static ssize_t ad7816_store_mode(struct device *dev,
> struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> struct ad7816_chip_info *chip = iio_priv(indio_dev);
>
> + guard(mutex)(&chip->lock);
+ Blank line.
> if (strcmp(buf, "full") == 0) {
> gpiod_set_value(chip->rdwr_pin, 1);
> chip->mode = AD7816_FULL;
> @@ -207,6 +208,7 @@ static ssize_t ad7816_store_channel(struct device *dev,
> return -EINVAL;
> }
>
> + guard(mutex)(&chip->lock);
+ Blank line.
> chip->channel_id = data;
With these issues addressed,
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-09-19 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 8:55 [PATCH] staging: iio: adc: ad7816: Protect sysfs attributes with mutex Abdelnasser Hussein
2026-09-19 9:31 ` Joshua Crofts [this message]
2026-09-19 10:44 ` Dan Carpenter
2026-09-20 1:05 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260919113118.51036850@systembl0wer \
--to=joshua.crofts1@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=abdelnasserhussein11@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.