From: SJ Park <sj@kernel.org>
To: Karl Mehltretter <kmehltretter@gmail.com>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Lian Wang <lianux.mm@gmail.com>,
Kunwu Chan <kunwu.chan@gmail.com>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm/damon/tests/core-kunit: test PSI goal rounds under the temporal tuner
Date: Sat, 19 Sep 2026 08:55:02 -0700 [thread overview]
Message-ID: <20260919155503.85841-1-sj@kernel.org> (raw)
In-Reply-To: <aq4hU5DNjnGELpUT@gmail.com>
On Sat, 19 Sep 2026 07:47:11 +0200 Karl Mehltretter <kmehltretter@gmail.com> wrote:
> On Tue, Sep 15, 2026 at 05:21:36PM +0100, SJ Park wrote:
> > So, this test depends on the memory pressure level of the testing system? I
> > concern if that could make the test result not very reliable. Maybe we could
> > split out the corner case handling logic to explicitly receive the current
> > memory PSI total time. For example, like what I suggested in the reply to the
> > first patch of this series. With it, we could build a kunit test for only the
> > target logic, without depending on the test system's status.
> >
>
> Yes, the second round reads the real PSI total. I used ULONG_MAX as
> the target to make it unreachable, but I agree that a test which
> does not read system state is better.
>
> For v2 I can test only the helper from your reply to patch 1,
> with explicit PSI totals. It would cover both tuners, zero and
> non-zero esz for the temporal one, and the last_psi_total value after
> each call as Kunwu asked.
Sounds good, looking forward to your v2!
Thanks,
SJ
[...]
prev parent reply other threads:[~2026-09-19 15:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 6:09 [PATCH 0/2] mm/damon: fix zero quota for PSI goals under the temporal tuner Karl Mehltretter
2026-09-15 6:09 ` [PATCH 1/2] mm/damon/core: score an unmeasured PSI goal as not achieved for " Karl Mehltretter
2026-09-15 6:18 ` sashiko-bot
2026-09-15 14:50 ` SJ Park
2026-09-15 21:19 ` Karl Mehltretter
2026-09-16 0:13 ` SJ Park
2026-09-19 5:44 ` Karl Mehltretter
2026-09-19 15:53 ` SJ Park
2026-09-21 18:51 ` Karl Mehltretter
2026-09-15 6:09 ` [PATCH 2/2] mm/damon/tests/core-kunit: test PSI goal rounds under " Karl Mehltretter
2026-09-15 6:15 ` sashiko-bot
2026-09-15 7:04 ` KunWu Chan
2026-09-15 21:31 ` Karl Mehltretter
2026-09-16 0:21 ` SJ Park
2026-09-19 5:47 ` Karl Mehltretter
2026-09-19 15:55 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260919155503.85841-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kmehltretter@gmail.com \
--cc=kunwu.chan@gmail.com \
--cc=lianux.mm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.