Re: [PATCH 3/3] arm64: dts: marvell: Add Sophos XGS 107w NPU board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt: intentional omission of physical reset-gpios to workaround driver bug
--

commit 3bbda9294c3060f49dfc25ff724a945a54bd4560
Author: Nicolo Giuliani <nicolo.giuliani6@studio.unibo.it>

arm64: dts: marvell: Add Sophos XGS 107w NPU board

This commit adds a device tree for the network processing unit (NPU) of the
Sophos XGS 87/107 desktop firewalls. It describes the Marvell Armada CN9130
SoC, along with the UART, eMMC, SPI NOR flash, SFP cage, and a Marvell
88E6193X switch.

> diff --git a/arch/arm64/boot/dts/marvell/cn9130-sophos-xgs107w.dts b/arch/arm64/boot/dts/marvell/cn9130-sophos-xgs107w.dts
> new file mode 100644
> index 0000000000000..d98d8da10e637
> --- /dev/null
> +++ b/arch/arm64/boot/dts/marvell/cn9130-sophos-xgs107w.dts

[ ... ]

> +&cp0_mdio {
> +	status = "okay";
> +
> +	switch@2 {
> +		compatible = "marvell,mv88e6190";
> +		reg = <2>;
> +		/*
> +		 * The reset line of the switch is CP GPIO2 pin 17. It is not
> +		 * described as reset-gpios: the 88E6193X needs about two
> +		 * seconds after a reset before it can be used, much longer
> +		 * than the driver waits, and the probe would time out. The
> +		 * boot loader resets the switch before starting the kernel.
> +		 */

[Severity: Medium]
Is it appropriate to deliberately omit the physically present reset-gpios
property to work around a Linux driver timeout limitation?

Device Tree is intended to be an OS-independent description of the hardware
topology. By intentionally omitting this connection in switch@2, the kernel
is unable to reset the switch natively (for instance, during a driver reload
or system reboot).

Would it be better to accurately describe the hardware by including the
reset-gpios property here, and instead fix the timeout in the mv88e6xxx
driver or use standard delay properties like reset-deassert-us to handle
the two-second requirement?

> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919-send-dt-v1-0-365615a74ef3@studio.unibo.it?part=3