From: sashiko-bot@kernel.org
To: "Hui Peng" <benquike@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: fix 8250 hash_mutex race and uart_get_baud_rate() divide-by-zero
Date: Sat, 19 Sep 2026 22:45:35 +0000 [thread overview]
Message-ID: <20260919224536.37C271F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260919222627.3797854-1-benquike@gmail.com>
> Fix two bugs in the serial subsystem:
>
> 1. In serial8250_Label / serial_link_irq_chain() and
> serial_unlink_irq_chain() (drivers/tty/serial/8250/8250_core.c), hold
> hash_mutex across the entire IRQ list manipulation and
> request_irq()/free_irq() sequence to prevent racing IRQ chain
> insertions/removals.
> 2. In uart_get_baud_rate() and uart_set_info()
> (drivers/tty/serial/serial_core.c), avoid unsigned overflow in
> port->uartclk = new_info->baud_base * 16 and ensure the fallback
> retry in uart_get_baud_rate() terminates cleanly when no baud rate
> lies in [min, max].
>
> Fixes: ab4382d27412 ("tty: move drivers/serial/ to drivers/tty/serial/")
> Assisted-by: LLM
> Signed-off-by: Hui Peng <benquike@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260919222627.3797854-1-benquike@gmail.com?part=1
next prev parent reply other threads:[~2026-09-19 22:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 22:26 [PATCH] serial: fix 8250 hash_mutex race and uart_get_baud_rate() divide-by-zero Hui Peng
2026-09-19 22:45 ` sashiko-bot [this message]
2026-09-20 5:17 ` Greg KH
[not found] ` <CAKpmkkV+Gk11x0wCbT1dK8FDraaCb0q=ALS+Tnj0wM+EcMt-SA@mail.gmail.com>
2026-09-20 5:31 ` Greg KH
2026-09-21 1:30 ` [PATCH v2 1/3] serial: 8250: hold hash_mutex across IRQ chain linking in serial_link_irq_chain() Hui Peng
2026-09-21 1:36 ` sashiko-bot
2026-09-21 1:30 ` [PATCH v2 2/3] serial: core: allow third iteration in uart_get_baud_rate() fallback Hui Peng
2026-09-21 1:36 ` sashiko-bot
2026-09-21 12:16 ` Ilpo Järvinen
2026-09-21 1:30 ` [PATCH v2 3/3] serial: core: reject baud_base values that overflow port->uartclk in uart_set_info() Hui Peng
2026-09-21 1:38 ` sashiko-bot
2026-09-21 12:10 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260919224536.37C271F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=benquike@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.