From: sashiko-bot@kernel.org
To: "Muhammad Abu Bakar" <m.abubakar365@yahoo.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: pressure: add Sensirion SDP31
Date: Sat, 19 Sep 2026 22:55:02 +0000 [thread overview]
Message-ID: <20260919225502.C6FF91F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260919223854.13437-2-m.abubakar365@yahoo.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: iio: sdp31 omits vdd-supply from required list
--
commit 61ed9cca92b973d2ff70fa365d3b2d923c296955
Author: Muhammad Abu Bakar <m.abubakar365@yahoo.com>
dt-bindings: iio: pressure: add Sensirion SDP31
This commit adds device tree bindings for the Sensirion SDP31 differential
pressure sensor. It defines the properties compatible, reg, and vdd-supply
for the I2C device.
> diff --git a/Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml b/Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml
> new file mode 100644
> index 0000000000000..fc646eca2d6f1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/pressure/sensirion,sdp31.yaml
[ ... ]
> +properties:
> + compatible:
> + const: sensirion,sdp31
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply: true
> +
> +required:
> + - compatible
> + - reg
[Severity: Low]
Should vdd-supply be added to this required list to enforce complete device
tree configurations?
Since the SDP31 physical sensor requires a power supply to operate, defining
vdd-supply: true but omitting it from the required list means incomplete
device tree nodes missing the power supply definition will silently pass
schema validation when developers run make dtbs_check.
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260919223854.13437-1-m.abubakar365@yahoo.com?part=1
next prev parent reply other threads:[~2026-09-19 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260919223854.13437-1-m.abubakar365.ref@yahoo.com>
2026-09-19 22:38 ` [PATCH 0/2] iio: pressure: add Sensirion SDP31 driver Muhammad Abu Bakar
2026-09-19 22:38 ` [PATCH 1/2] dt-bindings: iio: pressure: add Sensirion SDP31 Muhammad Abu Bakar
2026-09-19 22:55 ` sashiko-bot [this message]
2026-09-20 0:40 ` Jonathan Cameron
2026-09-28 20:45 ` Muhammad Abu Bakar
2026-09-19 22:38 ` [PATCH 2/2] iio: pressure: add Sensirion SDP31 driver Muhammad Abu Bakar
2026-09-19 23:00 ` sashiko-bot
2026-09-20 0:53 ` Jonathan Cameron
2026-09-20 0:34 ` [PATCH 0/2] " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260919225502.C6FF91F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=m.abubakar365@yahoo.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.