Re: [PATCH v5 2/2] iio: light: add AS7343 multi-spectral sensor driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] pm: missing PM runtime idle request prevents initial autosuspend
--

commit 87cfb69de7e4c2b750859f6540e61d6d9aef5dcd
Author: Chang Yu <marcus.yu.56@gmail.com>

iio: light: add AS7343 multi-spectral sensor driver

Add a driver for the AMS AS7343 14-channel multi-spectral sensor.
The driver exposes 12 spectral channels via sysfs and implements runtime
PM to manage device power during measurements.

> diff --git a/drivers/iio/light/as7343.c b/drivers/iio/light/as7343.c
> new file mode 100644
> index 0000000000000..c079e0c6aa704
> --- /dev/null
> +++ b/drivers/iio/light/as7343.c
[ ... ]
> +static int as7343_probe(struct i2c_client *client)
> +{
[ ... ]
> +	pm_runtime_set_autosuspend_delay(dev, 3000);
> +	pm_runtime_use_autosuspend(dev);
> +
> +	ret = devm_add_action_or_reset(dev, as7343_suspend_action, dev);
> +	if (ret)
> +		return dev_err_probe(dev, ret,
> +				     "Failed to add suspend action\n");
> +
> +	ret = devm_pm_runtime_set_active_enabled(dev);

[Severity: Medium]
Does enabling PM runtime here without a subsequent idle check (or without
calling pm_runtime_use_autosuspend afterwards) leave the device perpetually
active?

Since pm_runtime_use_autosuspend(dev) is called earlier, the device's
disable_depth is still greater than 0 at that point. This causes the internal
idle check to fail with -EACCES, preventing the autosuspend timer from
being queued.

When devm_pm_runtime_set_active_enabled() later enables PM runtime, it does
not implicitly trigger an idle check. This might strand the device in the
active state until user space initiates a read to kick off a get and
put_autosuspend cycle.

> +	if (ret)
> +		return dev_err_probe(dev, ret,
> +				     "Failed to activate PM runtime\n");
> +
> +	return devm_iio_device_register(dev, indio_dev);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919235145.48273-1-marcus.yu.56@gmail.com?part=2