Re: [PATCH v2 2/4] perf script: Add --max-symbol-bytes to bound ELF symbol memory

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf: missing <stdbool.h> in symbol-bytes.c
--

commit 43444932791d9e1c6b50bba8362920738abe2410
Author: Alireza Haghdoost <haghdoost@uber.com>

perf script: Add --max-symbol-bytes to bound ELF symbol memory

This commit adds a new --max-symbol-bytes option to bound the memory consumed
by struct symbol allocations. Once the specified budget is reached, the ELF
loader stops loading new symbols and prints unresolved addresses as unknown.

> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c

[ ... ]

> @@ -4035,6 +4036,44 @@ static int parse_callret_trace(const struct option *opt __maybe_unused,
>  	return 0;
>  }
>  
> +static int parse_max_symbol_bytes(const struct option *opt,
> +				  const char *str, int unset)
> +{

[ ... ]

> +	if (!strcmp(str, "0")) {
> +		*max_bytes = 0;
> +		return 0;
> +	}
> +
> +	len = strlen(str);
> +	if (len < 2 || !strchr("BKMG", str[len - 1]) ||
> +	    strspn(str, "0123456789") != len - 1)

[Severity: Low]
This is a pre-existing issue, but parse_max_symbol_bytes() introduces direct
calls to libc string functions like strcmp() and strlen(). Since this file
lacks an explicit include of the POSIX <string.h> header, does this cause
compilation failures in musl libc environments where headers are not
implicitly included?

> diff --git a/tools/perf/tests/symbol-bytes.c b/tools/perf/tests/symbol-bytes.c
> --- /dev/null
> +++ b/tools/perf/tests/symbol-bytes.c

[ ... ]

> +struct reserve_arg {
> +	size_t bytes;
> +	bool success;

[Severity: Low]
This struct uses the bool type, but the file doesn't explicitly include
<stdbool.h>. Can this cause a compilation failure under stricter libc
environments like musl due to the missing type definition?

> +};
> +
> +static void *reserve_bytes(void *data)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260919-perf-symbol-memory-send-v2-0-495b8f00ad7c@uber.com?part=2