Re: [PATCH 1/1] hwmon: (spd5118) support write protected devices

[sashiko-bot@kernel.org]

> Some systems do not allow writes to SPD devices. On the i801 SMBus
> controller family this happens when the BIOS sets SPD Write Disable, in
> which case the controller refuses writes to addresses 0x50-0x57; other
> platforms may enforce the same in firmware. There is no way for the driver
> to query this.
> 
> spd5118 assumes that it can write to the device, which does not hold on
> such systems:
> 
>   - writes to the hwmon attributes always fail with -ENXIO
>   - the temperature sensor disable in spd5118_suspend() fails silently
>   - spd5118_resume() fails in regcache_sync(), and the system reports
> 
>   spd5118 0-0050: Failed to write b = 0: -6
>   spd5118 0-0050: PM: failed to resume async: error -6
> [ ... ]
> becomes read-only. Document that, and leave the shared regmap
> configuration alone by selecting a separate one without a register
> cache.
> 
> Signed-off-by: Kean Ren <rh_king@163.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920062230.2437291-2-rh_king@163.com?part=1