From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5ED7402B99 for ; Sun, 20 Sep 2026 11:20:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789903204; cv=none; b=r81s9vnyvHbR5YIo1256lUwXTJbD2QTfNlby4lcg0jY7NQ/uRxcT+BTOSBL9u9Knrcdft2JTrzBq21IAARMeI/yyskRMPuZzAImozhYDVrnlwVuejJFYxfPIB+n5pBzmuVXk59HneEEqxoAws6f1l5LadyIPxzdfPNpS6rhSA/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789903204; c=relaxed/simple; bh=Aj3GJXPp5u3IS4krE9w69UFet4NubEFzHkC6TE5bA4c=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=mIlAJ1ixlbpC05F0jEGIU+0QXSqz6kFxQYtqvp5kRYF8IyoFhBWHUldp8GYJwCw6EccUcJRreIjI88KzZNbjKL/mYDlDU0m1ITIDMSMbWKrCtDVllVSGpqYA04d1LjDEJ6ma9d82I9PHTHXyW1TMQFRO7C46Jstxks/w4O4e7q4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fLLCmqME; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fLLCmqME" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 957A51F00893; Sun, 20 Sep 2026 11:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789903200; bh=343/Db1Z8S17ssk821pz0Ch5sbEg1jnS5AmNrMg2Re0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fLLCmqME9mXuW6pALNbtZP1fybu4xfooXafACBbeTqWFPHvxM3Rw4zUR7EmM88WF+ kmReu3VZkYMvYuG2nW5NE9AlEVlSbbybeE9MksDTig9OrZhgbaemiPhNba6ns3oDNM sTEwfjdYrcS6NivXxSgBefGrv7qPMdmI6a23FJ7VyURwGATioxwL1/7KoSDrtaHnyh nf+Eu2TXGh/I1Pny8Dg95shsRPLuXTGua6S+bRhccDfFjwH4eCcI4gK9VOri1jWK2M +YGZddoDnY25JfVZNlO8xcXYgpL5Z5UxEjcB6Dc9iLeNbBh67zFb2+6Sw0VVz3xyze uEycDd0O6sLLA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 2/4] nvmem: core: deprecate reg_write callback with reg_write_const Reply-To: sashiko-reviews@lists.linux.dev To: "Link Mauve" Cc: neil.armstrong@linaro.org, ojeda@kernel.org, linux-amlogic@lists.infradead.org, Frank.Li@kernel.org, imx@lists.linux.dev, gary@garyguo.net In-Reply-To: <20260920111000.2404131-3-linkmauve@linkmauve.fr> References: <20260920111000.2404131-1-linkmauve@linkmauve.fr> <20260920111000.2404131-3-linkmauve@linkmauve.fr> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 20 Sep 2026 11:19:59 +0000 Message-Id: <20260920111959.957A51F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] nvmem: dev_warn uses uninitialized device name in nvmem_register() -- commit 77653927bdf19b36c155e416a676051598da0213 Author: Link Mauve nvmem: core: deprecate reg_write callback with reg_write_const This commit deprecates the reg_write callback in favor of reg_write_const, which takes a const pointer for the value buffer. It also adds a deprecation warning in nvmem_register() for drivers still using the old callback. > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 0556d140170a4..a484d424119f9 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c [ ... ] > @@ -937,6 +940,11 @@ struct nvmem_device *nvmem_register(const struct nvm= em_config *config) > =20 > ops->reg_read =3D config->reg_read; > ops->reg_write =3D config->reg_write; > + ops->reg_write_const =3D config->reg_write_const; > + > + if (ops->reg_write) > + dev_warn(&nvmem->dev, "Usage of reg_write in nvmem is deprecated, plea= se " > + "migrate to reg_write_const.\n"); [Severity: Low] Will this dev_warn() print an uninitialized device name, since dev_set_name= () hasn't been called on &nvmem->dev yet? Looking further down in nvmem_register(), the device name is assigned later in the switch block: switch (config->id) { case NVMEM_DEVID_NONE: rval =3D dev_set_name(&nvmem->dev, "%s", config->name); break; ... Could this result in the log message printing an uninitialized name like (null) or (unnamed), making it difficult to identify which driver triggered the deprecation warning? Would it make sense to use config->dev (the parent device) for the warning, or move this check below the dev_set_name() block? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260920111000.2404= 131-1-linkmauve@linkmauve.fr?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 432F7C982DA for ; Sun, 20 Sep 2026 11:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lgpf2Z6tj0MOSNWjWKRfNuMiHRdPrX1UurZk7nSZokE=; b=wOBFasD/k2n6cN 8YZ1tYWsrpvm5HdPIcelGl4QLmmTJfBUCqyFJdJ9/MTbWmRQs7adbKznK/va9bhODzSkAgp2naVFo cP0kL65elPYa4jyvQFPsixazZy7jTI48K56/TM4zKli3hfJxqYJC3Y8HFc7yB9Dk4IYephnX8wJ2D S1nynzPuet4mkEWQ3H7kwyRsGY3vbhDCibndVjsXiTKMv8e9Rc1eaP7hXgaAdzZDpR2J5moeescPp fg04VxYK1vIkc7I54vREIf8+JAUid+dy5Hx4Lth5ZjzfBpl4dk275qazTAi/og9huL7O2zRJIIuPK 4TEAKzi/FnjSZTU6xGiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8FaU-0000000HLii-3zeh; Sun, 20 Sep 2026 11:20:02 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8FaT-0000000HLiQ-1a6b for linux-amlogic@lists.infradead.org; Sun, 20 Sep 2026 11:20:01 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 8879E6022C; Sun, 20 Sep 2026 11:20:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 957A51F00893; Sun, 20 Sep 2026 11:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789903200; bh=343/Db1Z8S17ssk821pz0Ch5sbEg1jnS5AmNrMg2Re0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fLLCmqME9mXuW6pALNbtZP1fybu4xfooXafACBbeTqWFPHvxM3Rw4zUR7EmM88WF+ kmReu3VZkYMvYuG2nW5NE9AlEVlSbbybeE9MksDTig9OrZhgbaemiPhNba6ns3oDNM sTEwfjdYrcS6NivXxSgBefGrv7qPMdmI6a23FJ7VyURwGATioxwL1/7KoSDrtaHnyh nf+Eu2TXGh/I1Pny8Dg95shsRPLuXTGua6S+bRhccDfFjwH4eCcI4gK9VOri1jWK2M +YGZddoDnY25JfVZNlO8xcXYgpL5Z5UxEjcB6Dc9iLeNbBh67zFb2+6Sw0VVz3xyze uEycDd0O6sLLA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 2/4] nvmem: core: deprecate reg_write callback with reg_write_const To: "Link Mauve" Cc: neil.armstrong@linaro.org, ojeda@kernel.org, linux-amlogic@lists.infradead.org, Frank.Li@kernel.org, imx@lists.linux.dev, gary@garyguo.net In-Reply-To: <20260920111000.2404131-3-linkmauve@linkmauve.fr> References: <20260920111000.2404131-1-linkmauve@linkmauve.fr> <20260920111000.2404131-3-linkmauve@linkmauve.fr> Date: Sun, 20 Sep 2026 11:19:59 +0000 Message-Id: <20260920111959.957A51F00893@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gbnZtZW06IGRldl93YXJu IHVzZXMgdW5pbml0aWFsaXplZCBkZXZpY2UgbmFtZSBpbiBudm1lbV9yZWdpc3RlcigpCi0tCgpj b21taXQgNzc2NTM5MjdiZGYxOWIzNmMxNTVlNDE2YTY3NjA1MTU5OGRhMDIxMwpBdXRob3I6IExp bmsgTWF1dmUgPGxpbmttYXV2ZUBsaW5rbWF1dmUuZnI+Cgpudm1lbTogY29yZTogZGVwcmVjYXRl IHJlZ193cml0ZSBjYWxsYmFjayB3aXRoIHJlZ193cml0ZV9jb25zdAoKVGhpcyBjb21taXQgZGVw cmVjYXRlcyB0aGUgcmVnX3dyaXRlIGNhbGxiYWNrIGluIGZhdm9yIG9mIHJlZ193cml0ZV9jb25z dCwKd2hpY2ggdGFrZXMgYSBjb25zdCBwb2ludGVyIGZvciB0aGUgdmFsdWUgYnVmZmVyLiBJdCBh bHNvIGFkZHMgYSBkZXByZWNhdGlvbgp3YXJuaW5nIGluIG52bWVtX3JlZ2lzdGVyKCkgZm9yIGRy aXZlcnMgc3RpbGwgdXNpbmcgdGhlIG9sZCBjYWxsYmFjay4KCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvbnZtZW0vY29yZS5jIGIvZHJpdmVycy9udm1lbS9jb3JlLmMKPiBpbmRleCAwNTU2ZDE0MDE3 MGE0Li5hNDg0ZDQyNDExOWY5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbnZtZW0vY29yZS5jCj4g KysrIGIvZHJpdmVycy9udm1lbS9jb3JlLmMKClsgLi4uIF0KCj4gQEAgLTkzNyw2ICs5NDAsMTEg QEAgc3RydWN0IG52bWVtX2RldmljZSAqbnZtZW1fcmVnaXN0ZXIoY29uc3Qgc3RydWN0IG52bWVt X2NvbmZpZyAqY29uZmlnKQo+ICAKPiAgCW9wcy0+cmVnX3JlYWQgPSBjb25maWctPnJlZ19yZWFk Owo+ICAJb3BzLT5yZWdfd3JpdGUgPSBjb25maWctPnJlZ193cml0ZTsKPiArCW9wcy0+cmVnX3dy aXRlX2NvbnN0ID0gY29uZmlnLT5yZWdfd3JpdGVfY29uc3Q7Cj4gKwo+ICsJaWYgKG9wcy0+cmVn X3dyaXRlKQo+ICsJCWRldl93YXJuKCZudm1lbS0+ZGV2LCAiVXNhZ2Ugb2YgcmVnX3dyaXRlIGlu IG52bWVtIGlzIGRlcHJlY2F0ZWQsIHBsZWFzZSAiCj4gKwkJICAgICAgICAgICAgICAgICAgICAg ICJtaWdyYXRlIHRvIHJlZ193cml0ZV9jb25zdC5cbiIpOwoKW1NldmVyaXR5OiBMb3ddCldpbGwg dGhpcyBkZXZfd2FybigpIHByaW50IGFuIHVuaW5pdGlhbGl6ZWQgZGV2aWNlIG5hbWUsIHNpbmNl IGRldl9zZXRfbmFtZSgpCmhhc24ndCBiZWVuIGNhbGxlZCBvbiAmbnZtZW0tPmRldiB5ZXQ/CgpM b29raW5nIGZ1cnRoZXIgZG93biBpbiBudm1lbV9yZWdpc3RlcigpLCB0aGUgZGV2aWNlIG5hbWUg aXMgYXNzaWduZWQgbGF0ZXIKaW4gdGhlIHN3aXRjaCBibG9jazoKCglzd2l0Y2ggKGNvbmZpZy0+ aWQpIHsKCWNhc2UgTlZNRU1fREVWSURfTk9ORToKCQlydmFsID0gZGV2X3NldF9uYW1lKCZudm1l bS0+ZGV2LCAiJXMiLCBjb25maWctPm5hbWUpOwoJCWJyZWFrOwoJLi4uCgpDb3VsZCB0aGlzIHJl c3VsdCBpbiB0aGUgbG9nIG1lc3NhZ2UgcHJpbnRpbmcgYW4gdW5pbml0aWFsaXplZCBuYW1lIGxp a2UKKG51bGwpIG9yICh1bm5hbWVkKSwgbWFraW5nIGl0IGRpZmZpY3VsdCB0byBpZGVudGlmeSB3 aGljaCBkcml2ZXIgdHJpZ2dlcmVkCnRoZSBkZXByZWNhdGlvbiB3YXJuaW5nPwoKV291bGQgaXQg bWFrZSBzZW5zZSB0byB1c2UgY29uZmlnLT5kZXYgKHRoZSBwYXJlbnQgZGV2aWNlKSBmb3IgdGhl IHdhcm5pbmcsCm9yIG1vdmUgdGhpcyBjaGVjayBiZWxvdyB0aGUgZGV2X3NldF9uYW1lKCkgYmxv Y2s/CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNo c2V0LzIwMjYwOTIwMTExMDAwLjI0MDQxMzEtMS1saW5rbWF1dmVAbGlua21hdXZlLmZyP3BhcnQ9 MgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YW1sb2dpYyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo=