Re: [PATCH v7 05/13] leds: trigger: Add hw_offloaded() callback and provide trigger_may_offload_to_hw attribute

[sashiko-bot@kernel.org]

> There are multiple triggers implementing hardware control. However, the
> LED trigger core doesn't really know the hardware control (offloaded)
> state since the coordination is done directly between the trigger and
> the LED driver. It can only assume private triggers as offloaded and
> generic ones as not offloaded.
> 
> Add an hw_offloaded() callback so that triggers can report their
> offloaded states to the LED trigger core. When unimplemented, it
> defaults to true for private triggers and false for generic ones to keep
> the current behavior unchanged.
> 
> With that, provide a new attribute "trigger_may_offload_to_hw", so that
> userspace can determine:
> 
> - if the LED device supports hardware control (supported => visible)
> - which trigger is the hardware control trigger selected by the LED
>   device and offloaded to hardware ("[foo_trigger]")
> 
> Note: the documentation describes the attribute as "returning a list"
> despite the LED core currently only supports one hardware control
> trigger per LED device. This is intentional to make the attribute
> extensible in the future without breaking userspace. IOW, userspace
> should parse the new attribute in the same way as
> /sys/class/leds/<led>/trigger.
> 
> Acked-by: Ike Panhc <ikepanhc@gmail.com>
> Signed-off-by: Rong Zhang <i@rong.moe>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-leds-trigger-hw-changed-v7-0-fe3cdb6dec51@rong.moe?part=5