Re: [PATCH v3 11/18] ARM: dts: ux500: Add power domains

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: undocumented power-domains property causes schema validation failure
--

commit 043bcab3d2585239bd006e899482166025b03c26
Author: Linus Walleij <linusw@kernel.org>

ARM: dts: ux500: Add power domains

This commit adds power domain properties to CPUs and various SoC peripherals
in the DBX500 device tree. Both CPUs are updated to share DOMAIN_VARM, which
also supplies their PMU.

> diff --git a/arch/arm/boot/dts/st/ste-dbx5x0.dtsi b/arch/arm/boot/dts/st/ste-dbx5x0.dtsi
> index 11fcae1904e20..0603244dc9e83 100644
> --- a/arch/arm/boot/dts/st/ste-dbx5x0.dtsi
> +++ b/arch/arm/boot/dts/st/ste-dbx5x0.dtsi
[ ... ]
> @@ -154,6 +156,7 @@ sram@40020000 {
>  			reg = <0x40020000 0x40000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> +			power-domains = <&pm_domains DOMAIN_ESRAM_12>;

[Severity: Low]
Does this cause strict schema validation to fail during dtbs_check? The
mmio-sram binding strictly prohibits undocumented properties and does not list
power-domains.

[ ... ]
> @@ -314,11 +319,13 @@ intc: interrupt-controller@a0411000 {
>  			interrupt-controller;
>  			reg = <0xa0411000 0x1000>,
>  			      <0xa0410100 0x100>;
> +			power-domains = <&pm_domains DOMAIN_VARM>;
>  		};
>  
>  		scu@a0410000 {
>  			compatible = "arm,cortex-a9-scu";
>  			reg = <0xa0410000 0x100>;
> +			power-domains = <&pm_domains DOMAIN_VARM>;

[Severity: Low]
Similarly, does the addition of power-domains here trigger a warning? The
arm,scu.yaml binding prohibits undocumented properties and does not define
power-domains for arm,cortex-a9-scu.

[ ... ]
> @@ -393,7 +415,7 @@ mtu@a03c6000 {
>  			compatible = "st,nomadik-mtu";
>  			reg = <0xa03c6000 0x1000>;
>  			interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> -
> +			power-domains = <&pm_domains DOMAIN_VAPE>;

[Severity: Low]
Will this fail dtbs_check validation? The st,nomadik-mtu binding does not
list power-domains and typically prohibits undocumented properties.

[ ... ]
> @@ -435,6 +458,7 @@ gpio0: gpio@8012e000 {
>  			gpio-bank = <0>;
>  			gpio-ranges = <&pinctrl 0 0 32>;
>  			clocks = <&prcc_pclk 1 9>;
> +			power-domains = <&pm_domains DOMAIN_VAPE>;

[Severity: Low]
Does this property need to be added to the st,nomadik-gpio.yaml schema first?
The schema has unevaluatedProperties: false and currently does not define
power-domains.

[ ... ]
> @@ -613,9 +646,11 @@ dma: dma-controller@801C0000 {
>  			memcpy-channels = <56 57 58 59 60>;
>  
>  			clocks = <&prcmu_clk PRCMU_DMACLK>;
> +			power-domains = <&pm_domains DOMAIN_VAPE>;

[Severity: Low]
Could this undocumented property in stericsson,dma40.yaml cause dtbs_check
to fail? That schema uses additionalProperties: false without listing
power-domains.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-ux500-power-domains-v7-1-v3-0-9352be6b86b1@kernel.org?part=11