From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Park Tae-sun <ts930@dgu.ac.kr>
Cc: Rui Miguel Silva <rmfrfs@gmail.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: light: use sysfs_emit() instead of sprintf()
Date: Sun, 20 Sep 2026 16:03:48 +0200 [thread overview]
Message-ID: <2026092047-dubbed-gracious-154c@gregkh> (raw)
In-Reply-To: <178991148304.29938.6850889942806082479@naver.com>
On Sun, Sep 20, 2026 at 10:38:03PM +0900, ts930@naver.com wrote:
> From: Park Tae-sun <ts930@dgu.ac.kr>
>
> The sysfs documentation (Documentation/filesystems/sysfs.rst) recommends
> using sysfs_emit() instead of sprintf() in sysfs show() callbacks.
>
> Replace the remaining sprintf() calls in the fade_##__dir##_show()
> macro and color_show() callback with sysfs_emit().
>
> This follows the standard kernel practice and existing use of
> sysfs_emit() in other Greybus sysfs show functions.
>
> No functional change.
How is this different from past patches that have attempted to change
this?
thanks,
greg k-h
next prev parent reply other threads:[~2026-09-20 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 13:38 [PATCH] staging: greybus: light: use sysfs_emit() instead of sprintf() ts930
2026-09-20 14:03 ` Greg Kroah-Hartman [this message]
[not found] ` <CAFPGN2hgqTyg+jpsY_XzbNPijV3Zce3Drw3a_c8pDBZH1hXV2w@mail.gmail.com>
2026-09-21 12:32 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2026-08-08 17:13 Mohit Mishra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026092047-dubbed-gracious-154c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rmfrfs@gmail.com \
--cc=ts930@dgu.ac.kr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.