From: sashiko-bot@kernel.org
To: "Nicolo Giuliani" <nicolo.giuliani6@studio.unibo.it>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: arm: marvell: Add Sophos XGS 107w NPU
Date: Mon, 21 Sep 2026 00:33:29 +0000 [thread overview]
Message-ID: <20260921003330.5592B1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921-send-dt-v2-2-fb6b81002ad7@studio.unibo.it>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: incomplete compatible fallback chain for sophos,xgs107w-npu
--
commit b3e0e1fbccb36ab57b4650e23b8463d430afac8e
Author: Nicolo Giuliani <nicolo.giuliani6@studio.unibo.it>
dt-bindings: arm: marvell: Add Sophos XGS 107w NPU
The Sophos XGS 87/107 desktop firewalls combine an AMD x86 host with a
separate network processing unit (NPU) using a Marvell Armada CN9130 SoC.
This commit documents the compatible string of the NPU board.
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> index 7e77310da626f..130128c46219e 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> @@ -118,6 +118,13 @@ properties:
> - const: marvell,armada-ap807-quad
> - const: marvell,armada-ap807
>
> + - description:
> + Sophos XGS 87/107 network processing unit (Armada CN9130 SoC
> + with an 88E6193X switch)
> + items:
> + - const: sophos,xgs107w-npu
> + - const: marvell,cn9130
[Severity: Low]
Does this compatible list force an incomplete fallback chain?
The items array strictly limits the compatible property to exactly two strings.
The canonical definition of the CN9130 SoC includes a three-string fallback
chain (marvell,cn9130, marvell,armada-ap807-quad, marvell,armada-ap807).
Limiting the list to two items here forces device tree authors to artificially
truncate the fallback chain to pass validation. Running dt_binding_check or
dtbs_check on a device tree that correctly preserves the full sequence will
fail with a "too many items" schema error.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-send-dt-v2-0-fb6b81002ad7@studio.unibo.it?part=2
next prev parent reply other threads:[~2026-09-21 0:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 0:26 [PATCH v2 0/3] arm64: dts: marvell: Add Sophos XGS 107w NPU Nicolo Giuliani
2026-09-21 0:26 ` Nicolo Giuliani via B4 Relay
2026-09-21 0:26 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Sophos Nicolo Giuliani
2026-09-21 0:26 ` Nicolo Giuliani via B4 Relay
2026-09-21 0:26 ` [PATCH v2 2/3] dt-bindings: arm: marvell: Add Sophos XGS 107w NPU Nicolo Giuliani
2026-09-21 0:26 ` Nicolo Giuliani via B4 Relay
2026-09-21 0:33 ` sashiko-bot [this message]
2026-09-24 13:15 ` Krzysztof Kozlowski
2026-09-21 0:26 ` [PATCH v2 3/3] arm64: dts: marvell: Add Sophos XGS 107w NPU board Nicolo Giuliani
2026-09-21 0:26 ` Nicolo Giuliani via B4 Relay
2026-09-22 12:08 ` Andrew Lunn
2026-09-30 8:35 ` R: [PATCH v2 0/3] arm64: dts: marvell: Add Sophos XGS 107w NPU Nicolò Giuliani - nicolo.giuliani6@studio.unibo.it
2026-09-30 8:53 ` Gregory Clement
2026-09-30 19:52 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921003330.5592B1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=nicolo.giuliani6@studio.unibo.it \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.