Re: [PATCH] dt-bindings: mtd: convert IBM NDFC binding to YAML

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] mtd: missing eiger.dts update breaks dtbs_check
- [Low] dt-bindings: unit address mismatch in YAML example
--

commit ef4d9a61ebafb45b3d3ff44afa9f87f46f05cad7
Author: Rosen Penev <rosenp@gmail.com>

dt-bindings: mtd: convert IBM NDFC binding to YAML

The NDFC NAND flash controller was only described in a legacy text file,
so dtbs_check reported a failure to match any schema for the ndfc nodes
of several device trees. This patch converts the binding to YAML format
and describes the node's properties.

> eiger's ndfc node omits reg (supplied by U-Boot), so add a placeholder
> there to satisfy the newly required property, matching the flash@0,0
> node in the same file.

[Severity: Medium]
Since the new ibm,ndfc.yaml makes the reg property required, running
make dtbs_check on PowerPC architectures will fail for eiger.dts because
the node omits it.

The commit message mentions adding a placeholder to eiger.dts, but the
patch entirely omits any modification to arch/powerpc/boot/dts/eiger.dts.
Could the eiger.dts update have been accidentally dropped from this patch?

> diff --git a/Documentation/devicetree/bindings/mtd/ibm,ndfc.yaml b/Documentation/devicetree/bindings/mtd/ibm,ndfc.yaml
> new file mode 100644
> index 0000000000000..96e25771a8fe9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/ibm,ndfc.yaml

[ ... ]

> +                partition@0 {
> +                    label = "kernel";
> +                    reg = <0x00000000 0x00200000>;
> +                };
> +                partition@200000 {
> +                    label = "root";
> +                    reg = <0x00000000 0x03e00000>;

[Severity: Low]
Will this mismatched unit address cause a simple_bus_reg warning?

In the example, partition@200000 defines reg = <0x00000000 0x03e00000>.
The address 0x00000000 does not match the unit address 200000 (which was
correctly 0x00200000 in the old text bindings). Running validation on the
newly added YAML schema might fail here.

> +                };
> +            };
> +        };
> +    };
> +...

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921015719.1045365-1-rosenp@gmail.com?part=1