From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Mika Westerberg <westeri@kernel.org>,
Shyam Sundar S K <shyam-sundar.s-k@amd.com>,
Elie Morisse <syniurge@gmail.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Devyn Liu <liudingyuan@h-partners.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Binbin Zhou <zhoubinbin@loongson.cn>,
Khalil Blaiech <kblaiech@nvidia.com>,
Asmaa Mnebhi <asmaa@nvidia.com>,
Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>,
Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
Ard Biesheuvel <ardb@kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Israel Cepeda <israel.a.cepeda.lopez@intel.com>,
Hans de Goede <hansg@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Hu <hanshu@zhaoxin.com>,
George Cherian <gcherian@marvell.com>,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: busses: use named initializers for acpi_device_id
Date: Mon, 21 Sep 2026 06:51:55 +0200 [thread overview]
Message-ID: <20260921045155.GL106095@black.igk.intel.com> (raw)
In-Reply-To: <20260918-acpi-i2c-v1-2-caf4bea4886c@thegoodpenguin.co.uk>
On Fri, Sep 18, 2026 at 02:01:51PM +0100, Pawel Zalewski wrote:
> Use a designated initializer for the acpi_device_id fields which makes the
> code more readable and consistent with how lists are initialized in the
> rest of the kernel code base. Also drop explicitly setting fields to 0
> where it is redundant.
>
> Unify the list terminator to have a single space between the brackets and
> no trailing comma.
>
> Unify list item alignment to have a single space padding between the
> brackets.
>
> Signed-off-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
> ---
> drivers/i2c/busses/i2c-amd-asf-plat.c | 2 +-
> drivers/i2c/busses/i2c-amd-mp2-plat.c | 2 +-
> drivers/i2c/busses/i2c-cros-ec-tunnel.c | 2 +-
> drivers/i2c/busses/i2c-designware-platdrv.c | 42 ++++++++++++++---------------
For i2c-dw:
Acked-by: Mika Westerberg <westeri@kernel.org>
next prev parent reply other threads:[~2026-09-21 4:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 13:01 [PATCH 0/2] i2c: use designated initializers for acpi_device_id Pawel Zalewski
2026-09-18 13:01 ` [PATCH 1/2] i2c: i2c-core-acpi: use named " Pawel Zalewski
2026-09-21 4:49 ` Mika Westerberg
2026-10-13 15:48 ` Thierry Reding
2026-10-13 15:51 ` Thierry Reding
2026-09-18 13:01 ` [PATCH 2/2] i2c: busses: " Pawel Zalewski
2026-09-21 4:51 ` Mika Westerberg [this message]
2026-10-13 10:57 ` [PATCH 0/2] i2c: use designated " Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921045155.GL106095@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Frank.Li@nxp.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ardb@kernel.org \
--cc=asmaa@nvidia.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=digetx@gmail.com \
--cc=festevam@gmail.com \
--cc=gcherian@marvell.com \
--cc=groeck@chromium.org \
--cc=hansg@kernel.org \
--cc=hanshu@zhaoxin.com \
--cc=imx@lists.linux.dev \
--cc=israel.a.cepeda.lopez@intel.com \
--cc=jonathanh@nvidia.com \
--cc=kblaiech@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=ldewangan@nvidia.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=liudingyuan@h-partners.com \
--cc=mukesh.savaliya@oss.qualcomm.com \
--cc=o.rempel@pengutronix.de \
--cc=pzalewski@thegoodpenguin.co.uk \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shyam-sundar.s-k@amd.com \
--cc=syniurge@gmail.com \
--cc=thierry.reding@kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
--cc=westeri@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.