From: Christoph Hellwig <hch@lst.de>
To: "Ing. Alfonso Kuen Arroyo" <gerencia@idkmanager.com>
Cc: hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
mlombard@arkamax.eu
Subject: Re: [PATCH] nvmet-tcp: fix stale comment on NVMET_TCP_MAXH2CDATA
Date: Mon, 21 Sep 2026 08:54:48 +0200 [thread overview]
Message-ID: <20260921065448.GA13764@lst.de> (raw)
In-Reply-To: <178978695312.43804.1554581215424967584@idkmanager.com>
On Fri, Sep 18, 2026 at 10:02:33PM -0500, Ing. Alfonso Kuen Arroyo wrote:
> #define NVMET_TCP_DEF_INLINE_DATA_SIZE (4 * PAGE_SIZE)
> -#define NVMET_TCP_MAXH2CDATA 0x400000 /* 16M arbitrary limit */
> +#define NVMET_TCP_MAXH2CDATA 0x400000 /* 4M arbitrary limit */
Maybe use SZ_4M instead of having a value and a comment that can get
out of sync?
next prev parent reply other threads:[~2026-09-21 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 3:02 [PATCH] nvmet-tcp: fix stale comment on NVMET_TCP_MAXH2CDATA Ing. Alfonso Kuen Arroyo
2026-09-21 6:54 ` Christoph Hellwig [this message]
2026-09-21 13:42 ` Ing. Alfonso Kuen Arroyo
2026-09-22 6:23 ` Maurizio Lombardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921065448.GA13764@lst.de \
--to=hch@lst.de \
--cc=gerencia@idkmanager.com \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mlombard@arkamax.eu \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.