From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E00DE43DED7 for ; Mon, 21 Sep 2026 08:13:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789978436; cv=none; b=Ua14CBjblzQ4+abbF8CH7gx5TUIdh4Th2Net3n5CiOy+Tq4UH7laUrDHEScIhHM8BonTBle61I3P0j7PR3HbuH3tx56fSE4RIVSQQspvpCv4y468sudbtbmlVm4JEXYjaPUaBS646lwE7/IgqEfXNMVBBgZsz6rMgjc6wtUR7+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789978436; c=relaxed/simple; bh=14DdJd2gyFd5iE4lLyFJW3jtWmsZihzx/zIP988lSGs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=mWg0ZQ9FcLvBoUr5p6oYNvzsHS+Fu8CHVNQ3pUDcTOypmlHQutFziY0dZiMMAuT74bx7revgDGcJNIJH+3FiLvRDJ9y4MApmyHRfIKLM1v8Jgdts9+z1vmS+DzQ+nxsJU2WtG4MBSql+2H7QAPkwvqZ88TcTyUOfFI9dGaIYJ9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kfknk6HW; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kfknk6HW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37C561F000FF; Mon, 21 Sep 2026 08:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789978434; bh=eKCFZ6M4EMEb0RxVM5oBQhZLNCEVB4QYyFA/3HKxp74=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Kfknk6HWp4BAgO07yCdsDBVLNb+MkKmZRM1DvZB9jcgKpGxqQLexwGHM9h+WGwQ7d XFQyIWi7URJ52gucYhFi8pgKLGQv0SOjzgUSxngK2oREZb6F73zT9VWk/uzjIbhgz4 dfo1qJbq2lZbmX5NNgkYAaBf1LWnOU2vM5L1aI+uV7mcxrrBoTWahXiJMQdopVA2md iE5FPbCR5DAto0pffUC4uLbZFqcAr44vWjXJg/jNLXqyyoJf+i8iDPuIY7p45d91qa YXvLSDvgEuhsdc0u4s2/l+fs10g0BF7zmyIOilJjT8AyUyS4x99nAc1UUDnPpkJwAW scz/7OaXFBIUw== From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/3] dt-bindings: net: meson-dwmac: add T7 support Reply-To: sashiko-reviews@lists.linux.dev To: "Xianwei Zhao" Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org In-Reply-To: <20260920-t7-node-new-v1-2-e6e0840c1b0b@amlogic.com> References: <20260920-t7-node-new-v1-0-e6e0840c1b0b@amlogic.com> <20260920-t7-node-new-v1-2-e6e0840c1b0b@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 21 Sep 2026 08:13:53 +0000 Message-Id: <20260921081354.37C561F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Medium] dt-bindings: net: meson-dwmac: missing t7-dwmac in select block - [Medium] dt-bindings: net: meson-dwmac: missing t7-dwmac in generational = constraints -- commit cf2bd16c5188a0d6d2a0e2fdf91dd50ebfa695b8 Author: Xianwei Zhao dt-bindings: net: meson-dwmac: add T7 support Adds the T7 compatible string to the Meson DWMAC binding and adds a conditional schema check to enforce the correct compatible combination. > diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.ya= ml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml > index 5c91716d1f21e..f75a275e2d759 100644 > --- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml > @@ -28,6 +28,18 @@ select: [Severity: Medium] Should amlogic,t7-dwmac be added to the select block? If a node is added with compatible =3D "amlogic,t7-dwmac";, it appears the dt-validator will skip this schema entirely if the string is not explicitly listed in the select properties. This would bypass the new allOf.if rules added below. > =20 > allOf: > - $ref: snps,dwmac.yaml# > + - if: > + properties: > + compatible: > + contains: > + const: amlogic,t7-dwmac > + then: > + properties: > + compatible: > + items: > + - const: amlogic,t7-dwmac > + - const: amlogic,meson-axg-dwmac > + - const: snps,dwmac-4.00 [ ... ] > @@ -139,8 +151,10 @@ properties: > - amlogic,meson-gxbb-dwmac > - amlogic,meson-axg-dwmac > - amlogic,meson-g12a-dwmac > + - amlogic,t7-dwmac [Severity: Medium] Does this new compatible string also need to be added to the existing allOf.if blocks that check for amlogic,meson-axg-dwmac? Since T7 uses AXG as a fallback, it shares its hardware constraints like clocks and rx-internal-delay-ps. By omitting amlogic,t7-dwmac from those existing conditional blocks, the schema implicitly relies on the fallback string to trigger validation. A missing fallback string in a device tree would bypass these generational constraints. > contains: > enum: > + - snps,dwmac-4.00 > - snps,dwmac-3.70a > - snps,dwmac --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260920-t7-node-ne= w-v1-0-e6e0840c1b0b@amlogic.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7D46C982DE for ; Mon, 21 Sep 2026 08:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q5f5fZ4ZjK0JzEMMQQeS2w+D0jlup8OKC974Ic8BlB0=; b=eH3FE/MJLR9KPB iyfqLHAqQ1tQpifKCZrn/+QDLYaW/3C9FRLg6uBQICh4erBcDrIAgphsozxCfdGWUcxF9/S025n0t 0vG/FJEc5HW5mdfkfq7Hpa/X84X3+GA4GJmk3Sq5qiQGLIqB4lzfudaw2bX8pEeDVXVtNTqsoEtQS snop/cJq5PyQJTRAq1qIX+A0wwsftiEDI/9RLTJ1WndHoHsh3Sgszh6dR2jvJeRsCzkrRY+gZIsdd AFcyjdvcMZATJvTMZdmP8hEMzXYL3ET2M1z+un5btO5hRxZbCmlVqlWM21PKMi67To1Yy/AcZi3f8 L715pKniDZZUksxaDCgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8Z9w-00000001JVQ-1sXI; Mon, 21 Sep 2026 08:13:56 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8Z9v-00000001JVA-1CN9 for linux-amlogic@lists.infradead.org; Mon, 21 Sep 2026 08:13:55 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id AC6C843B72; Mon, 21 Sep 2026 08:13:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37C561F000FF; Mon, 21 Sep 2026 08:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789978434; bh=eKCFZ6M4EMEb0RxVM5oBQhZLNCEVB4QYyFA/3HKxp74=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Kfknk6HWp4BAgO07yCdsDBVLNb+MkKmZRM1DvZB9jcgKpGxqQLexwGHM9h+WGwQ7d XFQyIWi7URJ52gucYhFi8pgKLGQv0SOjzgUSxngK2oREZb6F73zT9VWk/uzjIbhgz4 dfo1qJbq2lZbmX5NNgkYAaBf1LWnOU2vM5L1aI+uV7mcxrrBoTWahXiJMQdopVA2md iE5FPbCR5DAto0pffUC4uLbZFqcAr44vWjXJg/jNLXqyyoJf+i8iDPuIY7p45d91qa YXvLSDvgEuhsdc0u4s2/l+fs10g0BF7zmyIOilJjT8AyUyS4x99nAc1UUDnPpkJwAW scz/7OaXFBIUw== From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/3] dt-bindings: net: meson-dwmac: add T7 support To: "Xianwei Zhao" Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org In-Reply-To: <20260920-t7-node-new-v1-2-e6e0840c1b0b@amlogic.com> References: <20260920-t7-node-new-v1-0-e6e0840c1b0b@amlogic.com> <20260920-t7-node-new-v1-2-e6e0840c1b0b@amlogic.com> Date: Mon, 21 Sep 2026 08:13:53 +0000 Message-Id: <20260921081354.37C561F000FF@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gZHQtYmluZGluZ3M6 IG5ldDogbWVzb24tZHdtYWM6IG1pc3NpbmcgdDctZHdtYWMgaW4gc2VsZWN0IGJsb2NrCi0gW01l ZGl1bV0gZHQtYmluZGluZ3M6IG5ldDogbWVzb24tZHdtYWM6IG1pc3NpbmcgdDctZHdtYWMgaW4g Z2VuZXJhdGlvbmFsIGNvbnN0cmFpbnRzCi0tCgpjb21taXQgY2YyYmQxNmM1MTg4YTBkNmQyYTBl MmZkZjkxZGQ1MGViZmE2OTViOApBdXRob3I6IFhpYW53ZWkgWmhhbyA8eGlhbndlaS56aGFvQGFt bG9naWMuY29tPgoKZHQtYmluZGluZ3M6IG5ldDogbWVzb24tZHdtYWM6IGFkZCBUNyBzdXBwb3J0 CgpBZGRzIHRoZSBUNyBjb21wYXRpYmxlIHN0cmluZyB0byB0aGUgTWVzb24gRFdNQUMgYmluZGlu ZyBhbmQgYWRkcyBhCmNvbmRpdGlvbmFsIHNjaGVtYSBjaGVjayB0byBlbmZvcmNlIHRoZSBjb3Jy ZWN0IGNvbXBhdGlibGUgY29tYmluYXRpb24uCgo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvbmV0L2FtbG9naWMsbWVzb24tZHdtYWMueWFtbCBiL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvYW1sb2dpYyxtZXNvbi1kd21hYy55YW1s Cj4gaW5kZXggNWM5MTcxNmQxZjIxZS4uZjc1YTI3NWUyZDc1OSAxMDA2NDQKPiAtLS0gYS9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbmV0L2FtbG9naWMsbWVzb24tZHdtYWMueWFt bAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9uZXQvYW1sb2dpYyxt ZXNvbi1kd21hYy55YW1sCj4gQEAgLTI4LDYgKzI4LDE4IEBAIHNlbGVjdDoKCltTZXZlcml0eTog TWVkaXVtXQpTaG91bGQgYW1sb2dpYyx0Ny1kd21hYyBiZSBhZGRlZCB0byB0aGUgc2VsZWN0IGJs b2NrPwoKSWYgYSBub2RlIGlzIGFkZGVkIHdpdGggY29tcGF0aWJsZSA9ICJhbWxvZ2ljLHQ3LWR3 bWFjIjssIGl0IGFwcGVhcnMgdGhlCmR0LXZhbGlkYXRvciB3aWxsIHNraXAgdGhpcyBzY2hlbWEg ZW50aXJlbHkgaWYgdGhlIHN0cmluZyBpcyBub3QgZXhwbGljaXRseQpsaXN0ZWQgaW4gdGhlIHNl bGVjdCBwcm9wZXJ0aWVzLiBUaGlzIHdvdWxkIGJ5cGFzcyB0aGUgbmV3IGFsbE9mLmlmIHJ1bGVz CmFkZGVkIGJlbG93LgoKPiAgCj4gIGFsbE9mOgo+ICAgIC0gJHJlZjogc25wcyxkd21hYy55YW1s Iwo+ICsgIC0gaWY6Cj4gKyAgICAgIHByb3BlcnRpZXM6Cj4gKyAgICAgICAgY29tcGF0aWJsZToK PiArICAgICAgICAgIGNvbnRhaW5zOgo+ICsgICAgICAgICAgICBjb25zdDogYW1sb2dpYyx0Ny1k d21hYwo+ICsgICAgdGhlbjoKPiArICAgICAgcHJvcGVydGllczoKPiArICAgICAgICBjb21wYXRp YmxlOgo+ICsgICAgICAgICAgaXRlbXM6Cj4gKyAgICAgICAgICAgIC0gY29uc3Q6IGFtbG9naWMs dDctZHdtYWMKPiArICAgICAgICAgICAgLSBjb25zdDogYW1sb2dpYyxtZXNvbi1heGctZHdtYWMK PiArICAgICAgICAgICAgLSBjb25zdDogc25wcyxkd21hYy00LjAwCgpbIC4uLiBdCgo+IEBAIC0x MzksOCArMTUxLDEwIEBAIHByb3BlcnRpZXM6Cj4gICAgICAgICAgICAtIGFtbG9naWMsbWVzb24t Z3hiYi1kd21hYwo+ICAgICAgICAgICAgLSBhbWxvZ2ljLG1lc29uLWF4Zy1kd21hYwo+ICAgICAg ICAgICAgLSBhbWxvZ2ljLG1lc29uLWcxMmEtZHdtYWMKPiArICAgICAgICAgIC0gYW1sb2dpYyx0 Ny1kd21hYwoKW1NldmVyaXR5OiBNZWRpdW1dCkRvZXMgdGhpcyBuZXcgY29tcGF0aWJsZSBzdHJp bmcgYWxzbyBuZWVkIHRvIGJlIGFkZGVkIHRvIHRoZSBleGlzdGluZwphbGxPZi5pZiBibG9ja3Mg dGhhdCBjaGVjayBmb3IgYW1sb2dpYyxtZXNvbi1heGctZHdtYWM/CgpTaW5jZSBUNyB1c2VzIEFY RyBhcyBhIGZhbGxiYWNrLCBpdCBzaGFyZXMgaXRzIGhhcmR3YXJlIGNvbnN0cmFpbnRzIGxpa2UK Y2xvY2tzIGFuZCByeC1pbnRlcm5hbC1kZWxheS1wcy4gQnkgb21pdHRpbmcgYW1sb2dpYyx0Ny1k d21hYyBmcm9tIHRob3NlCmV4aXN0aW5nIGNvbmRpdGlvbmFsIGJsb2NrcywgdGhlIHNjaGVtYSBp bXBsaWNpdGx5IHJlbGllcyBvbiB0aGUgZmFsbGJhY2sKc3RyaW5nIHRvIHRyaWdnZXIgdmFsaWRh dGlvbi4gQSBtaXNzaW5nIGZhbGxiYWNrIHN0cmluZyBpbiBhIGRldmljZSB0cmVlCndvdWxkIGJ5 cGFzcyB0aGVzZSBnZW5lcmF0aW9uYWwgY29uc3RyYWludHMuCgo+ICAgICAgY29udGFpbnM6Cj4g ICAgICAgIGVudW06Cj4gKyAgICAgICAgLSBzbnBzLGR3bWFjLTQuMDAKPiAgICAgICAgICAtIHNu cHMsZHdtYWMtMy43MGEKPiAgICAgICAgICAtIHNucHMsZHdtYWMKCi0tIApTYXNoaWtvIEFJIHJl dmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA5MjAtdDctbm9kZS1u ZXctdjEtMC1lNmUwODQwYzFiMGJAYW1sb2dpYy5jb20/cGFydD0yCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlz dApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hbWxvZ2ljCg==