From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4D95C982E1 for ; Mon, 21 Sep 2026 08:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ALU7XpLK2CagdnJmRCudPCaNDmknwf8srJ0K8olO2is=; b=jAI0ZwuEGVmIPL u61gQg3EMq82w5sMhnqvnyR4+nu7qxwINy3j1ssjLSmJA9w4HAIViM/WUT3K7H+oPUl22r+/oO3zI LkvJE8N1y2YYzqiSu6UzU5frLZObg2AHzl2s895bkK8Kx1oCptHSx8keBF/thsHwVY+KhYk+9agEI z+/zVpQg7LCgEc07ipdQg2KMTb7PRjpoTHUX6VJcyCTmIIjuT9tcngSuNYLmMWPYXBsbLLFsCnSuB ySdVfT1752YJTaFHA1Pplb3wesMVlZGRQkDyWhMDkRwg5YGNPp2xoSULR1fP7x1nmCsoSL45y/So+ Da4u/gZAg9LQriNNpSeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8Z9x-00000001JVY-2Apm; Mon, 21 Sep 2026 08:13:57 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8Z9v-00000001JVI-3IV3 for linux-amlogic@lists.infradead.org; Mon, 21 Sep 2026 08:13:55 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 8B89440E56; Mon, 21 Sep 2026 08:13:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B4951F00893; Mon, 21 Sep 2026 08:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789978435; bh=kmLTRNY1kc2se1JCA9fEugMVStcIxV4+UhGwHWOQnwo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=dIHtaix/nXCu2qX9GynTmq3EQFPMc4tQtf2tl+VArguVtyLE+vbrx/JdNNb7xIY25 tQ9eQI1Em3gSTQ77xsmzIOhA0u4iApHYk/+8TwcjM23ZGfQtynLHXOlOassCHnArpB IN14WIvm4m10MfgbUwZ/QERrfQD0KWLmlhQIfvN4/DA1BK8j4TlCp10ss88ehXLCKh phRW6kqQXMzpx8J0XV4U0XDEwSqm9pIM4ZGSxamw4S/2kpm7G96tRFTyDNjf4DhscI zihoiYtucIssNEMNPNcaUaGi2LhaVhSgbrwC2yJ9uIoX71bFr2d+UVufH7JIeQtU9r X+Nm0MQAmI7Vw== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/3] arm64: dts: amlogic: add T7 peripheral nodes To: "Xianwei Zhao" Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org In-Reply-To: <20260920-t7-node-new-v1-3-e6e0840c1b0b@amlogic.com> References: <20260920-t7-node-new-v1-0-e6e0840c1b0b@amlogic.com> <20260920-t7-node-new-v1-3-e6e0840c1b0b@amlogic.com> Date: Mon, 21 Sep 2026 08:13:54 +0000 Message-Id: <20260921081355.1B4951F00893@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gZHQ6IGkyYzIgbm9k ZSBpcyB1bmNvbmRpdGlvbmFsbHkgZW5hYmxlZCBpbiBTb0MgZHRzaQotIFtMb3ddIGR0OiBldGhl cm5ldC1waHkgbm9kZSBuYW1lIHZpb2xhdGVzIHNjaGVtYSAodXNlcyB1bmRlcnNjb3JlKQotIFtM b3ddIGR0OiBmaXhlZCByZWd1bGF0b3JzIGRlZmluZSBlbmFibGUtYWN0aXZlLWhpZ2ggd2l0aG91 dCBncGlvCi0gW0xvd10gZHQ6IG5ldyBVQVJUIG5vZGVzIG9taXQgbWFuZGF0b3J5IGNsb2NrcyBw cm9wZXJ0aWVzCi0tCgpjb21taXQgNmZhOTYyMDAwM2QyZTk5YWRlZTBlMWNkMTA2NDUwYjlkMGFh YmIyZApBdXRob3I6IFhpYW53ZWkgWmhhbyA8eGlhbndlaS56aGFvQGFtbG9naWMuY29tPgoKYXJt NjQ6IGR0czogYW1sb2dpYzogYWRkIFQ3IHBlcmlwaGVyYWwgbm9kZXMKCkFkZCBkZXZpY2UgdHJl ZSBkZXNjcmlwdGlvbnMgZm9yIHRoZSBwZXJpcGhlcmFscyBvbiB0aGUgQW1sb2dpYyBUNwpTb0Mg YW5kIHRoZSBUNyBBMzExRDIgQU40MDAgYm9hcmQuCgpBZGQgc3VwcG9ydCBmb3IgdGhlIFQ3IEV0 aGVybmV0IGNvbnRyb2xsZXIsIFNQSSBjb250cm9sbGVycywgSTJDCmNvbnRyb2xsZXJzLCBVQVJU cywgcGluY3RybCBncm91cHMsIHJlZ3VsYXRvcnMsIGFuZCByZXNlcnZlZCBtZW1vcnkuCkFsc28g ZW5hYmxlIHRoZSBFdGhlcm5ldCBjb250cm9sbGVyIG9uIHRoZSBBTjQwMCBib2FyZC4KCj4gZGlm ZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvYW1sb2dpYy9hbWxvZ2ljLXQ3LWEzMTFkMi1h bjQwMC5kdHMgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2FtbG9naWMvYW1sb2dpYy10Ny1hMzExZDIt YW40MDAuZHRzCj4gaW5kZXggY2E3NTM2Zjc3MmZmMS4uZGZkODIxNDgxNzliMCAxMDA2NDQKPiAt LS0gYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2FtbG9naWMvYW1sb2dpYy10Ny1hMzExZDItYW40MDAu ZHRzCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9hbWxvZ2ljL2FtbG9naWMtdDctYTMxMWQy LWFuNDAwLmR0cwoKWyAuLi4gXQoKPiArCXZkZGFvXzN2MzogcmVndWxhdG9yLXZkZGFvLTN2MyB7 Cj4gKwkJdmluLXN1cHBseSA9IDwmZGNfaW4+Owo+ICsJCWNvbXBhdGlibGUgPSAicmVndWxhdG9y LWZpeGVkIjsKPiArCQlyZWd1bGF0b3ItbmFtZSA9ICJWRERBT18zVjMiOwo+ICsJCXJlZ3VsYXRv ci1taW4tbWljcm92b2x0ID0gPDMzMDAwMDA+Owo+ICsJCXJlZ3VsYXRvci1tYXgtbWljcm92b2x0 ID0gPDMzMDAwMDA+Owo+ICsJCXN0YXJ0dXAtZGVsYXktdXMgPSA8NzAwMDA+Owo+ICsJCWVuYWJs ZS1hY3RpdmUtaGlnaDsKCltTZXZlcml0eTogTG93XQpEb2VzIHRoaXMgcmVndWxhdG9yIGFjdHVh bGx5IG5lZWQgdGhlIGVuYWJsZS1hY3RpdmUtaGlnaCBwcm9wZXJ0eT8gV2l0aG91dApzcGVjaWZ5 aW5nIGEgZ3BpbywgdGhpcyBwcm9wZXJ0eSB3aWxsIG5vdCBoYXZlIGEgZnVuY3Rpb25hbCBlZmZl Y3QuCgo+ICsJCXJlZ3VsYXRvci1ib290LW9uOwo+ICsJCXJlZ3VsYXRvci1hbHdheXMtb247Cj4g Kwl9OwoKWyAuLi4gXQoKPiArCXZkZF9kZHI6IHJlZ3VsYXRvci12ZGQtZGRyIHsKPiArCQl2aW4t c3VwcGx5ID0gPCZkY19pbj47Cj4gKwkJY29tcGF0aWJsZSA9ICJyZWd1bGF0b3ItZml4ZWQiOwo+ ICsJCXJlZ3VsYXRvci1uYW1lID0gIlZERF9ERFIiOwo+ICsJCXJlZ3VsYXRvci1taW4tbWljcm92 b2x0ID0gPDgwMDAwMD47Cj4gKwkJcmVndWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8ODAwMDAwPjsK PiArCQlzdGFydHVwLWRlbGF5LXVzID0gPDcwMDAwPjsKPiArCQllbmFibGUtYWN0aXZlLWhpZ2g7 CgpbU2V2ZXJpdHk6IExvd10KU2ltaWxhciB0byB2ZGRhb18zdjMgYWJvdmUsIGRvZXMgdGhpcyBy ZWd1bGF0b3IgbmVlZCBlbmFibGUtYWN0aXZlLWhpZ2gKd2l0aG91dCBhIGdwaW8gcHJvcGVydHk/ Cgo+ICsJCXJlZ3VsYXRvci1ib290LW9uOwo+ICsJCXJlZ3VsYXRvci1hbHdheXMtb247Cj4gKwl9 Owo+ICB9OwoKWyAuLi4gXQoKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9hbWxv Z2ljL2FtbG9naWMtdDcuZHRzaSBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvYW1sb2dpYy9hbWxvZ2lj LXQ3LmR0c2kKPiBpbmRleCA4ZjNmMWMwNTc5YTBmLi5hNGNhM2JlMzU4NDI5IDEwMDY0NAo+IC0t LSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvYW1sb2dpYy9hbWxvZ2ljLXQ3LmR0c2kKPiArKysgYi9h cmNoL2FybTY0L2Jvb3QvZHRzL2FtbG9naWMvYW1sb2dpYy10Ny5kdHNpCgpbIC4uLiBdCgo+ICsJ CQl1YXJ0X2I6IHNlcmlhbEA3YTAwMCB7Cj4gKwkJCQljb21wYXRpYmxlID0gImFtbG9naWMsdDct dWFydCIsICJhbWxvZ2ljLG1lc29uLXM0LXVhcnQiOwo+ICsJCQkJcmVnID0gPDB4MCAweDdhMDAw IDB4MCAweDE4PjsKPiArCQkJCWludGVycnVwdHMgPSA8R0lDX1NQSSAxNjkgSVJRX1RZUEVfRURH RV9SSVNJTkc+Owo+ICsJCQkJc3RhdHVzID0gImRpc2FibGVkIjsKPiArCQkJfTsKCltTZXZlcml0 eTogTG93XQpJcyB0aGlzIG5vZGUgbWlzc2luZyBpdHMgY2xvY2tzIGFuZCBjbG9jay1uYW1lcyBw cm9wZXJ0aWVzPyBPbWl0dGluZyB0aGVtIGhlcmUKbWlnaHQgZm9yY2UgYm9hcmQgZmlsZXMgdG8g ZHVwbGljYXRlIHRoZSBjbG9jayBjb25maWd1cmF0aW9ucy4KClsgLi4uIF0KCj4gKwkJCQlpbnRf bWRpbzogbWRpb0AxIHsKPiArCQkJCQlyZWcgPSA8MT47Cj4gKwkJCQkJI2FkZHJlc3MtY2VsbHMg PSA8MT47Cj4gKwkJCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4gKwo+ICsJCQkJCWludGVybmFsX2Vw aHk6IGV0aGVybmV0X3BoeUA4IHsKCltTZXZlcml0eTogTG93XQpDb3VsZCB0aGlzIG5vZGUgYmUg bmFtZWQgZXRoZXJuZXQtcGh5QDggaW5zdGVhZD8gVXNpbmcgYW4gdW5kZXJzY29yZSB2aW9sYXRl cwp0aGUgbWRpby55YW1sIHNjaGVtYSwgd2hpY2ggZXhwZWN0cyBuYW1lcyBtYXRjaGluZyBeZXRo ZXJuZXQtcGh5KEBbYS1mMC05XSspPyQuCgo+ICsJCQkJCQljb21wYXRpYmxlID0gImV0aGVybmV0 LXBoeS1pZDAxODAuMzMwMSIsCj4gKwkJCQkJCQkgICAgICJldGhlcm5ldC1waHktaWVlZTgwMi4z LWMyMiI7Cj4gKwkJCQkJCWludGVycnVwdHMgPSA8R0lDX1NQSSAzNDAgSVJRX1RZUEVfTEVWRUxf SElHSD47Cj4gKwkJCQkJCXJlZyA9IDw4PjsKPiArCQkJCQkJbWF4LXNwZWVkID0gPDEwMD47Cj4g KwkJCQkJfTsKPiArCQkJCX07Cj4gKwkJCX07CgpbIC4uLiBdCgo+ICsJCQlpMmMyOiBpMmNANmEw MDAgewo+ICsJCQkJY29tcGF0aWJsZSA9ICJhbWxvZ2ljLHQ3LWkyYyIsICJhbWxvZ2ljLG1lc29u LWF4Zy1pMmMiOwo+ICsJCQkJcmVnID0gPDB4MCAweDZhMDAwIDB4MCAweDQ4PjsKPiArCQkJCWlu dGVycnVwdHMgPSA8R0lDX1NQSSAxNjIgSVJRX1RZUEVfRURHRV9SSVNJTkc+Owo+ICsJCQkJI2Fk ZHJlc3MtY2VsbHMgPSA8MT47Cj4gKwkJCQkjc2l6ZS1jZWxscyA9IDwwPjsKPiArCQkJCWNsb2Nr cyA9IDwmY2xrY19wZXJpcGhzIENMS0lEX1NZU19JMkNfTV9DPjsKPiArCQkJCXN0YXR1cyA9ICJv a2F5IjsKCltTZXZlcml0eTogTWVkaXVtXQpTaG91bGQgdGhpcyBub2RlIGJlIHNldCB0byBzdGF0 dXMgPSAiZGlzYWJsZWQiIGJ5IGRlZmF1bHQ/IEVuYWJsaW5nIGl0CnVuY29uZGl0aW9uYWxseSBp biB0aGUgU29DIGR0c2kgbWlnaHQgbGVhZCB0byBwcm9iZSBmYWlsdXJlcyBvciBoYXJkd2FyZQpj b25mbGljdHMgb24gYm9hcmRzIHRoYXQgZG8gbm90IHVzZSB0aGlzIGNvbnRyb2xsZXIuCgo+ICsJ CQl9OwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRj aHNldC8yMDI2MDkyMC10Ny1ub2RlLW5ldy12MS0wLWU2ZTA4NDBjMWIwYkBhbWxvZ2ljLmNvbT9w YXJ0PTMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LWFtbG9naWMgbWFpbGluZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9n aWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1559443498F for ; Mon, 21 Sep 2026 08:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789978437; cv=none; b=Lc6be15X//JR+DcjH/nbcbQN5fITxR5H1NjIjTkCDFPnBzEp2rQTSaL9MuzZQ/2MW6tcTjzzIRBCN4mZ4v6wYO3KriPHURGeZ6lIKLWCNhf7Yu8zPPgfLdEQCmyqkuHcjrvZDGTVGJhCDXvkerjhDoWL27+dCt3geUAG7qlbtWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789978437; c=relaxed/simple; bh=hq1hrRc8fNxJg7Se70rDgteQ01doEvi0ZNVeg8yWWUU=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=aKZbDOIFkJvioiuFIrcI9mBx1lauSzn+wRerrbgbJC88IWIob9U13EJOORDZyCIxLT+bw4tl5ZXv2NNOvOoAz88nWu08GS33bWqi9oNDB8ZRodNhpqGetOdVNlvG18jxRgw6wVWVhIQsV1NFSuCY0ZkSn0Irq0k0S96arRjWRPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dIHtaix/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dIHtaix/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B4951F00893; Mon, 21 Sep 2026 08:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789978435; bh=kmLTRNY1kc2se1JCA9fEugMVStcIxV4+UhGwHWOQnwo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=dIHtaix/nXCu2qX9GynTmq3EQFPMc4tQtf2tl+VArguVtyLE+vbrx/JdNNb7xIY25 tQ9eQI1Em3gSTQ77xsmzIOhA0u4iApHYk/+8TwcjM23ZGfQtynLHXOlOassCHnArpB IN14WIvm4m10MfgbUwZ/QERrfQD0KWLmlhQIfvN4/DA1BK8j4TlCp10ss88ehXLCKh phRW6kqQXMzpx8J0XV4U0XDEwSqm9pIM4ZGSxamw4S/2kpm7G96tRFTyDNjf4DhscI zihoiYtucIssNEMNPNcaUaGi2LhaVhSgbrwC2yJ9uIoX71bFr2d+UVufH7JIeQtU9r X+Nm0MQAmI7Vw== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/3] arm64: dts: amlogic: add T7 peripheral nodes Reply-To: sashiko-reviews@lists.linux.dev To: "Xianwei Zhao" Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, neil.armstrong@linaro.org, linux-amlogic@lists.infradead.org In-Reply-To: <20260920-t7-node-new-v1-3-e6e0840c1b0b@amlogic.com> References: <20260920-t7-node-new-v1-0-e6e0840c1b0b@amlogic.com> <20260920-t7-node-new-v1-3-e6e0840c1b0b@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 21 Sep 2026 08:13:54 +0000 Message-Id: <20260921081355.1B4951F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 4 potential issue(= s) to consider: - [Medium] dt: i2c2 node is unconditionally enabled in SoC dtsi - [Low] dt: ethernet-phy node name violates schema (uses underscore) - [Low] dt: fixed regulators define enable-active-high without gpio - [Low] dt: new UART nodes omit mandatory clocks properties -- commit 6fa9620003d2e99adee0e1cd106450b9d0aabb2d Author: Xianwei Zhao arm64: dts: amlogic: add T7 peripheral nodes Add device tree descriptions for the peripherals on the Amlogic T7 SoC and the T7 A311D2 AN400 board. Add support for the T7 Ethernet controller, SPI controllers, I2C controllers, UARTs, pinctrl groups, regulators, and reserved memory. Also enable the Ethernet controller on the AN400 board. > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts b/ar= ch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts > index ca7536f772ff1..dfd82148179b0 100644 > --- a/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts > +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts [ ... ] > + vddao_3v3: regulator-vddao-3v3 { > + vin-supply =3D <&dc_in>; > + compatible =3D "regulator-fixed"; > + regulator-name =3D "VDDAO_3V3"; > + regulator-min-microvolt =3D <3300000>; > + regulator-max-microvolt =3D <3300000>; > + startup-delay-us =3D <70000>; > + enable-active-high; [Severity: Low] Does this regulator actually need the enable-active-high property? Without specifying a gpio, this property will not have a functional effect. > + regulator-boot-on; > + regulator-always-on; > + }; [ ... ] > + vdd_ddr: regulator-vdd-ddr { > + vin-supply =3D <&dc_in>; > + compatible =3D "regulator-fixed"; > + regulator-name =3D "VDD_DDR"; > + regulator-min-microvolt =3D <800000>; > + regulator-max-microvolt =3D <800000>; > + startup-delay-us =3D <70000>; > + enable-active-high; [Severity: Low] Similar to vddao_3v3 above, does this regulator need enable-active-high without a gpio property? > + regulator-boot-on; > + regulator-always-on; > + }; > }; [ ... ] > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boo= t/dts/amlogic/amlogic-t7.dtsi > index 8f3f1c0579a0f..a4ca3be358429 100644 > --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi > +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi [ ... ] > + uart_b: serial@7a000 { > + compatible =3D "amlogic,t7-uart", "amlogic,meson-s4-uart"; > + reg =3D <0x0 0x7a000 0x0 0x18>; > + interrupts =3D ; > + status =3D "disabled"; > + }; [Severity: Low] Is this node missing its clocks and clock-names properties? Omitting them h= ere might force board files to duplicate the clock configurations. [ ... ] > + int_mdio: mdio@1 { > + reg =3D <1>; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + internal_ephy: ethernet_phy@8 { [Severity: Low] Could this node be named ethernet-phy@8 instead? Using an underscore violat= es the mdio.yaml schema, which expects names matching ^ethernet-phy(@[a-f0-9]+= )?$. > + compatible =3D "ethernet-phy-id0180.3301", > + "ethernet-phy-ieee802.3-c22"; > + interrupts =3D ; > + reg =3D <8>; > + max-speed =3D <100>; > + }; > + }; > + }; [ ... ] > + i2c2: i2c@6a000 { > + compatible =3D "amlogic,t7-i2c", "amlogic,meson-axg-i2c"; > + reg =3D <0x0 0x6a000 0x0 0x48>; > + interrupts =3D ; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + clocks =3D <&clkc_periphs CLKID_SYS_I2C_M_C>; > + status =3D "okay"; [Severity: Medium] Should this node be set to status =3D "disabled" by default? Enabling it unconditionally in the SoC dtsi might lead to probe failures or hardware conflicts on boards that do not use this controller. > + }; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260920-t7-node-ne= w-v1-0-e6e0840c1b0b@amlogic.com?part=3D3