From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Md Rayhanul Islam <r97yhan@gmail.com>, <dev@dpdk.org>,
Chuanyu Xue <chuanyu.xue@uconn.edu>,
Song Han <song.han@uconn.edu>,
Md Rayhanul Islam <md_rayhanul.islam@uconn.edu>
Subject: Re: [PATCH 0/2] make PCIe DMA work on Broadcom BCM2711
Date: Mon, 21 Sep 2026 08:42:11 -0700 [thread overview]
Message-ID: <20260921084211.4f78c451@phoenix.local> (raw)
In-Reply-To: <arDxMec8YX7KDdAX@bricha3-mobl1.ger.corp.intel.com>
On Mon, 21 Sep 2026 09:56:17 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:
> >
> > Short observations:
> > 1. Too much AI generated slop, extra docs, comments on everything.
> > New code should look like the surrounding code.
> > This looks like AI wasn't quite sure and left lots of docs for future self.
>
> I really don't view this as a bad thing. A little too much detail in the
> comments is better for the future than too little. Given these patches
> touch areas outside the usual behaviour we expect from DPDK platforms,
> having extra comments is definitely useful.
>
>
> /Bruce
There is a fine line between a couple of sentences and three paragraphs
next prev parent reply other threads:[~2026-09-21 15:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 22:50 [PATCH 0/2] make PCIe DMA work on Broadcom BCM2711 Md Rayhanul Islam
2026-09-18 22:50 ` [PATCH 1/2] eal/linux: apply PCIe inbound DMA translation Md Rayhanul Islam
2026-09-18 22:50 ` [PATCH 2/2] net/e1000: maintain caches on non-coherent DMA Md Rayhanul Islam
2026-09-19 21:05 ` [PATCH 0/2] make PCIe DMA work on Broadcom BCM2711 Stephen Hemminger
2026-09-21 8:56 ` Bruce Richardson
2026-09-21 15:42 ` Stephen Hemminger [this message]
2026-09-24 19:22 ` Md Rayhanul Islam
2026-10-02 20:09 ` [RFC PATCH 0/2] per-device DMA properties, with igb as the first user Md Rayhanul Islam
2026-10-02 20:09 ` [RFC PATCH 1/2] eal/pci: add per-device DMA translation and synchronization Md Rayhanul Islam
2026-10-02 20:09 ` [RFC PATCH 2/2] net/e1000: support non-coherent DMA Md Rayhanul Islam
2026-10-03 16:51 ` [RFC PATCH 0/2] per-device DMA properties, with igb as the first user Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921084211.4f78c451@phoenix.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=chuanyu.xue@uconn.edu \
--cc=dev@dpdk.org \
--cc=md_rayhanul.islam@uconn.edu \
--cc=r97yhan@gmail.com \
--cc=song.han@uconn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.