From: Stephen Hemminger <stephen@networkplumber.org>
To: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>
Cc: dev@dpdk.org, kishore.padmanabha@broadcom.com,
Dakota Sicher <dakota.sicher@broadcom.com>
Subject: Re: [PATCH v2] net/bnxt: remove duplicate branches and conditions
Date: Mon, 21 Sep 2026 08:46:40 -0700 [thread overview]
Message-ID: <20260921084640.44fb7603@phoenix.local> (raw)
In-Reply-To: <20260921021711.1033759-1-Mohammad-Shuab.Siddique@broadcom.com>
On Sun, 20 Sep 2026 20:17:11 -0600
Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com> wrote:
> From: Dakota Sicher <dakota.sicher@broadcom.com>
>
> Removed ternary operators with identical results and consolidated
> identical branches in bnxt_validate_and_parse_flow_type() and
> bnxt_start_xmit(). The NTUPLE and EM_FLOW variants of several HWRM
> enable-bit and IP address type macros resolve to identical values,
> making the use_ntuple-conditioned ternaries redundant; several
> adjacent if/else-if branches in the Tx checksum-flag dispatch were
> also textually identical (same action for a checksum-combination
> flag and each of its constituent single-flag variants) and have
> been merged.
>
> Signed-off-by: Dakota Sicher <dakota.sicher@broadcom.com>
> Signed-off-by: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>
> ---
Better AI review flagged minor nit:
[PATCH v2] net/bnxt: remove duplicate branches and conditions
Info: the re-indent of the PKT_TX_OIP_IIP_CKSUM,
RTE_MBUF_F_TX_IP_CKSUM, OUTER_IP_CKSUM and IEEE1588 continuation
lines misaligns them. Drop the whitespace churn.
next prev parent reply other threads:[~2026-09-21 15:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 3:26 [PATCH] net/bnxt: remove duplicate branches and conditions Mohammad Shuab Siddique
2026-09-21 2:14 ` [PATCH v2] " Mohammad Shuab Siddique
2026-09-21 2:17 ` Mohammad Shuab Siddique
2026-09-21 15:46 ` Stephen Hemminger [this message]
2026-09-29 0:24 ` [PATCH v3] " Mohammad Shuab Siddique
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921084640.44fb7603@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dakota.sicher@broadcom.com \
--cc=dev@dpdk.org \
--cc=kishore.padmanabha@broadcom.com \
--cc=mohammad-shuab.siddique@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.