All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: rafael@kernel.org, eric.devolder@oracle.com, chao.gao@intel.com,
	ritesh.list@gmail.com, mark.rutland@arm.com,
	linux-kernel@vger.kernel.org, leitao@debian.org,
	sshegde@linux.ibm.com, kees@kernel.org, robh@kernel.org,
	loongarch@lists.linux.dev, chleroy@kernel.org,
	liukexin@kylinos.cn, x86@kernel.org, hbathini@linux.ibm.com,
	"Jinjie Ruan" <ruanjinjie@huawei.com>,
	maddy@linux.ibm.com, guodongtai@kylinos.cn,
	mclapinski@google.com, gregkh@linuxfoundation.org,
	me@linux.beauty, pratyush@kernel.org, palmer@rivosinc.com,
	hpa@zytor.com, bp@alien8.de, vishal.l.verma@intel.com,
	bgwin@google.com, takahiro.akashi@linaro.org,
	chenhuacai@kernel.org, seanjc@google.com,
	dave.hansen@linux.intel.com, tglx@kernel.org,
	yeoreum.yun@arm.com, akpm@linux-foundation.org,
	sourabhjain@linux.ibm.com, driver-core@lists.linux.dev,
	mpe@ellerman.id.au, will@kernel.org, tangyouling@kylinos.cn,
	dakr@kernel.org, baoquan.he@linux.dev, graf@amazon.com,
	kai.huang@intel.com, pasha.tatashin@soleen.com,
	jbouron@amazon.com, mingo@redhat.com, ruirui.yang@linux.dev,
	rppt@kernel.org, kernel@xen0n.name, thuth@redhat.com,
	coxu@redhat.com, catalin.marinas@arm.com, npiggin@gmail.com,
	linux-arm-kernel@lists.infradead.org, maqianga@uniontech.com,
	piliu@redhat.com, linuxppc-dev@lists.ozlabs.org,
	james.morse@arm.com, zhangtianyang@loongson.cn
Cc: kexec@lists.infradead.org, ruanjinjie@huawei.com
Subject: Re: [PATCH v6 02/14] kexec: Record allocated CMA pages to fix release size mismatch
Date: Mon, 21 Sep 2026 09:14:45 +0000	[thread overview]
Message-ID: <20260921091446.3F2761F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260921090450.807575-3-ruanjinjie@huawei.com>

> The CMA pages allocated for a kexec segment are released using the
> segment's memsz to calculate the number of pages. However, some
> architecture loaders modify the segment's memsz after allocation
> (e.g. arm64 subtracts text_offset), causing the release function to
> free fewer pages than were originally allocated, leaking the remaining
> CMA pages.
> 
> Add a per-segment `segment_cma_pages` array to store the number of
> pages actually allocated from CMA. Populate it during
> kexec_add_buffer() using the aligned memsz, and use it in
> kimage_free_cma() to accurately release all allocated pages.
> 
> This avoids relying on the potentially modified segment->memsz and
> prevents silent CMA memory leaks.
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Baoquan He <baoquan.he@linux.dev>
> Cc: Mike Rapoport <rppt@kernel.org>
> Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
> Cc: Pratyush Yadav <pratyush@kernel.org>
> Cc: Brian Mak <makb@juniper.net>
> Cc: Pingfan Liu <piliu@redhat.com>
> Cc: Sourabh Jain <sourabhjain@linux.ibm.com>
> Cc: Justinien Bouron <jbouron@amazon.com>
> Cc: Li Chen <me@linux.beauty>
> Cc: Breno Leitao <leitao@debian.org>
> Cc: stable@vger.kernel.org
> Link: https://sashiko.dev/#/patchset/20260729031235.2840255-1-ruanjinjie%40huawei.com
> Fixes: 07d24902977e ("kexec: enable CMA based contiguous allocation")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921090450.807575-1-ruanjinjie@huawei.com?part=2


  reply	other threads:[~2026-09-21  9:14 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  9:04 [PATCH v6 00/14] crash: Fix several bugs Jinjie Ruan
2026-09-21  9:04 ` [PATCH v6 01/14] kexec: Fix CMA segment address translation with non-zero text_offset Jinjie Ruan
2026-09-21  9:17   ` sashiko-bot
2026-09-21  9:04 ` [PATCH v6 02/14] kexec: Record allocated CMA pages to fix release size mismatch Jinjie Ruan
2026-09-21  9:14   ` sashiko-bot [this message]
2026-09-21  9:04 ` [PATCH v6 03/14] kexec: Extract kexec_free_segment_cma() from kimage_free_cma() Jinjie Ruan
2026-09-21  9:13   ` sashiko-bot
2026-09-21  9:13     ` sashiko-bot
2026-09-21  9:04 ` [PATCH v6 04/14] arm64: kexec_file: Fix CMA page leaks in segment placement retry loops Jinjie Ruan
2026-09-21  9:18   ` sashiko-bot
2026-09-21  9:04 ` [PATCH v6 05/14] arm64: kexec_file: Fix elf_headers memory leak in retry loop Jinjie Ruan
2026-09-21  9:15   ` sashiko-bot
2026-10-10 20:00   ` Catalin Marinas
2026-09-21  9:04 ` [PATCH v6 06/14] LoongArch: kexec_file: Fix CMA page leaks in segment placement retry loops Jinjie Ruan
2026-09-21  9:13   ` sashiko-bot
2026-09-21  9:13     ` sashiko-bot
2026-09-21  9:04 ` [PATCH v6 07/14] LoongArch: kexec_file: Fix elf_headers memory leak in retry loop Jinjie Ruan
2026-09-21  9:14   ` sashiko-bot
2026-09-21  9:04 ` [PATCH v6 08/14] LoongArch: kexec_file: Fix a modified_cmdline leak Jinjie Ruan
2026-09-21  9:15   ` sashiko-bot
2026-09-21  9:04 ` [PATCH v6 09/14] x86/crash: Fix massive out-of-bounds write on 32-bit Highmem Jinjie Ruan
2026-09-21  9:12   ` sashiko-bot
2026-09-21  9:12     ` sashiko-bot
2026-09-21  9:04 ` [PATCH v6 10/14] crash: Extract crash_get_memory_ranges() helper Jinjie Ruan
2026-09-21  9:19   ` sashiko-bot
2026-09-21  9:04 ` [PATCH v6 11/14] crash: Factor out crash_find_elfcorehdr() helper Jinjie Ruan
2026-09-21  9:17   ` sashiko-bot
2026-09-21  9:04 ` [PATCH v6 12/14] crash: Normalize the kexec_load elfcorehdr at load time Jinjie Ruan
2026-09-21  9:19   ` sashiko-bot
2026-09-21  9:04 ` [PATCH v6 13/14] driver core: Add device_hotplug_lock_assert_held() helper Jinjie Ruan
2026-09-21  9:18   ` sashiko-bot
2026-09-21  9:04 ` [PATCH v6 14/14] crash: Fix TOCTOU race in crash memory range collection Jinjie Ruan
2026-09-21  9:25   ` sashiko-bot
2026-09-21  9:25     ` sashiko-bot
2026-10-08  1:57 ` [PATCH v6 00/14] crash: Fix several bugs Jinjie Ruan
2026-10-08  3:26   ` Baoquan He
2026-10-08  6:42   ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921091446.3F2761F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=baoquan.he@linux.dev \
    --cc=bgwin@google.com \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=chao.gao@intel.com \
    --cc=chenhuacai@kernel.org \
    --cc=chleroy@kernel.org \
    --cc=coxu@redhat.com \
    --cc=dakr@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=driver-core@lists.linux.dev \
    --cc=eric.devolder@oracle.com \
    --cc=graf@amazon.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guodongtai@kylinos.cn \
    --cc=hbathini@linux.ibm.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jbouron@amazon.com \
    --cc=kai.huang@intel.com \
    --cc=kees@kernel.org \
    --cc=kernel@xen0n.name \
    --cc=kexec@lists.infradead.org \
    --cc=leitao@debian.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=liukexin@kylinos.cn \
    --cc=loongarch@lists.linux.dev \
    --cc=maddy@linux.ibm.com \
    --cc=maqianga@uniontech.com \
    --cc=mark.rutland@arm.com \
    --cc=mclapinski@google.com \
    --cc=me@linux.beauty \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=palmer@rivosinc.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=piliu@redhat.com \
    --cc=pratyush@kernel.org \
    --cc=rafael@kernel.org \
    --cc=ritesh.list@gmail.com \
    --cc=robh@kernel.org \
    --cc=rppt@kernel.org \
    --cc=ruanjinjie@huawei.com \
    --cc=ruirui.yang@linux.dev \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=seanjc@google.com \
    --cc=sourabhjain@linux.ibm.com \
    --cc=sshegde@linux.ibm.com \
    --cc=takahiro.akashi@linaro.org \
    --cc=tangyouling@kylinos.cn \
    --cc=tglx@kernel.org \
    --cc=thuth@redhat.com \
    --cc=vishal.l.verma@intel.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=yeoreum.yun@arm.com \
    --cc=zhangtianyang@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.