From: Stephen Hemminger <stephen@networkplumber.org>
To: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>
Cc: dev@dpdk.org, kishore.padmanabha@broadcom.com,
Keegan Freyhof <keegan.freyhof@broadcom.com>
Subject: Re: [PATCH] net/bnxt: remove VMDq support
Date: Mon, 21 Sep 2026 09:19:32 -0700 [thread overview]
Message-ID: <20260921091932.39fa0013@phoenix.local> (raw)
In-Reply-To: <20260921030811.1034869-1-Mohammad-Shuab.Siddique@broadcom.com>
On Sun, 20 Sep 2026 21:08:11 -0600
Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com> wrote:
> From: Keegan Freyhof <keegan.freyhof@broadcom.com>
>
> Remove support for the VMDq feature from the driver: the multi-pool
> Rx-queue configuration path in bnxt_mq_rx_configure(), the VMDQ VLAN
> pool wiring in the L2 filter alloc path, and the max_vmdq_pools/
> vmdq_queue_num reporting in dev_info (now always reported as 0).
>
> Preserved two pieces of logic that live in the same
> function/switch statement but are not VMDq-pool-specific: the
> RTE_ETH_MQ_RX_RSS pools=rx_cosq_cnt case and the
> per-non-default-VNIC skip_filter_allocation guard in
> bnxt_mq_rx_configure(), both used by the plain multi-COS RSS path.
> Also kept the RTE_ETH_VMDQ_ACCEPT_HASH_UC/BROADCAST/MULTICAST ->
> l2_rx_mask flag mapping in rte_pmd_bnxt_set_vf_rxmode(): despite the
> name, those bits are the standard DPDK VF-rxmode API used regardless
> of hardware VMDq pool support, not a VMDq-pool-specific control.
>
> Signed-off-by: Keegan Freyhof <keegan.freyhof@broadcom.com>
> Signed-off-by: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>
> ---
[PATCH] net/bnxt: remove VMDq support
Warning: mq_mode validation is lost. Before, VMDq, DCB and DCB_RSS
modes hit the default case and returned -EINVAL. Now any mode other
than NONE or RSS silently configures a single pool and succeeds.
Reject every other mq_mode explicitly in bnxt_mq_rx_configure() or
dev_configure.
next prev parent reply other threads:[~2026-09-21 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 3:08 [PATCH] net/bnxt: remove VMDq support Mohammad Shuab Siddique
2026-09-21 16:19 ` Stephen Hemminger [this message]
2026-09-22 7:50 ` David Marchand
2026-09-23 22:43 ` Mohammad Shuab Siddique
2026-09-29 0:21 ` [PATCH v2] " Mohammad Shuab Siddique
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921091932.39fa0013@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=keegan.freyhof@broadcom.com \
--cc=kishore.padmanabha@broadcom.com \
--cc=mohammad-shuab.siddique@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.