From: sashiko-bot@kernel.org
To: "Guangshuo Li" <lgs201920130244@gmail.com>
Cc: lee@kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2] leds: flash: sgm3140: fix child node reference leak
Date: Mon, 21 Sep 2026 09:29:22 +0000 [thread overview]
Message-ID: <20260921092922.AB3DD1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260921092128.346375-1-lgs201920130244@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] leds: uncapitalized commit message description
--
commit 2a50d0447cec030d24466a0bda14c4fe595d02f6
Author: Guangshuo Li <lgs201920130244@gmail.com>
leds: flash: sgm3140: fix child node reference leak
This commit fixes a child node reference leak in sgm3140_probe() by
registering a devm action. This ensures the fwnode reference remains valid
until after the LED class device is unregistered.
> leds: flash: sgm3140: fix child node reference leak
[Severity: Low]
This isn't a bug, but the description after the subsystem prefix starts with
a lowercase letter. Should this be capitalized as "Fix child node reference
leak"?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260921092128.346375-1-lgs201920130244@gmail.com?part=1
next prev parent reply other threads:[~2026-09-21 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 9:21 [PATCH v2] leds: flash: sgm3140: fix child node reference leak Guangshuo Li
2026-09-21 9:29 ` sashiko-bot [this message]
2026-09-21 11:02 ` Sakari Ailus
2026-09-21 11:54 ` Laurent Pinchart
2026-09-22 6:57 ` Guangshuo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921092922.AB3DD1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=lgs201920130244@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.