Re: [PATCH net-next v2 5/6] netlink: specs: rt-route: describe lwt BPF program options

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] netlink: seg6-local BPF attribute uses wrong UAPI header enums via lwt-bpf-prog
--

commit cddba7a35aae1dfa7f35285fd4781c86739950cc
Author: Hangbin Liu <liuhangbin@kylinos.cn>

netlink: specs: rt-route: describe lwt BPF program options

Replace binary BPF attributes with a nested lwt-bpf-prog to support
lwt bpf prog options.

> diff --git a/Documentation/netlink/specs/rt-route.yaml b/Documentation/netlink/specs/rt-route.yaml
> index 4b12a8a586521..4a3953c9e9780 100644
> --- a/Documentation/netlink/specs/rt-route.yaml
> +++ b/Documentation/netlink/specs/rt-route.yaml

[ ... ]

> @@ -508,7 +511,8 @@ attribute-sets:
>          type: u32
>        -
>          name: bpf
> -        type: binary
> +        type: nest
> +        nested-attributes: lwt-bpf-prog
>        -
>          name: vrftable
>          type: u32

[Severity: Low]
Does this incorrectly reuse lwt-bpf-prog for the seg6-local attribute-set's
bpf attribute?

By using the lwt-bpf-prog nested-attributes here, the generated YNL userspace
API will use linux/lwtunnel.h constants (LWT_BPF_PROG_FD, LWT_BPF_PROG_NAME)
instead of the correct linux/seg6_local.h constants (SEG6_LOCAL_BPF_PROG,
SEG6_LOCAL_BPF_PROG_NAME).

This leaks abstraction and forces users to include lwtunnel.h for seg6-local
operations. While there may be no runtime impact since the enum values happen
to align, should this instead use a dedicated seg6-local nested attribute set
to ensure proper UAPI encapsulation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260920-ynl_rt_encap-v2-0-c664a3e726f6@kylinos.cn?part=5