All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Konstantin Taranov" <kotaranov@linux.microsoft.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next v3 5/5] RDMA/mana_ib: Poll UD completions and flush software error QPs
Date: Mon, 21 Sep 2026 10:13:42 +0000	[thread overview]
Message-ID: <20260921101343.6BE731F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921095352.3524691-6-kotaranov@linux.microsoft.com>

> From: Konstantin Taranov <kotaranov@microsoft.com>
> 
> Build UD and GSI work completions directly from each hardware CQE and
> the corresponding published shadow entry. Decode receive length, source
> QP and immediate data directly, removing byte_len, src_qpn and cached
> status from the common shadow header. Introduce a WC-budgeted poll context
> with a cached CQE for RC polling.
> 
> Match UD send and receive CQEs against the low 24 bits of the posted WQE
> offset before consuming the shadow entry.
> 
> Honor the QP's IB_SIGNAL_ALL_WR policy together with IB_SEND_SIGNALED when
> posting sends, and mark unsignaled entries with MANA_WQ_NO_SIGNAL_WC.
> Since successful unsignaled sends do not generate CQEs, locate the matching
> entry through the unsignaled prefix before retiring any WRs.
> [ ... ]
> Automatic error-list insertion and CQ notification on a successful ERR
> transition are introduced separately with RC support. Hardware error-CQE
> decoding and deferred QP error handling also remain in the RC series.
> 
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921095352.3524691-1-kotaranov@linux.microsoft.com?part=5


      reply	other threads:[~2026-09-21 10:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  9:53 [PATCH rdma-next v3 0/5] RDMA/mana_ib: Streamline kernel UD/GSI posting and completion handling Konstantin Taranov
2026-09-21  9:53 ` [PATCH rdma-next v3 1/5] RDMA/mana_ib: Optimize shadow queue bookkeeping Konstantin Taranov
2026-09-21 10:03   ` sashiko-bot
2026-09-21  9:53 ` [PATCH rdma-next v3 2/5] RDMA/mana_ib: Revise UD send posting and WQE definitions Konstantin Taranov
2026-09-21 10:03   ` sashiko-bot
2026-09-21  9:53 ` [PATCH rdma-next v3 3/5] RDMA/mana_ib: Revise UD receive posting with GDMA_WR_IB_SGL Konstantin Taranov
2026-09-21 10:01   ` sashiko-bot
2026-09-21  9:53 ` [PATCH rdma-next v3 4/5] RDMA/mana_ib: Make kernel CQ arming robust Konstantin Taranov
2026-09-21 10:08   ` sashiko-bot
2026-09-21  9:53 ` [PATCH rdma-next v3 5/5] RDMA/mana_ib: Poll UD completions and flush software error QPs Konstantin Taranov
2026-09-21 10:13   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921101343.6BE731F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=kotaranov@linux.microsoft.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.