From: Simon Horman <horms@kernel.org>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
madalin.bucur@nxp.com, netdev@vger.kernel.org, nsaenz@kernel.org,
pabeni@redhat.com, sean.anderson@linux.dev,
stable@vger.kernel.org
Subject: Re: [PATCH] fsl/fman: Fix fm_node reference leak in read_dts_node()
Date: Mon, 21 Sep 2026 11:17:57 +0100 [thread overview]
Message-ID: <20260921101757.GE13925@horms.kernel.org> (raw)
In-Reply-To: <20260917110342.2148155-1-vulab@iscas.ac.cn>
On Thu, Sep 17, 2026 at 11:03:42AM +0000, Wentao Liang wrote:
> of_node_get() takes a reference on the FMan device node. That reference
> is released neither on the success path, which returns straight after
> of_platform_populate(), nor on the failure paths that jump to fman_free
> without going through fman_node_put(). Neither read_dts_node() nor its
> caller keeps fm_node around to release it later.
>
> Release the reference on the success path, and route the remaining
> failure paths through fman_node_put().
>
> Fixes: ecb239d96d36 ("ethernet: fman: fix wrong of_node_put() in probe function")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Hi Wentao,
As flagged by W=1 builds, with this patch applied the fman_free tag is no
longer used. It should be removed.
Please be sure to check that your patches do not introduce any
new warnings when compiled with W=1.
Link: https://docs.kernel.org/process/maintainer-netdev.html#testing
--
pw-bot: changes-requested
prev parent reply other threads:[~2026-09-21 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 11:03 [PATCH] fsl/fman: Fix fm_node reference leak in read_dts_node() Wentao Liang
2026-09-21 10:17 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921101757.GE13925@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=nsaenz@kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.anderson@linux.dev \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.