From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8885EC982ED for ; Mon, 21 Sep 2026 11:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nzp16a1houxP73dlw6dh/1sKAs/g4DZu0OWYEpj9pEE=; b=H9jq5pyA94uowx ZK+ydDMPVN7eIlEZSLir474muzADNPUxrTaQF/VMANRlnSH1lWWkQH/bNUQ0haZAkPb6WsNeEMbUF YB3Xf2W5UTulUIel7SOpcN1ciGDXgu5slwMesuBHRs8Q1MZIG5r8cFm6lYhvGEL1l088OgXi6cPz4 fNECs0QoTszZWHb6rMMY/wvVDL1NJYYqKm3lyPAnQlbJWXhbLiNxh546x4Ki4lPCKedtpIfVsPBuC 7cClO1tg4+6Qw2oVswEzKPWkyLhmLhAa+PYO0e//iSRddByalU4MgMDgDbjBO6rs1yXy2N2eNh0i+ zbWTIoToVnHbFaRXZsSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8bq2-00000001pHV-4AF2; Mon, 21 Sep 2026 11:05:35 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8bq1-00000001pH7-1Pax for linux-phy@lists.infradead.org; Mon, 21 Sep 2026 11:05:33 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 7214E600C8; Mon, 21 Sep 2026 11:05:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC0611F000FF; Mon, 21 Sep 2026 11:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789988732; bh=Q23X9NFAUgyki7bVg3boIBIdGH2nvLPDKnO958Egv1U=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=CkCRxeFr/Q2nb4xBxr/Utz39L2az7K1/V7SwTaH4NygTtrOlQCkebrykmXtQrRDU9 D/Qqy0xQL8DCoA94jNbYocHWXDju5/ixp9bvZHr6pEH7UsHSvz2dQBsg+Avd1HiKw8 mVvx7BpSJFjuuQPZnbBgO/NhArmiB0uzmNFbr49nH4k8D9p0a2ppNiXGH0QyBgRSHr XxvwrKntEdZ1qXf1KZzECNLFxCqfMskFotgjSxhmH8BJAMV2E7nrLtYrpha3g5sfLz Il796J/Gvn/YHcQ14AeCLp02T4SaFA8je12UgTn/TXblrwcnzIdCyoi7XDr6cdA/So mqR/r1HQxRNYA== From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/6] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Add qcs8300 16 GT/s PHY To: "Krishna Chaitanya Chundru" Cc: neil.armstrong@linaro.org, vkoul@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, linux-pci@vger.kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org In-Reply-To: <20260921-monaco_ep-v1-1-63c5282fb0db@oss.qualcomm.com> References: <20260921-monaco_ep-v1-0-63c5282fb0db@oss.qualcomm.com> <20260921-monaco_ep-v1-1-63c5282fb0db@oss.qualcomm.com> Date: Mon, 21 Sep 2026 11:05:31 +0000 Message-Id: <20260921110531.AC0611F000FF@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org PiBUaGUgUUNTODMwMCAxNiBHVC9zIHg0IFFNUCBQQ0llIFBIWSB3YXMgcHJldmlvdXNseSBkZXNj cmliZWQgdXNpbmcgb25seQo+IHRoZSBxY29tLHNhODc3NXAtcW1wLWdlbjR4NC1wY2llLXBoeSBj b21wYXRpYmxlLCBzaW5jZSBubyBRQ1M4MzAwLXNwZWNpZmljCj4gY29tcGF0aWJsZSBleGlzdGVk IGZvciB0aGlzIFBIWS4gVGhpcyB3YXMgYSBtaXN0YWtlLCBhcyBpdCBsZWZ0IHRoZSBQSFkKPiB1 bmRvY3VtZW50ZWQgYXMgUUNTODMwMCBoYXJkd2FyZSBhbmQgaW5kaXN0aW5ndWlzaGFibGUgZnJv bSBTQTg3NzVQIGluCj4gdGhlIGJpbmRpbmcuCj4gCj4gQ29ycmVjdCB0aGlzIGJ5IGRvY3VtZW50 aW5nIGEgZGVkaWNhdGVkCj4gInFjb20scWNzODMwMC1xbXAtZ2VuNHg0LXBjaWUtcGh5IiBjb21w YXRpYmxlLCB3aXRoCj4gInFjb20sc2E4Nzc1cC1xbXAtZ2VuNHg0LXBjaWUtcGh5IiBsaXN0ZWQg YXMgaXRzIGZhbGxiYWNrIGNvbXBhdGlibGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogS3Jpc2huYSBD aGFpdGFueWEgQ2h1bmRydSA8a3Jpc2huYS5jaHVuZHJ1QG9zcy5xdWFsY29tbS5jb20+CgpTYXNo aWtvIGhhcyByZXZpZXdlZCB0aGlzIHBhdGNoIGFuZCBmb3VuZCBubyBpc3N1ZXMuIEl0IGxvb2tz IGdyZWF0IQoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9w YXRjaHNldC8yMDI2MDkyMS1tb25hY29fZXAtdjEtMC02M2M1MjgyZmIwZGJAb3NzLnF1YWxjb21t LmNvbT9wYXJ0PTEKCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F50E48F01B; Mon, 21 Sep 2026 11:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789988740; cv=none; b=R95oBX99J2hqXaIr/9MQyS+KJae2N5GBnoqx7xtyrHDYo9nlrAvDjyqnoKrk9BJenb8URbTrV//DkRmMHNBllPtwqUjQmPYS3HsUHuedS8ssH4D8HAuvGNjd69rJRlwIHG1o/hMvUW6LIiwz5qSuCOwp0VOso2NEoFOqUVsNVaE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789988740; c=relaxed/simple; bh=Q23X9NFAUgyki7bVg3boIBIdGH2nvLPDKnO958Egv1U=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=NCvOTUbqrF4ijfP1N/HeBIB40o3fT9ingWLBZ2Flhd9km6sxJJqYI8zPdWapgTJMYlMeK3cM45/oBO0j/GscSnqDwX+/rE84PJ9Mh5hhTeHn7r87qlvNiVLfO6oIX6MXbhKfLvLoH/txP5uIPxBYEOHjLcstjxGv10zqK4t+a8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CkCRxeFr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CkCRxeFr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC0611F000FF; Mon, 21 Sep 2026 11:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789988732; bh=Q23X9NFAUgyki7bVg3boIBIdGH2nvLPDKnO958Egv1U=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=CkCRxeFr/Q2nb4xBxr/Utz39L2az7K1/V7SwTaH4NygTtrOlQCkebrykmXtQrRDU9 D/Qqy0xQL8DCoA94jNbYocHWXDju5/ixp9bvZHr6pEH7UsHSvz2dQBsg+Avd1HiKw8 mVvx7BpSJFjuuQPZnbBgO/NhArmiB0uzmNFbr49nH4k8D9p0a2ppNiXGH0QyBgRSHr XxvwrKntEdZ1qXf1KZzECNLFxCqfMskFotgjSxhmH8BJAMV2E7nrLtYrpha3g5sfLz Il796J/Gvn/YHcQ14AeCLp02T4SaFA8je12UgTn/TXblrwcnzIdCyoi7XDr6cdA/So mqR/r1HQxRNYA== From: sashiko-bot@kernel.org Subject: Re: [PATCH 1/6] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Add qcs8300 16 GT/s PHY Reply-To: sashiko-reviews@lists.linux.dev To: "Krishna Chaitanya Chundru" Cc: neil.armstrong@linaro.org, vkoul@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, linux-pci@vger.kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org In-Reply-To: <20260921-monaco_ep-v1-1-63c5282fb0db@oss.qualcomm.com> References: <20260921-monaco_ep-v1-0-63c5282fb0db@oss.qualcomm.com> <20260921-monaco_ep-v1-1-63c5282fb0db@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 21 Sep 2026 11:05:31 +0000 Message-Id: <20260921110531.AC0611F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > The QCS8300 16 GT/s x4 QMP PCIe PHY was previously described using only > the qcom,sa8775p-qmp-gen4x4-pcie-phy compatible, since no QCS8300-specific > compatible existed for this PHY. This was a mistake, as it left the PHY > undocumented as QCS8300 hardware and indistinguishable from SA8775P in > the binding. >=20 > Correct this by documenting a dedicated > "qcom,qcs8300-qmp-gen4x4-pcie-phy" compatible, with > "qcom,sa8775p-qmp-gen4x4-pcie-phy" listed as its fallback compatible. >=20 > Signed-off-by: Krishna Chaitanya Chundru Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260921-monaco_ep-= v1-0-63c5282fb0db@oss.qualcomm.com?part=3D1