From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemb@google.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 1/5] net: synchronize proc_do_rss_key() with netdev_rss_key_fill()
Date: Mon, 21 Sep 2026 12:51:56 -0700 [thread overview]
Message-ID: <20260921125156.6623d5ec@kernel.org> (raw)
In-Reply-To: <20260921183758.1812310-2-edumazet@google.com>
On Mon, 21 Sep 2026 18:37:54 +0000 Eric Dumazet wrote:
> struct ctl_table fake_table;
> char *pos = buf;
> + bool initialized;
reverse xmas tree
Maybe we should call netdev_rss_key_fill() from the proc handler
and let the net_get_random_once() handle the safe init?
IMHO the concern is entirely academic / hallucinated so adding
LoC for it feels strange
next prev parent reply other threads:[~2026-09-21 19:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 18:37 [PATCH net-next 0/5] net: ethtool: make netdev_rss_key_fill() spread flows over all queues Eric Dumazet
2026-09-21 18:37 ` [PATCH net-next 1/5] net: synchronize proc_do_rss_key() with netdev_rss_key_fill() Eric Dumazet
2026-09-21 19:51 ` Jakub Kicinski [this message]
2026-09-21 19:53 ` Jakub Kicinski
2026-09-21 20:03 ` Eric Dumazet
2026-09-21 18:37 ` [PATCH net-next 2/5] net: ethtool: generate RSS keys that spread flows over all queues Eric Dumazet
2026-09-21 19:59 ` Jakub Kicinski
2026-09-21 18:37 ` [PATCH net-next 3/5] net: ethtool: add KUnit tests for the generated RSS key Eric Dumazet
2026-09-21 20:03 ` Jakub Kicinski
2026-09-21 20:10 ` Eric Dumazet
2026-09-21 20:35 ` Eric Dumazet
2026-09-21 18:37 ` [PATCH net-next 4/5] selftests: net: check the quality of the host " Eric Dumazet
2026-09-21 18:37 ` [PATCH net-next 5/5] selftests: drivers: net: check the RSS key a device uses Eric Dumazet
2026-09-21 20:09 ` Jakub Kicinski
2026-09-21 20:47 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921125156.6623d5ec@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.