From: sashiko-bot@kernel.org
To: "SJ Park" <sj@kernel.org>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH 2/4] mm/damon/sysfs: propagate damon_call() error in turn_damon_on
Date: Mon, 21 Sep 2026 15:22:36 +0000 [thread overview]
Message-ID: <20260921152237.5E5C31F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921151547.78472-3-sj@kernel.org>
> From: Xuewen Wang <wangxuewen@kylinos.cn>
>
> damon_sysfs_turn_damon_on() ignored the return value of damon_call()
> for the repeat call control registration and always returned the stale
> result of damon_start() (0 at that point). When damon_call() fails,
> e.g., the kdamond is already exiting, the user still gets success from
> the state file write while monitoring is not actually on.
>
> Save and return the damon_call() result instead. No rollback of
> damon_start() is needed since a failed damon_call() guarantees the
> context is stopped.
>
> Signed-off-by: Xuewen Wang <wangxuewen@kylinos.cn>
> Reviewed-by: SJ Park <sj@kernel.org>
> Signed-off-by: SJ Park <sj@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260921151547.78472-1-sj@kernel.org?part=2
next prev parent reply other threads:[~2026-09-21 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:15 [PATCH 0/4] mm/damon: improvements in efficiency, error handling, documents SJ Park
2026-09-21 15:15 ` [PATCH 1/4] mm/damon/core: skip quota score setup when the quota is full SJ Park
2026-09-21 15:22 ` sashiko-bot
2026-09-21 15:15 ` [PATCH 2/4] mm/damon/sysfs: propagate damon_call() error in turn_damon_on SJ Park
2026-09-21 15:22 ` sashiko-bot [this message]
2026-09-21 15:15 ` [PATCH 3/4] mm/damon: fix typos in comments SJ Park
2026-09-21 15:17 ` sashiko-bot
2026-09-21 15:15 ` [PATCH 4/4] mm/damon: document that a zero sample_interval is accepted SJ Park
2026-09-21 15:22 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921152237.5E5C31F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.