Re: [PATCH RFC 05/25] drm/bridge: Add VTEM EMP support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/bridge: kernel-doc mismatch for hdmi_write_vtem_emp
--

commit 4f42f5d433397d0bf7581a8604062c841adc15e1
Author: Derek Foreman <derek.foreman@collabora.com>

drm/bridge: Add VTEM EMP support

This commit adds setters and a support bit for VTEM EMP to the DRM bridge
infrastructure.

> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> index 77b3ffe692304..9dbd1bfa39afc 100644
> --- a/include/drm/drm_bridge.h
> +++ b/include/drm/drm_bridge.h

[ ... ]

> @@ -684,6 +684,29 @@ struct drm_bridge_funcs {
>  	int (*hdmi_write_spd_infoframe)(struct drm_bridge *bridge,
>  					const u8 *buffer, size_t len);
>  
> +	/**
> +	 * @hdmi_clear_vtem_emp:
> +	 *
> +	 * This callback clears the emp in the hardware during commit.
> +	 *
> +	 * This callback is optional but it must be implemented by bridges that
> +	 * set the DRM_BRIDGE_OP_HDMI_VTEM_EMP flag in their
> +	 * &drm_bridge->ops.
> +	 */
> +	int (*hdmi_clear_vtem_emp)(struct drm_bridge *bridge);
> +
> +	/**
> +	 * @hdmi_write_spd_infoframe:

[Severity: Low]
This isn't a bug, but should this kernel-doc name be @hdmi_write_vtem_emp 
to match the function pointer below? Running the kernel-doc validator on 
this header will likely emit warnings about an unused documentation block 
and an undocumented function pointer due to the mismatch.

> +	 *
> +	 * Program the emp into the hardware.
> +	 *
> +	 * This callback is optional but it must be implemented by bridges that
> +	 * set the DRM_BRIDGE_OP_HDMI_VTEM_EMP flag in their
> +	 * &drm_bridge->ops.
> +	 */
> +	int (*hdmi_write_vtem_emp)(struct drm_bridge *bridge,
> +				   const u8 *buffer, size_t len);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-vrr-limiter-uapi-v1-0-2fcd7d011646@collabora.com?part=5