From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D4B0C982ED for ; Mon, 21 Sep 2026 17:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID :References:Mime-Version:In-Reply-To:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LNAd0TD6tpb4NhMS834udYAuMi6UoM82AuEM4gpDVEI=; b=DF4e61CH1HVaMi V+g4KS4iKaziV9oNc8iyPTs/HZ2wfam0GQc6B1HoA04IgYKoS4ZOeaeUUnLT/OaHOSo10Mc9DZEF2 uLA3NhYDm3qiihp/vnOzcrTFX/6mVBq1B3UdmOtmtZA00kWjU8pQbRR1CG63ulmQFSNoXWnupEVpU t1c9+m9yGVraBsUdQO9LZcpUeKmjrOi71GfJnMgBii2BOpWwXZ9DQnI6eQuwpyyo/9bvPe/V68N/u 573yr34iH2+UGsdN99GP8t2DBESXUDbu6vJC/jb91mNiTSncoz0kN40fhKzr6YTorbh7GHQltIGuW LE247la3dvN3PZGpQWRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8i4e-000000031nO-2pEz; Mon, 21 Sep 2026 17:45:04 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8i4a-000000031gM-2fTb for linux-riscv@bombadil.infradead.org; Mon, 21 Sep 2026 17:45:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Cc:To:From:Subject: Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YYqX0VJzWkRuy7Rww/xIfxaxsSEw1uv9+hGx8/FiNWw=; b=N+ldkXD54WG4qN7uPTj/6sNDWa NBOJYf4pfKTDenw6AsSt5P85NWz68XRswL5IO8xatjgOl7svpotDFiZq3MCaPN7BnB1Y9IlogW+cQ dqFn4HBj9mRFwuLjn2Ty3TPfJwj2zrbt1I/XXzxK2g5cxAWr8hXNhIbylBHK3xIU/DNGgIN1XLAJx ef6HO9WkKEBqPgdXcXgYvC9ubOF1BXUPQDEgOOlcDIgfeUKxxGfUlX1FlrckeaMWpFjXDFmtZw5eB IMBBeiwher3ICeOrRrwrkEJY1Bga8QHHXRHg80IXwTBDXeTr4iJbgU3yXJ9LtcimhxkM9CXIh+pqR 0zQi8wuw==; Received: from mail-pg1-x547.google.com ([2607:f8b0:4864:20::547]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x8i4X-0000000CdsT-3U8L for linux-riscv@lists.infradead.org; Mon, 21 Sep 2026 17:44:59 +0000 Received: by mail-pg1-x547.google.com with SMTP id 41be03b00d2f7-cc51591102fso4683136a12.1 for ; Mon, 21 Sep 2026 10:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790012696; x=1790617496; darn=lists.infradead.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=YYqX0VJzWkRuy7Rww/xIfxaxsSEw1uv9+hGx8/FiNWw=; b=aVjEB0tRJpRSn7vfca6pMabbOo2O+7XmG05UVWoq94Zv/+U6yM51Yfy+WhpUV+s/QB PhcoHkL+kt4LpLw7H7myN793Zfw8wrftf157XdS0IB93WVv6BTiyNhRpVxgnDMjKbTg4 T2SOdFT//U0t36bualq+AYXnCvUoopydJIucOXmCJXy0d3SXE5U60NR90Bg9tBCvTOOi eGEnu2e2otD1LTkQl5o+VkO5wt091ugl5XCBPiyzGYaMHTyrd+zXrtyXTBZac1YLGSEv aMvdHS7bOdlOxK9dSHWC+LOghkzAVf0vvyAdLFfxIo/JjrF8GjnUGrV3tzxFJ7Uv8Aro T6Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790012696; x=1790617496; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=YYqX0VJzWkRuy7Rww/xIfxaxsSEw1uv9+hGx8/FiNWw=; b=2Z5G0+xKn5VdP5BfOuB6V/ls9fsoEYKPeaZRmEINtRiU7KC9WH8MFGG5befftnSYjB Imp97nJipsCOYz/9lAD4xnA0KFDgan1tKGQIcgeBBHY3q3RkzNoJ2muLunIMQR0miDIV OHDeYnS2H3murEq60q/H+9NDcSMAbs5Fot+MGu0O4wNa3fGbuHQO1tz3TVCoWLbpUV+D Q0ruyW4F8bwum4F6JJTTnune9ZTCu6XlnVo3TSpA/RPjQwKWjgHqMT9ruA2zRAXI4tJK O23/tNblumpgBo1EhR0CHiyEqi8tDwLQ7IH0b9ZrR7r0AADd5yVDvI6sYtmRrumbH9h1 Bx3g== X-Forwarded-Encrypted: i=1; AKwUvBzW3S+oER5EJKG8ftENCVsb0EfFg/LX+3H62M6mBuck1nGxGpBWGq0Sl8lOGwrb9cSj95cXUcpAF6eBvA==@lists.infradead.org X-Gm-Message-State: AFuF++nnjhiBumCdfMU1OxKEMncEMEw+pmOPeQlrEyQzbfKBkmL40bcj WIJ2USij/Dhaj2OI9J7mXbyzgLEb8LtrN+HxdGZqZpfPmENEeM1KYFB452gKTjxFzPcJoe2l5Ag Bb1Y/mA== X-Received: from pjro5.prod.google.com ([2002:a17:90a:b885:b0:3a0:645b:1c57]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:d888:b0:39e:4c7f:8b16 with SMTP id 98e67ed59e1d1-39e54cf8bdbmr17922638a91.27.1790012695572; Mon, 21 Sep 2026 10:44:55 -0700 (PDT) Date: Mon, 21 Sep 2026 10:44:45 -0700 In-Reply-To: <20260921174445.911676-1-seanjc@google.com> Mime-Version: 1.0 References: <20260921174445.911676-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Message-ID: <20260921174445.911676-8-seanjc@google.com> Subject: [PATCH v2 7/7] KVM: WARN if vCPU creation is in-progress when locking all vCPUs From: Sean Christopherson To: Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Paolo Bonzini , Kiryl Shutsemau , Rick Edgecombe Cc: Nicholas Piggin , Atish Patra , Alexandre Ghiti , Dave Hansen , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Jean-Christophe Guillain , "=?UTF-8?q?Pawe=C5=82=20S?=" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260921_184457_966682_4A8586B5 X-CRM114-Status: UNSURE ( 9.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Sean Christopherson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Now that KVM holds kvm->lock for the entirety of vCPU creation, from when created_vcpus is incremented until the new vCPU is fully onlined, WARN if the impossible happens and KVM somehow sees a discrepancy between the number of vCPUs "created" and "onlined". Signed-off-by: Sean Christopherson --- virt/kvm/kvm_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 985af39b980a..e66d9761ee49 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1363,7 +1363,7 @@ int kvm_trylock_all_vcpus(struct kvm *kvm) lockdep_assert_held(&kvm->lock); - if (kvm_is_vcpu_creation_in_progress(kvm)) + if (WARN_ON_ONCE(kvm_is_vcpu_creation_in_progress(kvm))) return -EBUSY; kvm_for_each_vcpu(i, vcpu, kvm) @@ -1389,7 +1389,7 @@ int kvm_lock_all_vcpus(struct kvm *kvm) lockdep_assert_held(&kvm->lock); - if (kvm_is_vcpu_creation_in_progress(kvm)) + if (WARN_ON_ONCE(kvm_is_vcpu_creation_in_progress(kvm))) return -EBUSY; kvm_for_each_vcpu(i, vcpu, kvm) { -- 2.55.0.1082.g2b9226bbc0-goog _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60CE5C982E6 for ; Mon, 21 Sep 2026 17:45:52 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4hpVx65gbzz3bdD; Tue, 22 Sep 2026 03:44:58 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::1045" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1790012698; cv=none; b=jkZNwfHIyQQhl5nQpY9kNvNZwveqdLU+cC0W4BstzcL2/l/e4lOEzrwBxN2UbKHdLmsXZfxfK1b70ctHMN3RYw550EsbNP9QMIMWI2GAMGwSv7/TkZgZ0Tpg6w+/VRQV6MpzdPWq4SKESlEL6VHSKZN8aK7mQIy47iMYBMx/Cp1c8GgIhxLUFMzXzdeLwE3MVibm3vx8c8KIKfiQJtwniaZ0zFVF+1yk079DzJUUNnT1601UBsvdb8+aoKaQAIKGncinspPdK/xArM03wJubWI7cLpJgKo7CiOpg8zOuoXcsPQXg7o887kvgCOig1oSsU0MSAAkqJWqCpVa8lQYyGw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1790012698; c=relaxed/relaxed; bh=YYqX0VJzWkRuy7Rww/xIfxaxsSEw1uv9+hGx8/FiNWw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Ajy1+Gh0l9g/pLUXxDKpRnLUGgcHm7oJzEyDFGnOkanwfq584emYo0IMWSEgEl6zUnNNTHPCcP/YpXq0fq1tkyv88xplgdWRWtyHVXakyzbpJ8AKVftvOtl3RT26IpZ8PPSgKJp71i8Ei0d9sLVGAIX8WbQN2GOudd/BdA76KjcOBgu1fbDPF4KipMxj4at2HzbCkxLi59IQzHetBRk9tZxlU+jRElMTgHRVd8CvgNBfmgo2b8AJq9pJoUQrSyDS/kEfZ9RD/VoDUnlz3QOnRdJRnTHMTchMeotjyiyXKx6guQS5SSb6nLFInkqa1D5FJZjt+4NXEomIzLqnpxJNtw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=WOp+mVTw; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::1045; helo=mail-pj1-x1045.google.com; envelope-from=3f22xagykdbqcyu73w08805y.w86527eh99w-xyf52cdc.8j5uvc.8b0@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=WOp+mVTw; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::1045; helo=mail-pj1-x1045.google.com; envelope-from=3f22xagykdbqcyu73w08805y.w86527eh99w-xyf52cdc.8j5uvc.8b0@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-pj1-x1045.google.com (mail-pj1-x1045.google.com [IPv6:2607:f8b0:4864:20::1045]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4hpVx61D9xz3bbm for ; Tue, 22 Sep 2026 03:44:58 +1000 (AEST) Received: by mail-pj1-x1045.google.com with SMTP id 98e67ed59e1d1-39e25a5f6e8so6027905a91.0 for ; Mon, 21 Sep 2026 10:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790012696; x=1790617496; darn=lists.ozlabs.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=YYqX0VJzWkRuy7Rww/xIfxaxsSEw1uv9+hGx8/FiNWw=; b=WOp+mVTwpElY0MI7OH2/Qfm2y86lF+1E39wv9qJkFmjYRzZCCjblY46XOlgzh6xNvd D/jt3l2mSDlpe+6uTw8lHQvSCRLlim3+U1Dc7pD1IqdPB+PqSXoBDT5hCeaFIiHH8Xkd Sr2yP8IkpoKwfsMuCBzpQuWcDCLHejB61CxPj7L2X7MASlwB7bN/yHi4bddkVwcmimm/ +0/Mje3oN3TkZK4lW5Ig9xfOkAeYGy1iuRinuGkbcdbsCGRxL9eR1nuCuWvWC7SOqvSx XtztZZ2SvriWHEc/YJOc60apGlYWtap45mcFyKuc76pJGEN24gCV3WvKRl8nK9ICSmSh BlHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790012696; x=1790617496; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=YYqX0VJzWkRuy7Rww/xIfxaxsSEw1uv9+hGx8/FiNWw=; b=VukVIfuVDxB6+AdrjuRTdfKgkYCULdwdAjOfgWidF8ztSmbCaLefG+SRoxZZZyQkqf POVYDC5tDC6H962bwGK1hqsgz9rL0dRFkampNKXJXOXSvTgtmGvKHAYYrAZQDcj9w2KY uxeimQclai3Ey36JbS/5mqR10D/OiCgAcwJ2ODej4HSEsPivfVoitzrbDBvlQfOOTE2O DVe/oFqW/5DoSR27cljnAyEOs6EzMiFDLg0xaWp+sD3+SKctXxfBzMMs6jcVXRHUqTNN Ix+rbj7kyJkcEXoqElfV8chv9MbLHGQA5clwxKagMXjmwga4jl7MpfMTwtg32WNYt9Po DnxQ== X-Forwarded-Encrypted: i=1; AKwUvBzISynZ8xNyy6zCYelCjk6FXkw0CSSFMhlRPQXlB37AIfU6jCVRG0d2qehob+vGP9/gswWj1CEcYFN45pg=@lists.ozlabs.org X-Gm-Message-State: AFuF++kc52QaI3Aa4r+IIQ22l/5SIS9/xLoAV+4qPT571nB6xjkj/dnp db6i40dUzlv8Ncf0ymSYPBGiERxmSPZWGdD8qIZjoUxWGCMUBKKtMmbfr9V2y7wIvsCqazv69+e MD5UTpg== X-Received: from pjro5.prod.google.com ([2002:a17:90a:b885:b0:3a0:645b:1c57]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:d888:b0:39e:4c7f:8b16 with SMTP id 98e67ed59e1d1-39e54cf8bdbmr17922638a91.27.1790012695572; Mon, 21 Sep 2026 10:44:55 -0700 (PDT) Reply-To: Sean Christopherson Date: Mon, 21 Sep 2026 10:44:45 -0700 In-Reply-To: <20260921174445.911676-1-seanjc@google.com> X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list Mime-Version: 1.0 References: <20260921174445.911676-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Message-ID: <20260921174445.911676-8-seanjc@google.com> Subject: [PATCH v2 7/7] KVM: WARN if vCPU creation is in-progress when locking all vCPUs From: Sean Christopherson To: Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Paolo Bonzini , Kiryl Shutsemau , Rick Edgecombe Cc: Nicholas Piggin , Atish Patra , Alexandre Ghiti , Dave Hansen , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Jean-Christophe Guillain , "=?UTF-8?q?Pawe=C5=82=20S?=" Content-Type: text/plain; charset="UTF-8" Now that KVM holds kvm->lock for the entirety of vCPU creation, from when created_vcpus is incremented until the new vCPU is fully onlined, WARN if the impossible happens and KVM somehow sees a discrepancy between the number of vCPUs "created" and "onlined". Signed-off-by: Sean Christopherson --- virt/kvm/kvm_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 985af39b980a..e66d9761ee49 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1363,7 +1363,7 @@ int kvm_trylock_all_vcpus(struct kvm *kvm) lockdep_assert_held(&kvm->lock); - if (kvm_is_vcpu_creation_in_progress(kvm)) + if (WARN_ON_ONCE(kvm_is_vcpu_creation_in_progress(kvm))) return -EBUSY; kvm_for_each_vcpu(i, vcpu, kvm) @@ -1389,7 +1389,7 @@ int kvm_lock_all_vcpus(struct kvm *kvm) lockdep_assert_held(&kvm->lock); - if (kvm_is_vcpu_creation_in_progress(kvm)) + if (WARN_ON_ONCE(kvm_is_vcpu_creation_in_progress(kvm))) return -EBUSY; kvm_for_each_vcpu(i, vcpu, kvm) { -- 2.55.0.1082.g2b9226bbc0-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57B72C982E6 for ; Mon, 21 Sep 2026 17:45:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID :References:Mime-Version:In-Reply-To:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gdNZMcycfid5Lv7WgHXbGLF/yk+eQCuRtWdHe+OXGf4=; b=A9TpXinwlWIVfZ UgyeR6P0o4zhoA0nJHKri55sasNwbfT+uqIgW0Fsw3cBcYxTVuMbW6OACN4lXgnW/NCrUBcsS0sRi 6a/Hj7k7RavLKf09zjdppLFH8zjo8Fb1j6OufTU/Pvn9lo+wSQAqbW74Hr5wFmHPWnMMJ3ApYSgaZ XUcAScJdONguvWngSMfKNjdhKL0NYtBpzfnl9qjzQtkaJ9jEprLLzhkcCXSb3AUw6vXONGTH5HYkw aDH30DoCtA3rmqdRgkyTtqSSvpmkyAiZUnszuyPD+BoAfp8jiLeAuUYXBaluHFeRSdDMU/giG8CdF vlk3+pZGTLNBAGFREcbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8i4e-000000031nn-3sMb; Mon, 21 Sep 2026 17:45:04 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8i4b-000000031iD-1ouS for kvm-riscv@bombadil.infradead.org; Mon, 21 Sep 2026 17:45:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Cc:To:From:Subject: Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YYqX0VJzWkRuy7Rww/xIfxaxsSEw1uv9+hGx8/FiNWw=; b=N+ldkXD54WG4qN7uPTj/6sNDWa NBOJYf4pfKTDenw6AsSt5P85NWz68XRswL5IO8xatjgOl7svpotDFiZq3MCaPN7BnB1Y9IlogW+cQ dqFn4HBj9mRFwuLjn2Ty3TPfJwj2zrbt1I/XXzxK2g5cxAWr8hXNhIbylBHK3xIU/DNGgIN1XLAJx ef6HO9WkKEBqPgdXcXgYvC9ubOF1BXUPQDEgOOlcDIgfeUKxxGfUlX1FlrckeaMWpFjXDFmtZw5eB IMBBeiwher3ICeOrRrwrkEJY1Bga8QHHXRHg80IXwTBDXeTr4iJbgU3yXJ9LtcimhxkM9CXIh+pqR 0zQi8wuw==; Received: from mail-pj1-x1047.google.com ([2607:f8b0:4864:20::1047]) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1x8i4Y-0000000CdsU-2y3K for kvm-riscv@lists.infradead.org; Mon, 21 Sep 2026 17:45:00 +0000 Received: by mail-pj1-x1047.google.com with SMTP id 98e67ed59e1d1-3823dcc1647so4522566a91.3 for ; Mon, 21 Sep 2026 10:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790012696; x=1790617496; darn=lists.infradead.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=YYqX0VJzWkRuy7Rww/xIfxaxsSEw1uv9+hGx8/FiNWw=; b=aVjEB0tRJpRSn7vfca6pMabbOo2O+7XmG05UVWoq94Zv/+U6yM51Yfy+WhpUV+s/QB PhcoHkL+kt4LpLw7H7myN793Zfw8wrftf157XdS0IB93WVv6BTiyNhRpVxgnDMjKbTg4 T2SOdFT//U0t36bualq+AYXnCvUoopydJIucOXmCJXy0d3SXE5U60NR90Bg9tBCvTOOi eGEnu2e2otD1LTkQl5o+VkO5wt091ugl5XCBPiyzGYaMHTyrd+zXrtyXTBZac1YLGSEv aMvdHS7bOdlOxK9dSHWC+LOghkzAVf0vvyAdLFfxIo/JjrF8GjnUGrV3tzxFJ7Uv8Aro T6Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790012696; x=1790617496; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=YYqX0VJzWkRuy7Rww/xIfxaxsSEw1uv9+hGx8/FiNWw=; b=wx724qTmk+prLuwWsnJKfEXmMATA1CHbVJew3q17bMUGIr5Mowvfz5STva5ge0d0zy K/5OqMVMq/qMCJj37dAgOpDpfZ3niTk2OCqBfRdVbwhwiNLPASRqUKbT3an6lw+D4JCt xcfx623iLMlXK7kurdH3YSpBsXokoc1laLHgPOX60V/nNM5ojS5rOC9rgxdIxgIwLwPd BN2leI7N5oKTNtQ7l40pe+yOxCsxT8Ni+5Af1+1i5Yz0hjnMYit5MU5GmfJC0k4ODwOL ggkeacycZzYYSSCIygV0KKhgDQLPnUcJHr8yz7CBMRLwiNHwq3A9zRO0WfN1LpmBiqLn nBSA== X-Forwarded-Encrypted: i=1; AKwUvBx3d+ORYcMcD3cYKMf7O7QjhIWLWWMdlDmBskEGZClcx7wQnGrGLiXg+ko3m6UlYXczcg0kG/2Bm0I=@lists.infradead.org X-Gm-Message-State: AFuF++kFKwF8l9t072Z/VBsU9OuwLHJmMvfl3XQeNGO+XfPJbpNjMLJx u2qdRyyKdy3Fa/LsdK/xba8nW1kPYUihOsvBZweAAgbBu7eJ9tP+dLl0auZ8ZPDY7Xmm2YoBgLR WmAPB4g== X-Received: from pjro5.prod.google.com ([2002:a17:90a:b885:b0:3a0:645b:1c57]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:d888:b0:39e:4c7f:8b16 with SMTP id 98e67ed59e1d1-39e54cf8bdbmr17922638a91.27.1790012695572; Mon, 21 Sep 2026 10:44:55 -0700 (PDT) Date: Mon, 21 Sep 2026 10:44:45 -0700 In-Reply-To: <20260921174445.911676-1-seanjc@google.com> Mime-Version: 1.0 References: <20260921174445.911676-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Message-ID: <20260921174445.911676-8-seanjc@google.com> Subject: [PATCH v2 7/7] KVM: WARN if vCPU creation is in-progress when locking all vCPUs From: Sean Christopherson To: Madhavan Srinivasan , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Paolo Bonzini , Kiryl Shutsemau , Rick Edgecombe Cc: Nicholas Piggin , Atish Patra , Alexandre Ghiti , Dave Hansen , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, Jean-Christophe Guillain , "=?UTF-8?q?Pawe=C5=82=20S?=" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260921_184458_860266_F3576C75 X-CRM114-Status: UNSURE ( 9.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Sean Christopherson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org Now that KVM holds kvm->lock for the entirety of vCPU creation, from when created_vcpus is incremented until the new vCPU is fully onlined, WARN if the impossible happens and KVM somehow sees a discrepancy between the number of vCPUs "created" and "onlined". Signed-off-by: Sean Christopherson --- virt/kvm/kvm_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 985af39b980a..e66d9761ee49 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1363,7 +1363,7 @@ int kvm_trylock_all_vcpus(struct kvm *kvm) lockdep_assert_held(&kvm->lock); - if (kvm_is_vcpu_creation_in_progress(kvm)) + if (WARN_ON_ONCE(kvm_is_vcpu_creation_in_progress(kvm))) return -EBUSY; kvm_for_each_vcpu(i, vcpu, kvm) @@ -1389,7 +1389,7 @@ int kvm_lock_all_vcpus(struct kvm *kvm) lockdep_assert_held(&kvm->lock); - if (kvm_is_vcpu_creation_in_progress(kvm)) + if (WARN_ON_ONCE(kvm_is_vcpu_creation_in_progress(kvm))) return -EBUSY; kvm_for_each_vcpu(i, vcpu, kvm) { -- 2.55.0.1082.g2b9226bbc0-goog -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv