From: Jakub Kicinski <kuba@kernel.org>
To: Naman Gulati <namangulati@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, bigeasy@linutronix.de,
kuniyu@google.com,
syzbot+f0661448aa9511ce744a@syzkaller.appspotmail.com
Subject: Re: [PATCH net] net: gro_cells: prevent enabling threaded NAPI on gro_cells
Date: Mon, 21 Sep 2026 18:11:52 -0700 [thread overview]
Message-ID: <20260921181152.36e86501@kernel.org> (raw)
In-Reply-To: <CAMP57yVWkD5rUXYQhqpdRYtiFWxggZ1yN6rnEzMDNYJSUVuMow@mail.gmail.com>
On Mon, 21 Sep 2026 10:15:39 -0700 Naman Gulati wrote:
> Would it be better to piggy-back on this behavior and add something
> like this check in modify_napi_threaded:
>
> list_for_each_entry(napi, &dev->napi_list, dev_list) {
> if (napi_id_valid(napi->napi_id))
> return netif_set_threaded(dev, val);
> }
Yes, this should work.
next prev parent reply other threads:[~2026-09-22 1:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 17:34 [PATCH net] net: gro_cells: prevent enabling threaded NAPI on gro_cells Naman Gulati
2026-09-20 0:28 ` Jakub Kicinski
2026-09-21 17:15 ` Naman Gulati
2026-09-22 1:11 ` Jakub Kicinski [this message]
2026-09-22 18:03 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921181152.36e86501@kernel.org \
--to=kuba@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuniyu@google.com \
--cc=namangulati@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+f0661448aa9511ce744a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.