Re: [PATCH v2 4/8] PM / devfreq: rockchip-dfi: add NO_INTERRUPT perf capability

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf: logic inversion in commit message regarding sampling support
--

commit 568c8dc55a298020ff3044a68b97809f490ba7e0
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

PM / devfreq: rockchip-dfi: add NO_INTERRUPT perf capability

This commit adds the PERF_PMU_CAP_NO_INTERRUPT capability flag to the
rockchip-dfi PMU. This informs the perf core that the PMU does not support
sampling.

Link: https://lore.kernel.org/all/20250619140442.GH1613376@noisy.programming.kicks-ass.net/ [1]

>     The perf subsystem's PERF_PMU_CAP_NO_INTERRUPT is a bit of a
>     misnomer.[1] Instead of meaning that the PMU has no interrupt, it
>     actually means that the PMU does support sampling. On CPU PMUs, this is

[Severity: Low]
Is there a missing "not" in this sentence?

In kernel/events/core.c, if a sampling event is requested for a PMU with this
flag, the allocation fails with -EOPNOTSUPP. Thus, the flag means the PMU does
not support sampling.

The code in drivers/devfreq/event/rockchip-dfi.c:rockchip_ddr_perf_init()
correctly applies the flag, so there is no functional issue, but the commit
message contains a logic inversion.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-rockchip-dfi-cleanup-v2-0-43ff34ac8599@collabora.com?part=4