All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Phil Dennis-Jordan" <phil@philjordan.eu>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Alexander Graf" <agraf@csgraf.de>,
	"Jason Wang" <jasowangio@gmail.com>,
	qemu-arm@nongnu.org,
	"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Bernhard Beschow" <shentey@gmail.com>,
	"Jean-Christophe Dubois" <jcd@tribudubois.net>,
	"Gaurav Sharma" <gaurav.sharma_7@nxp.com>
Subject: [PATCH 42/42] hw/watchdog/wdt_imx2: Trace with QOM path
Date: Mon, 21 Sep 2026 23:47:10 +0200	[thread overview]
Message-ID: <20260921214710.29422-43-shentey@gmail.com> (raw)
In-Reply-To: <20260921214710.29422-1-shentey@gmail.com>

SoCs such as the i.MX8M Plus have several of these watchdog devices.
Allow to distinguish the instances when tracing.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
 hw/watchdog/wdt_imx2.c   | 8 ++++----
 hw/watchdog/trace-events | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/hw/watchdog/wdt_imx2.c b/hw/watchdog/wdt_imx2.c
index c8ea704aa3..f5ba69ca7e 100644
--- a/hw/watchdog/wdt_imx2.c
+++ b/hw/watchdog/wdt_imx2.c
@@ -23,7 +23,7 @@ static void imx2_wdt_interrupt(void *opaque)
 {
     IMX2WdtState *s = IMX2_WDT(opaque);
 
-    trace_imx2_wdt_interrupt();
+    trace_imx2_wdt_interrupt(DEVICE(s)->canonical_path);
 
     s->wicr |= IMX2_WDT_WICR_WTIS;
     qemu_set_irq(s->irq, 1);
@@ -33,7 +33,7 @@ static void imx2_wdt_expired(void *opaque)
 {
     IMX2WdtState *s = IMX2_WDT(opaque);
 
-    trace_imx2_wdt_expired();
+    trace_imx2_wdt_expired(DEVICE(s)->canonical_path);
 
     s->wrsr = IMX2_WDT_WRSR_TOUT;
 
@@ -90,7 +90,7 @@ static uint64_t imx2_wdt_read(void *opaque, hwaddr addr, unsigned int size)
         break;
     }
 
-    trace_imx2_wdt_read(addr, value);
+    trace_imx2_wdt_read(DEVICE(s)->canonical_path, addr, value);
 
     return value;
 }
@@ -149,7 +149,7 @@ static void imx2_wdt_write(void *opaque, hwaddr addr,
 {
     IMX2WdtState *s = IMX2_WDT(opaque);
 
-    trace_imx2_wdt_write(addr, value);
+    trace_imx2_wdt_write(DEVICE(s)->canonical_path, addr, value);
 
     switch (addr) {
     case IMX2_WDT_WCR:
diff --git a/hw/watchdog/trace-events b/hw/watchdog/trace-events
index b388f7b250..5963943d5d 100644
--- a/hw/watchdog/trace-events
+++ b/hw/watchdog/trace-events
@@ -18,10 +18,10 @@ aspeed_wdt_read(uint64_t addr, uint32_t size) "@0x%" PRIx64 " size=%d"
 aspeed_wdt_write(uint64_t addr, uint32_t size, uint64_t data) "@0x%" PRIx64 " size=%d value=0x%"PRIx64
 
 # wdt_imx2.c
-imx2_wdt_read(uint32_t addr, uint16_t data) "[0x%" PRIx32 "] -> 0x%" PRIx16
-imx2_wdt_write(uint32_t addr, uint16_t data) "[0x%" PRIx32 "] <- 0x%" PRIx16
-imx2_wdt_interrupt(void) ""
-imx2_wdt_expired(void) ""
+imx2_wdt_read(const char *qom_path, uint32_t addr, uint16_t data) "%s: [0x%" PRIx32 "] -> 0x%" PRIx16
+imx2_wdt_write(const char *qom_path, uint32_t addr, uint16_t data) "%s: [0x%" PRIx32 "] <- 0x%" PRIx16
+imx2_wdt_interrupt(const char *qom_path) "%s"
+imx2_wdt_expired(const char *qom_path) "%s"
 
 # spapr_watchdog.c
 spapr_watchdog_start(uint64_t flags, uint64_t num, uint64_t timeout) "Flags 0x%" PRIx64 " num=%" PRId64 " %" PRIu64 "ms"
-- 
2.55.0



  parent reply	other threads:[~2026-09-21 21:52 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 21:46 [PATCH 00/42] i.MX fixes and cleanup Bernhard Beschow
2026-09-21 21:46 ` [PATCH 01/42] hw/watchdog/wdt_imx2: Fix handling of write-once WCR bits Bernhard Beschow
2026-09-28 18:22   ` Peter Maydell
2026-09-28 20:55     ` Bernhard Beschow
2026-09-21 21:46 ` [PATCH 02/42] hw/watchdog/wdt_imx2: Remove unused attributes Bernhard Beschow
2026-09-28 18:24   ` Peter Maydell
2026-09-21 21:46 ` [PATCH 03/42] hw/arm/imx8mm-evk: Fix reference count of SoC object Bernhard Beschow
2026-09-28 18:36   ` Peter Maydell
2026-09-21 21:46 ` [PATCH 04/42] hw/arm/mcimx7d-sabre: Ignore memory transaction failures Bernhard Beschow
2026-09-28 18:05   ` Peter Maydell
2026-09-28 20:58     ` Bernhard Beschow
2026-09-21 21:46 ` [PATCH 05/42] docs, tests/functional: Drop redundant CLI arguments in imx8m*-evk invocations Bernhard Beschow
2026-09-28 18:37   ` Peter Maydell
2026-09-29 12:15   ` Philippe Mathieu-Daudé
2026-09-21 21:46 ` [PATCH 06/42] hw/arm/sabrelite: Have 4 CPUs and 1 GiB of RAM by default Bernhard Beschow
2026-09-29 12:13   ` Philippe Mathieu-Daudé
2026-09-21 21:46 ` [PATCH 07/42] tests/functional/arm: Add console test for `sabrelite` machine Bernhard Beschow
2026-09-29 12:14   ` Philippe Mathieu-Daudé
2026-09-21 21:46 ` [PATCH 08/42] hw/arm/mcimx6ul-evk: Have 512 MiB of RAM by default Bernhard Beschow
2026-09-21 21:46 ` [PATCH 09/42] hw/arm/mcimx7d-sabre: Have 2 CPUs and 2 GiB " Bernhard Beschow
2026-09-21 21:46 ` [PATCH 10/42] tests/functional/arm: Add console test for `mcimx7d-sabre` machine Bernhard Beschow
2026-09-29 12:14   ` Philippe Mathieu-Daudé
2026-09-21 21:46 ` [PATCH 11/42] hw/arm/fsl-imx25: Derive from TYPE_SYS_BUS_DEVICE Bernhard Beschow
2026-09-29 12:17   ` Philippe Mathieu-Daudé
2026-09-21 21:46 ` [PATCH 12/42] hw/arm/fsl-imx31: " Bernhard Beschow
2026-09-21 21:46 ` [PATCH 13/42] hw/arm/fsl-imx6: " Bernhard Beschow
2026-09-21 21:46 ` [PATCH 14/42] hw/arm/fsl-imx6ul: " Bernhard Beschow
2026-09-21 21:46 ` [PATCH 15/42] hw/arm/fsl-imx7: " Bernhard Beschow
2026-09-21 21:46 ` [PATCH 16/42] hw/timer/imx_gpt: Wire clock control module via link property Bernhard Beschow
2026-09-29 12:18   ` Philippe Mathieu-Daudé
2026-09-21 21:46 ` [PATCH 17/42] hw/timer/imx_epit: " Bernhard Beschow
2026-09-29 12:18   ` Philippe Mathieu-Daudé
2026-09-21 21:46 ` [PATCH 18/42] hw/arm/Kconfig: Select missing UNIMP in config FSL_IMX8MM Bernhard Beschow
2026-09-29 12:18   ` Philippe Mathieu-Daudé
2026-09-21 21:46 ` [PATCH 19/42] hw/misc/Kconfig: Remove redundant USB_EHCI_SYSBUS from config IMX Bernhard Beschow
2026-09-21 21:46 ` [PATCH 20/42] Kconfig: Extract config IMX_AVIC " Bernhard Beschow
2026-09-29 12:19   ` Philippe Mathieu-Daudé
2026-09-21 21:46 ` [PATCH 21/42] Kconfig: Extract config IMX_GPCV2 " Bernhard Beschow
2026-09-29 12:19   ` Philippe Mathieu-Daudé
2026-09-21 21:46 ` [PATCH 22/42] Kconfig: Extract config IMX_RNG " Bernhard Beschow
2026-09-29 12:20   ` Philippe Mathieu-Daudé
2026-09-21 21:46 ` [PATCH 23/42] Kconfig: Extract config FSL_IMX7_GPR " Bernhard Beschow
2026-09-29 12:23   ` Philippe Mathieu-Daudé
2026-09-21 21:46 ` [PATCH 24/42] Kconfig: Extract config FSL_IMX{6, 7}_SRC " Bernhard Beschow
2026-09-21 21:46 ` [PATCH 25/42] Kconfig: Extract config FSL_IMX7_SNVS " Bernhard Beschow
2026-09-21 21:46 ` [PATCH 26/42] Kconfig: Extract dedicated config FSL_IMXx_CCM " Bernhard Beschow
2026-09-21 21:46 ` [PATCH 27/42] Kconfig: Extract config IMX_GPT " Bernhard Beschow
2026-09-21 21:46 ` [PATCH 28/42] Kconfig: Extract config IMX_EPIT " Bernhard Beschow
2026-09-21 21:46 ` [PATCH 29/42] Kconfig: Extract config GPIO_IMX " Bernhard Beschow
2026-09-21 21:46 ` [PATCH 30/42] Kconfig: Extract config IMX_SPI " Bernhard Beschow
2026-09-21 21:46 ` [PATCH 31/42] Kconfig: Extract config IMX_SERIAL " Bernhard Beschow
2026-09-21 21:47 ` [PATCH 32/42] Kconfig: Remove " Bernhard Beschow
2026-09-21 21:47 ` [PATCH 33/42] hw/vmapple/Kconfig: Remove unused GPIO_PWR dependency Bernhard Beschow
2026-09-29 12:25   ` Philippe Mathieu-Daudé
2026-09-21 21:47 ` [PATCH 34/42] hw/arm/fsl-imx8m: Fix typo Bernhard Beschow
2026-09-21 21:47 ` [PATCH 35/42] hw/misc/imx6_src: Avoid casting from void * Bernhard Beschow
2026-09-29 12:25   ` Philippe Mathieu-Daudé
2026-09-21 21:47 ` [PATCH 36/42] hw/char/imx_serial: " Bernhard Beschow
2026-09-29 12:26   ` Philippe Mathieu-Daudé
2026-09-21 21:47 ` [PATCH 37/42] hw/intc/imx_avic: " Bernhard Beschow
2026-09-21 21:47 ` [PATCH 38/42] hw/misc/imx*_ccm: " Bernhard Beschow
2026-09-21 21:47 ` [PATCH 39/42] hw/usb/imx-usb-phy: " Bernhard Beschow
2026-09-21 21:47 ` [PATCH 40/42] hw/net/imx_fec: Trace with QOM path where easily possible Bernhard Beschow
2026-09-29 12:27   ` Philippe Mathieu-Daudé
2026-09-21 21:47 ` [PATCH 41/42] hw/net/lan9118_phy: Trace with QOM path Bernhard Beschow
2026-09-21 21:47 ` Bernhard Beschow [this message]
2026-09-29 12:39 ` [PATCH 00/42] i.MX fixes and cleanup Philippe Mathieu-Daudé
2026-09-29 12:54   ` Peter Maydell
2026-10-04 12:30   ` Bernhard Beschow
2026-10-05 14:35 ` SysBus reset and heterogeneous emulation Philippe Mathieu-Daudé
2026-10-05 15:05   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921214710.29422-43-shentey@gmail.com \
    --to=shentey@gmail.com \
    --cc=agraf@csgraf.de \
    --cc=alistair@alistair23.me \
    --cc=gaurav.sharma_7@nxp.com \
    --cc=jasowangio@gmail.com \
    --cc=jcd@tribudubois.net \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=phil@philjordan.eu \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.