Re: [PATCH 3/3] xfs_quota: fix XFS_GETQSTAT parameter pointer

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Sep 21, 2026 at 01:29:17AM -0700, Christoph Hellwig wrote:
> On Sun, Sep 20, 2026 at 11:14:27PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > LOLLM noticed that XFS_GETQSTAT is supposed to take a pointer to a
> > struct fs_quota_stat, not a struct fs_quota_statv.  However, quotactl
> > call throws away all such nuance by accepting any void pointer, so this
> > got broken by the recent refactoring.  Fix all that.
> 
> Heh.  Should we replace xfrog_quotactl with typed variants for each
> argument?

That sounds like a good idea.  I think these are the only quota
commands?

#define Q_XQUOTAON	XQM_CMD(1)	/* enable accounting/enforcement */
#define Q_XQUOTAOFF	XQM_CMD(2)	/* disable accounting/enforcement */
#define Q_XGETQUOTA	XQM_CMD(3)	/* get disk limits and usage */
#define Q_XSETQLIM	XQM_CMD(4)	/* set disk limits */
#define Q_XGETQSTAT	XQM_CMD(5)	/* get quota subsystem status */
#define Q_XQUOTARM	XQM_CMD(6)	/* free disk space used by dquots */
#define Q_XQUOTASYNC	XQM_CMD(7)	/* delalloc flush, updates dquots */
#define Q_XGETQSTATV	XQM_CMD(8)	/* newer version of get quota */
#define Q_XGETNEXTQUOTA	XQM_CMD(9)	/* get disk limits and usage */

> For now this fix itself looks good, though:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!

--D