From: sashiko-bot@kernel.org
To: "Jaidev Shastri" <jaidevshastri@vt.edu>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 4/6] vt: keyboard: publish accent_table_size with release semantics
Date: Tue, 22 Sep 2026 01:36:49 +0000 [thread overview]
Message-ID: <20260922013649.A2BBC1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921-mb-keyboard-v1-4-d170228b80c0@vt.edu>
> From: Jaidev Shastri <jaidevshastri@vt.edu>
>
> vt_do_kdskbdiacr() and vt_do_kdskbdiacruc() rewrite accent_table[] and
> accent_table_size. handle_diacr() reads the size and then walks the
> table.
>
> vt_do_kdskbdiacr() sets the size before it converts the entries, so the
> size covers entries that have not been written yet. Set it after the
> loop in both paths and publish it with smp_store_release(); read it once
> with smp_load_acquire() before the walk.
>
> Found with MBCheck, a static herd7-based memory consistency checker.
>
> Signed-off-by: Jaidev Shastri <jaidevshastri@vt.edu>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-mb-keyboard-v1-0-d170228b80c0@vt.edu?part=4
next prev parent reply other threads:[~2026-09-22 1:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 1:28 [PATCH 0/6] vt: keyboard: make the kbd_event_lock ordering explicit Jaidev Shastri via B4 Relay
2026-09-22 1:28 ` Jaidev Shastri
2026-09-22 1:28 ` [PATCH 1/6] vt: keyboard: publish shift_state with release semantics Jaidev Shastri via B4 Relay
2026-09-22 1:28 ` Jaidev Shastri
2026-09-22 1:38 ` sashiko-bot
2026-09-23 12:51 ` Greg Kroah-Hartman
2026-09-22 1:28 ` [PATCH 2/6] vt: keyboard: publish npadch_value " Jaidev Shastri via B4 Relay
2026-09-22 1:28 ` Jaidev Shastri
2026-09-22 1:39 ` sashiko-bot
2026-09-22 1:28 ` [PATCH 3/6] vt: keyboard: publish dead_key_next " Jaidev Shastri via B4 Relay
2026-09-22 1:28 ` Jaidev Shastri
2026-09-22 1:39 ` sashiko-bot
2026-09-22 1:28 ` [PATCH 4/6] vt: keyboard: publish accent_table_size " Jaidev Shastri via B4 Relay
2026-09-22 1:28 ` Jaidev Shastri
2026-09-22 1:36 ` sashiko-bot [this message]
2026-09-22 1:28 ` [PATCH 5/6] vt: keyboard: recompute the shift state into locals before publishing it Jaidev Shastri via B4 Relay
2026-09-22 1:28 ` Jaidev Shastri
2026-09-22 1:34 ` sashiko-bot
2026-09-22 1:28 ` [PATCH 6/6] vt: keyboard: publish the shift_down[] counters with release semantics Jaidev Shastri via B4 Relay
2026-09-22 1:28 ` Jaidev Shastri
2026-09-22 1:42 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922013649.A2BBC1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jaidevshastri@vt.edu \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.