All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Chuck Lever" <cel@kernel.org>
Cc: "Anna Schumaker" <anna@kernel.org>,
	"Chuck Lever" <cel@kernel.org>,
	"Jeff Layton" <jlayton@kernel.org>,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH v1 1/5] SUNRPC: fire svc_xprt_free tracepoint before dropping the netns
Date: Tue, 22 Sep 2026 01:57:33 +0000	[thread overview]
Message-ID: <20260922015734.00D6D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922015128.240977-1-cel@kernel.org>

> svc_xprt_free() releases the transport's network namespace
> reference and then fires trace_svc_xprt_free(), which reads
> xpt_net->ns.inum through SVC_XPRT_ENDPOINT_ASSIGNMENTS. When the
> transport holds the last reference, the namespace is already on
> the cleanup list by the time the tracepoint reads it. The window
> is narrow, since cleanup_net() runs from a workqueue, but nothing
> holds the namespace alive across it.
> 
> Fire the tracepoint before any of the teardown steps, while every
> field it records is still valid.
> 
> Fixes: 11bbb0f76e99 ("SUNRPC: Trace a few more generic svc_xprt events")
> Signed-off-by: Chuck Lever <cel@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922015128.240977-1-cel@kernel.org?part=1


      parent reply	other threads:[~2026-09-22  1:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22  1:51 [PATCH v1 1/5] SUNRPC: fire svc_xprt_free tracepoint before dropping the netns Chuck Lever
2026-09-22  1:51 ` [PATCH v1 2/5] SUNRPC: fire svc_defer_queue tracepoint before publishing the request Chuck Lever
2026-09-22  1:57   ` sashiko-bot
2026-09-22  1:51 ` [PATCH v1 3/5] svcrdma: fix a page leak in backchannel sends Chuck Lever
2026-09-22  1:58   ` sashiko-bot
2026-09-22  1:51 ` [PATCH v1 4/5] svcrdma: release a send context stranded by a partial post Chuck Lever
2026-09-22  1:59   ` sashiko-bot
2026-09-22  1:51 ` [PATCH v1 5/5] svcrdma: release a receive context stranded by a partial Read post Chuck Lever
2026-09-22  1:57   ` sashiko-bot
2026-09-22  1:57 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922015734.00D6D1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=anna@kernel.org \
    --cc=cel@kernel.org \
    --cc=jlayton@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.