From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E9B7C982FE for ; Tue, 22 Sep 2026 04:46:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3760E10E2AE; Tue, 22 Sep 2026 04:46:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="JGx6po0O"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9999510E2AE for ; Tue, 22 Sep 2026 04:46:47 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 5555842A15; Tue, 22 Sep 2026 04:46:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1545D1F000FF; Tue, 22 Sep 2026 04:46:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790052407; bh=ndlPwcLp6f7OHDZSX5ZVa/+47A+PQM8+/qnxVdPHl/E=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=JGx6po0OfhMFVl36qK7/sIQf6JUg2WRO0Ez0ZyVgCLllAbzQY4GmJXKPoOuxcpvUc busgeJ2MOBkVc0GuDmXnfNyymbF7/3+gs5esvK8NBeB6OFmnCuchaUUjqODCaupd4F yQcQyW7SSFyNraLmnwGD6cwb0ct2kN+ROgAIyerPhxnh2NTB7qSDPeeFWrf22dWDoI 7YCXwM06tvZmIVo5Z0QsPlhx6T1+aF1o9XE5cM+qHTbkPvZXkbNu/20Y4zOoGFl+8/ mwegkqz/DCZvNqpUoVN8N7WmMhz7DKWF+QccIdHOpsTsT5PEpnaSxCMtvph6GDOg2s rafzkhUj8l/XA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2] drm/nouveau: Fix memory leaks in debugfs and hwmon init error paths To: liupeng Cc: linux-hwmon@vger.kernel.org, dri-devel@lists.freedesktop.org In-Reply-To: <20260922044044.21442-1-liupeng01@kylinos.cn> References: <20260922044044.21442-1-liupeng01@kylinos.cn> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 22 Sep 2026 04:46:46 +0000 Message-Id: <20260922044647.1545D1F000FF@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > In nouveau_debugfs_init(), if nvif_object_ctor() fails, the previously > allocated drm->debugfs is leaked because the function returns the > error code directly. >=20 > In nouveau_hwmon_init(), if hwmon_device_register_with_info() fails, > the allocated hwmon structure is leaked because the function returns > the error code directly. >=20 > Fix both by freeing the allocated memory and clearing the pointer on > the error paths. >=20 > Fixes: b126a200e9db ("drm/nouveau/debugfs: we need a ctrl object for debu= gfs") > Fixes: b9ed919f1c8f ("drm/nouveau/drm/pm: remove everything except the hw= mon interfaces to THERM") > Cc: stable@vger.kernel.org > Signed-off-by: liupeng Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260922044044.2144= 2-1-liupeng01@kylinos.cn?part=3D1