From: sashiko-bot@kernel.org
To: "Ginger Li" <ginger.jzllee@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: max3100: Fix a data race on s->rts in max3100_work()
Date: Tue, 22 Sep 2026 05:40:46 +0000 [thread overview]
Message-ID: <20260922054047.505FF1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922053151.11260-1-ginger.jzllee@gmail.com>
> max3100_work() reads s->rts when it processes a pending RTS update and when
> it transmits a character, both times without holding s->conf_lock.
> max3100_set_mctrl() updates s->rts under that lock when the requested RTS
> state changes, so the two accesses race and the work handler can program the
> old RTS state in the hardware.
>
> Take the value of s->rts in the s->conf_lock protected snapshot at the top of
> the loop, like the other configuration fields.
>
> Fixes: 7831d56b0a35 ("tty: MAX3100")
> Signed-off-by: Ginger Li <ginger.jzllee@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260922053151.11260-1-ginger.jzllee@gmail.com?part=1
next prev parent reply other threads:[~2026-09-22 5:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 5:31 [PATCH] serial: max3100: Fix a data race on s->rts in max3100_work() Ginger Li
2026-09-22 5:40 ` sashiko-bot [this message]
2026-09-22 8:17 ` Maarten Brock
2026-09-22 8:26 ` Ginger
2026-09-22 9:25 ` Maarten Brock
2026-09-22 17:04 ` Ginger
2026-09-22 17:02 ` [PATCH v2] " Ginger Li
2026-09-22 17:12 ` sashiko-bot
2026-09-23 10:31 ` Greg KH
2026-09-24 8:32 ` Maarten Brock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922054047.505FF1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ginger.jzllee@gmail.com \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.