All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fuad Tabba <fuad.tabba@linux.dev>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>,
	Shuah Khan <shuah@kernel.org>, Oliver Upton <oupton@kernel.org>
Cc: "Tejun Heo" <tj@kernel.org>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Michal Koutný" <mkoutny@suse.com>,
	"James Houghton" <jthoughton@google.com>,
	"Will Deacon" <will@kernel.org>, "Fuad Tabba" <tabba@google.com>,
	kvm@vger.kernel.org, kvmarm@lists.linux.dev,
	cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/2] selftests/cgroup: Make the object directory an order-only prerequisite
Date: Tue, 22 Sep 2026 08:19:45 +0100	[thread overview]
Message-ID: <20260922071945.693714-3-fuad.tabba@linux.dev> (raw)
In-Reply-To: <20260922071945.693714-1-fuad.tabba@linux.dev>

libcgroup.mk names $(LIBCGROUP_O_DIRS) as a regular prerequisite of
cgroup_util.o. The directory's mtime moves whenever an object is
created or replaced in it, so an incremental KVM selftests build that
rebuilt anything in lib/ recompiles cgroup_util.o and relinks every
test on the following run. Make the directory order-only, as
libvfio.mk does.

Fixes: 2c754a84ff16a ("cgroup: selftests: Move cgroup_util into its own library")
Assisted-by: LLM
Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>
---
 tools/testing/selftests/cgroup/lib/libcgroup.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/cgroup/lib/libcgroup.mk b/tools/testing/selftests/cgroup/lib/libcgroup.mk
index 7a73007204c39..bcf6fe2516223 100644
--- a/tools/testing/selftests/cgroup/lib/libcgroup.mk
+++ b/tools/testing/selftests/cgroup/lib/libcgroup.mk
@@ -13,7 +13,7 @@ EXTRA_HDRS := $(selfdir)/clone3/clone3_selftests.h
 $(LIBCGROUP_O_DIRS):
 	mkdir -p $@
 
-$(LIBCGROUP_O): $(OUTPUT)/%.o : $(CGROUP_DIR)/%.c $(EXTRA_HDRS) $(LIBCGROUP_O_DIRS)
+$(LIBCGROUP_O): $(OUTPUT)/%.o : $(CGROUP_DIR)/%.c $(EXTRA_HDRS) | $(LIBCGROUP_O_DIRS)
 	$(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c $< -o $@
 
 EXTRA_CLEAN += $(LIBCGROUP_O)
-- 
2.39.5


  parent reply	other threads:[~2026-09-22  7:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22  7:19 [PATCH v2 0/2] KVM: selftests: Fix incremental build dependencies Fuad Tabba
2026-09-22  7:19 ` [PATCH v2 1/2] KVM: selftests: Fix arm64 sysreg header dependencies Fuad Tabba
2026-09-24 16:32   ` Sean Christopherson
2026-09-24 18:18     ` Fuad Tabba
2026-09-22  7:19 ` Fuad Tabba [this message]
2026-09-22 13:44   ` [PATCH v2 2/2] selftests/cgroup: Make the object directory an order-only prerequisite Michal Koutný
2026-10-07  7:40 ` [PATCH v2 0/2] KVM: selftests: Fix incremental build dependencies Fuad Tabba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922071945.693714-3-fuad.tabba@linux.dev \
    --to=fuad.tabba@linux.dev \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=jthoughton@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mkoutny@suse.com \
    --cc=oupton@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=shuah@kernel.org \
    --cc=tabba@google.com \
    --cc=tj@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.