From: sashiko-bot@kernel.org
To: "Sidraya Jayagond" <sidraya@linux.ibm.com>
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
linux-s390@vger.kernel.org, "Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH net] net/smc: fix UAF on lgr list traversal in smcr_port_err()
Date: Tue, 22 Sep 2026 07:41:05 +0000 [thread overview]
Message-ID: <20260922074105.913E31F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922073149.474762-1-sidraya@linux.ibm.com>
> smcr_port_err() traverses smc_lgr_list.list without holding
> smc_lgr_list.lock, allowing a concurrent smc_lgr_terminate_sched()
> to free an lgr while it is still being dereferenced.
>
> Hold smc_lgr_list.lock across the traversal. Update
> smc_ib_gid_check() to call smcr_port_err() after releasing the lock.
>
> Fixes: 541afa10c126 ("net/smc: add smcr_port_err() and smcr_link_down() processing")
> Reviewed-by: Mahanta Jambigi <mjambigi@linux.ibm.com>
> Signed-off-by: Sidraya Jayagond <sidraya@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260922073149.474762-1-sidraya@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-09-22 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 7:31 [PATCH net] net/smc: fix UAF on lgr list traversal in smcr_port_err() Sidraya Jayagond
2026-09-22 7:41 ` sashiko-bot [this message]
2026-09-22 16:06 ` Dust Li
2026-09-24 17:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922074105.913E31F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sidraya@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.