Re: [PATCH] arm64: dts: qcom: nord: Add bwmon node for Nord

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: qcom: missing status disabled on incomplete bwmon nodes
--

commit 2b4a55863dba14f87c025537e56ccb0a5f410f20
Author: Pushpendra Singh <pussin@qti.qualcomm.com>

arm64: dts: qcom: nord: Add bwmon node for Nord

Add BWMON nodes and associated OPP tables to enable dynamic DDR/LLCC
frequency scaling.

> diff --git a/arch/arm64/boot/dts/qcom/nord.dtsi b/arch/arm64/boot/dts/qcom/nord.dtsi
> index e0496fd40c308..9925e770dfa46 100644
> --- a/arch/arm64/boot/dts/qcom/nord.dtsi
> +++ b/arch/arm64/boot/dts/qcom/nord.dtsi
[ ... ]
> @@ -1460,6 +1460,73 @@ uart13: serial@a98000 {
>  			};
>  		};
>  
> +		bwmon_cluster2: pmu@1014400 {
> +			reg = <0x0 0x01014400 0x0 0x600>;
> +			interrupts = <GIC_SPI 739 IRQ_TYPE_LEVEL_HIGH>;
> +			operating-points-v2 = <&bwmon_cluster_opp_table>;
> +		};

[Severity: Low]
Should this bwmon_cluster2 node include a status = "disabled" property?

Because this base node in arch/arm64/boot/dts/qcom/nord.dtsi is introduced
without a compatible property, it is enabled by default. Any board including
nord.dtsi without fully configuring this node will instantiate an incomplete
platform device and trigger dtbs_check schema validation errors.

> +
> +		bwmon_cluster1: pmu@1015400 {
> +			reg = <0x0 0x01015400 0x0 0x600>;
> +			interrupts = <GIC_SPI 812 IRQ_TYPE_LEVEL_HIGH>;
> +			operating-points-v2 = <&bwmon_cluster_opp_table>;
> +		};

[Severity: Low]
Does this bwmon_cluster1 node also need to be disabled by default for the
same reason?

> +
> +		bwmon_cluster0: pmu@1016400 {
> +			reg = <0x0 0x01016400 0x0 0x600>;
> +			interrupts = <GIC_SPI 813 IRQ_TYPE_LEVEL_HIGH>;
> +
> +			operating-points-v2 = <&bwmon_cluster_opp_table>;

[Severity: Low]
And similarly for this bwmon_cluster0 node, should it have status = "disabled"
to prevent incomplete instantiation when the variant-specific compatible
string is missing?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922080416.484280-1-shengchao.guo@oss.qualcomm.com?part=1