From: Jamin Lin <jamin_lin@aspeedtech.com>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Kane Chen" <kane_chen@aspeedtech.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: Jamin Lin <jamin_lin@aspeedtech.com>, Troy Lee <troy_lee@aspeedtech.com>
Subject: [PATCH v1 11/19] hw/usb/aspeed-udc: Clear EP_POOL_ACK when no endpoint ack is left
Date: Tue, 22 Sep 2026 09:02:09 +0000 [thread overview]
Message-ID: <20260922090154.1792077-12-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20260922090154.1792077-1-jamin_lin@aspeedtech.com>
UDC_ISR.EP_POOL_ACK says that at least one endpoint in UDC_EP_ACK_ISR
has an ack. It is read only, so a write cannot clear it.
Clear it when bits 3:0 of UDC_EP_ACK_ISR are all 0, which means no
programmable endpoint has an ack.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/usb/aspeed-udc.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hw/usb/aspeed-udc.c b/hw/usb/aspeed-udc.c
index 95fe823534..bdbd1a78b8 100644
--- a/hw/usb/aspeed-udc.c
+++ b/hw/usb/aspeed-udc.c
@@ -335,6 +335,13 @@ static void aspeed_udc_write(void *opaque, hwaddr offset, uint64_t data,
aspeed_udc_update_irq(s);
break;
case R_UDC_EP_ACK_ISR:
+ val &= 0x0000000f;
+ s->regs[reg] &= ~val;
+ if (!s->regs[R_UDC_EP_ACK_ISR]) {
+ s->regs[R_UDC_ISR] &= ~R_UDC_ISR_EP_POOL_ACK_MASK;
+ }
+ aspeed_udc_update_irq(s);
+ break;
case R_UDC_EP_NAK_ISR:
val &= 0x0000000f;
s->regs[reg] &= ~val;
--
2.53.0
next prev parent reply other threads:[~2026-09-22 9:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 9:01 [PATCH v1 00/19] hw/usb: Add a usbredir server transport and AST1030 UDC support Jamin Lin
2026-09-22 9:01 ` [PATCH v1 01/19] hw/usb/bus: Let a bus opt out of automatic hub insertion Jamin Lin
2026-09-22 9:01 ` [PATCH v1 02/19] hw/usb/redirect-server: Add a usbredir server device Jamin Lin
2026-09-22 9:01 ` [PATCH v1 03/19] hw/usb/redirect-server: Connect usbredirparser to a chardev Jamin Lin
2026-09-22 9:02 ` [PATCH v1 04/19] hw/usb/redirect-server: Announce the exported device Jamin Lin
2026-09-22 9:02 ` [PATCH v1 05/19] hw/usb/redirect-server: Implement control transfers Jamin Lin
2026-09-22 9:02 ` [PATCH v1 06/19] hw/usb/redirect-server: Implement bulk and interrupt transfers Jamin Lin
2026-09-22 9:02 ` [PATCH v1 07/19] hw/usb/redirect-server: Stream interrupt IN endpoints Jamin Lin
2026-09-22 9:02 ` [PATCH v1 08/19] hw/arm/aspeed: Enable the usbredir server transport Jamin Lin
2026-09-22 9:02 ` [PATCH v1 09/19] hw/usb/aspeed-udc: Make the SETUP buffer byte addressable Jamin Lin
2026-09-22 9:02 ` [PATCH v1 10/19] hw/usb/aspeed-udc: Mask the reserved bits on register writes Jamin Lin
2026-09-22 9:02 ` Jamin Lin [this message]
2026-09-22 9:02 ` [PATCH v1 12/19] hw/usb/aspeed-udc: Rename the transfer helpers after their DMA mode Jamin Lin
2026-09-22 9:02 ` [PATCH v1 13/19] hw/usb/aspeed-udc: Store the EP_DMA_STS write first Jamin Lin
2026-09-22 9:02 ` [PATCH v1 14/19] hw/usb/aspeed-udc: Pick the EP_DMA_STS path by direction Jamin Lin
2026-09-22 9:02 ` [PATCH v1 15/19] hw/usb/aspeed-udc: Support single-stage IN transfers Jamin Lin
2026-09-22 9:02 ` [PATCH v1 16/19] hw/usb/aspeed-udc: Use the endpoint max packet size for OUT transfers Jamin Lin
2026-09-22 9:02 ` [PATCH v1 17/19] hw/usb/aspeed-udc: Add trace events for the transfer paths Jamin Lin
2026-09-22 9:02 ` [PATCH v1 18/19] hw/arm/aspeed_ast10x0: Add the USB device controller Jamin Lin
2026-09-22 9:02 ` [PATCH v1 19/19] tests/functional/arm/test_aspeed_ast1030: Test the usbredir server transport Jamin Lin
2026-09-30 7:48 ` [PATCH v1 00/19] hw/usb: Add a usbredir server transport and AST1030 UDC support Jamin Lin
2026-09-30 7:59 ` Cédric Le Goater
2026-09-30 8:05 ` Jamin Lin
2026-09-30 8:22 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922090154.1792077-12-jamin_lin@aspeedtech.com \
--to=jamin_lin@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=kane_chen@aspeedtech.com \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.