All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: Quchaosheng <quchaosheng000406@163.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files
Date: Tue, 22 Sep 2026 09:16:36 +0000	[thread overview]
Message-ID: <20260922091636.A5A401F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922090836.111516-1-quchaosheng000406@163.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] docs: dangling link to deleted vexpress hwmon binding
--

commit 49de6b25b319a6b7c33aa41c9b596dc97f03cb2f
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files

This commit removes the obsolete hwmon and regulator text bindings for
arm,vexpress platforms, migrating a note and required properties into the
existing vexpress-config.yaml schema.

>     One sentence in the regulator file is not a restatement: it says that a
>     supply without regulator-min-microvolt and regulator-max-microvolt is
>     treated as fixed. vexpress_regulator_probe() implements that by selecting
>     vexpress_regulator_ops_ro when the two properties do not both define a
>     range. Move the note into the regulator node description in the schema,
>     so that removing the file does not lose it.
>     
>     Nothing else refers to the two files. Remove them.

[Severity: Low]
Is this completely accurate?

Looking at Documentation/hwmon/vexpress.rst, it contains a direct reference to
the deleted hwmon binding:

Documentation/hwmon/vexpress.rst:
...
in Documentation/devicetree/bindings/hwmon/vexpress.txt.
...

Does this documentation file need to be updated to point to the yaml file
instead of becoming a dead link?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922090836.111516-1-quchaosheng000406@163.com?part=1

  reply	other threads:[~2026-09-22  9:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22  9:08 [PATCH v2] dt-bindings: arm: vexpress: drop the obsolete hwmon and regulator text files Quchaosheng
2026-09-22  9:16 ` sashiko-bot [this message]
2026-09-23  2:30   ` Quchaosheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922091636.A5A401F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=quchaosheng000406@163.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.