Re: [PATCH v2 1/3] dt-bindings: usb: mtu3: add mt6595

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: usb: mtu3: missing companion xhci compatible for mt6595
--

commit 69c32994e4cd3df8ae84107c2e4552ba6293f82d
Author: Roman Vivchar <rva333@protonmail.com>

dt-bindings: usb: mtu3: add mt6595

Add a compatible string for the MTU3 IP found on the MediaTek mt6595 SoC.

> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> index 21fc6bbe954f9..4538df164a16d 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> @@ -22,6 +22,7 @@ properties:
>      items:
>        - enum:
>            - mediatek,mt2712-mtu3
> +          - mediatek,mt6595-mtu3

[Severity: Low]
Does the addition of this compatible string trigger a validation failure
during dtbs_check for mt6595 boards utilizing host or OTG modes?

The mediatek,mtu3.yaml schema enforces that any xHCI child node must comply
with the companion schema:

Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml:
  "^usb@[0-9a-f]+$":
    type: object
    $ref: /schemas/usb/mediatek,mtk-xhci.yaml#

When a device tree for mt6595 configures the MTU3 controller in host or
dual-role mode, it requires a child xHCI node with the mediatek,mt6595-xhci
compatible string.

However, this companion schema is omitted from the patch and does not list
the new compatible string:

Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml:
  compatible:
    items:
      - enum:
          - mediatek,mt2701-xhci
          - mediatek,mt2712-xhci

Should mediatek,mtk-xhci.yaml be updated to include mediatek,mt6595-xhci to
support the mandatory xHCI child node?

>            - mediatek,mt8173-mtu3
>            - mediatek,mt8183-mtu3
>            - mediatek,mt8186-mtu3

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922-6595-mtu3-v2-0-71203a362b36@protonmail.com?part=1