From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DC68C982FA for ; Tue, 22 Sep 2026 10:55:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TN2LUEkdqSUYTptenAPiIVKBYgNkWipfZzT4NzeSmZ0=; b=on6Vwj6oPAmR3t pzXB/npP6IzPpXnT3g6y/qzzLdMmWGu7fM4SogDYbXao9leKtp1lekQDLifClMVEgQEUE140GjJCa gC9prgl90PJeXaVgpJWKaYtDqXa6Bw0vSySCvnHY/k/OrKZo/2kOfx6QvY1uW3+SvSQg0fRvr+6FO pjDR2JzVMpNmOy3jrNfJ53Zab5Xf1PBxuAhcSOH+JYmh7XdonUO0H9bQWKuR3mJ4ItKAyidEl2/Dn I7cyPEOzKrd+suclWP12/TkkkMkXqrS0SIJ9VbOnLfDoRchu0z1Qw/ixHNIMxLWLwqAf8o+47xGMZ wXuSmOYYZhLyUA4/EVJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8y9Z-000000057Sc-0a96; Tue, 22 Sep 2026 10:55:13 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8y9X-000000057S2-1VHZ for linux-i3c@lists.infradead.org; Tue, 22 Sep 2026 10:55:11 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 69F27601F7; Tue, 22 Sep 2026 10:55:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3D811F000FF; Tue, 22 Sep 2026 10:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790074510; bh=s/+QYMob5+87WiegSIyEa79IoXlYo95rJzrQ1G3FftY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Mf9m3cXBnrivcj+3uhYb2gw+lRy12PHKU/CD6qXTKQ+KjBesvuX23lptmMf4MgLXD GF96MJR1PQgMFS8FjDkWNFc+JneBve0WC7cDNfQALYCFZThNwrHxOHjP3D+3UiQ/kl 3op3FD5LTjwbcEyb0JnDe16St4Nqkf0d460G0b1unK5lJNhY5TuSX98NNEocH1FSAH CHFGA2LM+uS4dB4FykHEWYY2liehqnKdB1uPw1axYgdIs4Lra6zjxsuonKYhKtUlZI U+Pak5xw9fASmCznT59HA+elvFOkz4yb2kBS3jBz67ilUvY4c7UNVsgsgXgMMeiX9B fMJKLPgzbCjcA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v20 7/8] i3c: hub: p3h2x4x: Add support for NXP P3H2x4x I3C hub functionality To: "Lakshay Piplani" Cc: devicetree@vger.kernel.org, Frank.Li@kernel.org, lee@kernel.org, linux-i3c@lists.infradead.org, conor+dt@kernel.org, robh@kernel.org, "Alexandre Belloni" , mfd@lists.linux.dev In-Reply-To: <20260922103551.2754613-8-lakshay.piplani@nxp.com> References: <20260922103551.2754613-1-lakshay.piplani@nxp.com> <20260922103551.2754613-8-lakshay.piplani@nxp.com> Date: Tue, 22 Sep 2026 10:55:09 +0000 Message-Id: <20260922105509.C3D811F000FF@smtp.kernel.org> X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIGkzYzogaHViOiBUT0NU T1UgcmFjZSBhbmQgZGlzY29ubmVjdCBkdXJpbmcgSTNDIG1hc3RlciByZWdpc3RyYXRpb24KLSBb TWVkaXVtXSBpM2M6IGh1YjogaW5jb25zaXN0ZW50IERUIGNoaWxkIHBhcnNpbmcgYWxsb3dzIHBv cnQgdXN1cnBhdGlvbgotLQoKY29tbWl0IDBlZWRiMzU0OGVkOTdmNTU2YWE0OWQ5ZjNhZmFjZjJi MDIwMDRhY2IKQXV0aG9yOiBBbWFuIEt1bWFyIFBhbmRleSA8YW1hbi5rdW1hcnBhbmRleUBueHAu Y29tPgoKaTNjOiBodWI6IHAzaDJ4NHg6IEFkZCBzdXBwb3J0IGZvciBOWFAgUDNIMng0eCBJM0Mg aHViIGZ1bmN0aW9uYWxpdHkKClRoaXMgY29tbWl0IGFkZHMgSTNDIGh1YiBmdW5jdGlvbmFsaXR5 IGZvciB0aGUgTlhQIFAzSDJ4NHggZmFtaWx5LiBJdAplbmFibGVzIEkzQy9JMkMgY29tbXVuaWNh dGlvbiBiZXR3ZWVuIGhvc3QgYW5kIGh1YiwgdHJhbnNwYXJlbnQgY29tbXVuaWNhdGlvbgp3aXRo IGRvd25zdHJlYW0gZGV2aWNlcywgYW5kIHRhcmdldCBwb3J0IGNvbmZpZ3VyYXRpb24uCgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2kzYy9odWIvcDNoMjg0MF9pM2NfaHViX2NvbW1vbi5jIGIvZHJp dmVycy9pM2MvaHViL3AzaDI4NDBfaTNjX2h1Yl9jb21tb24uYwo+IC0tLSAvZGV2L251bGwKPiAr KysgYi9kcml2ZXJzL2kzYy9odWIvcDNoMjg0MF9pM2NfaHViX2NvbW1vbi5jClsgLi4uIF0KPiAr c3RhdGljIHZvaWQgcDNoMng0eF9nZXRfdGFyZ2V0X3BvcnRfZHRfY29uZihzdHJ1Y3QgZGV2aWNl ICpkZXYsCj4gKwkJCQkJICAgIGNvbnN0IHN0cnVjdCBkZXZpY2Vfbm9kZSAqbm9kZSkKPiArewo+ ICsJc3RydWN0IHAzaDJ4NHhfaTNjX2h1Yl9kZXYgKnAzaDJ4NHhfaTNjX2h1YiA9IGRldl9nZXRf ZHJ2ZGF0YShkZXYpOwo+ICsJc3RydWN0IHAzaDJ4NHggKnAzaDJ4NHggPSBkZXZfZ2V0X2RydmRh dGEoZGV2LT5wYXJlbnQpOwo+ICsJdTY0IHRwX3BvcnQ7Cj4gKwo+ICsJZm9yX2VhY2hfYXZhaWxh YmxlX2NoaWxkX29mX25vZGVfc2NvcGVkKG5vZGUsIGRldl9ub2RlKSB7Cj4gKwkJaWYgKG9mX3By b3BlcnR5X3JlYWRfcmVnKGRldl9ub2RlLCAwLCAmdHBfcG9ydCwgTlVMTCkpCj4gKwkJCWNvbnRp bnVlOwoKW1NldmVyaXR5OiBNZWRpdW1dCkRvZXMgdGhpcyBsb29wIHBvdGVudGlhbGx5IGNhcHR1 cmUgdW5yZWxhdGVkIG5vZGVzIHdpdGggYSAicmVnIiBwcm9wZXJ0eT8KClVubGlrZSBwM2gyeDR4 X3BhcnNlX3RwX2R0X3NldHRpbmdzKCkgYmVsb3cgd2hpY2ggY2hlY2tzIGlmIHRoZSBub2RlIG5h bWUgaXMKImkzYyIgb3IgInNtYnVzIiwgdGhpcyBsb29wIGl0ZXJhdGVzIG92ZXIgYWxsIGNoaWxk cmVuIG9mIHRoZSBNRkQgbm9kZSB3aXRob3V0CmNoZWNraW5nIHRoZSBub2RlIG5hbWUuIElmIGFu IHVucmVsYXRlZCBjaGlsZCBoYXMgYSAicmVnIiBwcm9wZXJ0eSwgaXQgbWlnaHQKdXN1cnAgYSB2 YWxpZCB0YXJnZXQgcG9ydCBzbG90IGFuZCBpbmNvcnJlY3RseSBkZWZhdWx0IHRvIFAzSDJYNFhf VFBfTU9ERV9JM0MuCgpbIC4uLiBdCj4gK3N0YXRpYyBpbnQgcDNoMng0eF9wYXJzZV90cF9kdF9z ZXR0aW5ncyhzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gKwkJCQkJY29uc3Qgc3RydWN0IGRldmljZV9u b2RlICpub2RlLAo+ICsJCQkJCXN0cnVjdCB0cF9jb25maWd1cmF0aW9uIHRwX2NvbmZpZ1tdKQo+ ICt7Cj4gKwlzdHJ1Y3QgcDNoMng0eCAqcDNoMng0eCA9IGRldl9nZXRfZHJ2ZGF0YShkZXYtPnBh cmVudCk7Cj4gKwl1NjQgaWQ7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCWZvcl9lYWNoX2F2YWlsYWJs ZV9jaGlsZF9vZl9ub2RlX3Njb3BlZChub2RlLCB0cF9ub2RlKSB7Cj4gKwkJZW51bSBwM2gyeDR4 X3RwX21vZGUgbW9kZTsKPiArCj4gKwkJLyoKPiArCQkgKiBPbmx5ICJpM2MiIGFuZCAic21idXMi IGNoaWxkcmVuIGRlc2NyaWJlIHRhcmdldCBwb3J0cy4gU2tpcCBhbnkKPiArCQkgKiBvdGhlciBj aGlsZCAoZm9yIGV4YW1wbGUgdGhlIE1GRCAicmVndWxhdG9ycyIgY29udGFpbmVyKSwgd2hpY2gK PiArCQkgKiBoYXMgbm8gInJlZyIgcHJvcGVydHkuCj4gKwkJICovCj4gKwkJaWYgKG9mX25vZGVf bmFtZV9lcSh0cF9ub2RlLCAiaTNjIikpCj4gKwkJCW1vZGUgPSBQM0gyWDRYX1RQX01PREVfSTND Owo+ICsJCWVsc2UgaWYgKG9mX25vZGVfbmFtZV9lcSh0cF9ub2RlLCAic21idXMiKSkKPiArCQkJ bW9kZSA9IFAzSDJYNFhfVFBfTU9ERV9TTUJVUzsKPiArCQllbHNlCj4gKwkJCWNvbnRpbnVlOwoK WyAuLi4gXQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2kzYy9odWIvcDNoMjg0MF9pM2NfaHViX2kz Yy5jIGIvZHJpdmVycy9pM2MvaHViL3AzaDI4NDBfaTNjX2h1Yl9pM2MuYwo+IC0tLSAvZGV2L251 bGwKPiArKysgYi9kcml2ZXJzL2kzYy9odWIvcDNoMjg0MF9pM2NfaHViX2kzYy5jClsgLi4uIF0K PiAraW50IHAzaDJ4NHhfdHBfaTNjX2FsZ28oc3RydWN0IHAzaDJ4NHhfaTNjX2h1Yl9kZXYgKnAz aDJ4NHhfaHViKQo+ICt7ClsgLi4uIF0KPiArCQlyZXQgPSBpM2NfbWFzdGVyX3JlZ2lzdGVyX2Z3 bm9kZShjb250cm9sbGVyLAo+ICsJCQkJCQkgcDNoMng0eF9odWItPmRldiwKPiArCQkJCQkJIG9m X2Z3bm9kZV9oYW5kbGUocDNoMng0eF9odWItPnRwX2J1c1t0cF0ub2Zfbm9kZSksCj4gKwkJCQkJ CSAmaTNjX2h1Yl9tYXN0ZXJfb3BzLAo+ICsJCQkJCQkgZmFsc2UpOwoKW1NldmVyaXR5OiBIaWdo XQpDb3VsZCB0aGlzIGxlYWQgdG8gYSBwaHlzaWNhbCBwb3J0IGRpc2Nvbm5lY3Rpb24gYW5kIHN1 YnNlcXVlbnQgdHJhbnNmZXIKZmFpbHVyZXM/CgpXaGVuIGkzY19tYXN0ZXJfcmVnaXN0ZXJfZndu b2RlKCkgaXMgY2FsbGVkIGhlcmUsIGl0IHRyaWdnZXJzIERBQS4gQXQgdGhpcwp0aW1lLCB0aGUg YWx3YXlzX2VuYWJsZSBmbGFnIGlzIGZhbHNlLCBtZWFuaW5nIHAzaDJ4NHhfaHViX2VuYWJsZV9w b3J0KCkgYW5kCnAzaDJ4NHhfaHViX2Rpc2FibGVfcG9ydCgpIHdpbGwgYWN0aXZlbHkgbWFuaXB1 bGF0ZSBQM0gyWDRYX1RQX05FVF9DT05fQ09ORi4KQWZ0ZXIgREFBIGNvbXBsZXRlcywgdGhlIHBv cnQgaXMgbGVmdCBwaHlzaWNhbGx5IGRpc2Nvbm5lY3RlZC4KCj4gKwkJaWYgKHJldCkKPiArCQkJ cmV0dXJuIHJldDsKPiArCj4gKwkJcmV0ID0gZGV2bV9hZGRfYWN0aW9uX29yX3Jlc2V0KHAzaDJ4 NHhfaHViLT5kZXYsCj4gKwkJCQkJICAgICAgIHAzaDJ4NHhfdW5yZWdpc3Rlcl9pM2NfbWFzdGVy LAo+ICsJCQkJCSAgICAgICBjb250cm9sbGVyKTsKPiArCQlpZiAocmV0KQo+ICsJCQlyZXR1cm4g cmV0Owo+ICsKPiArCQludHdrX21hc2sgfD0gcDNoMng0eF9odWItPnRwX2J1c1t0cF0udHBfbWFz azsKPiArCQlwM2gyeDR4X2h1Yi0+dHBfYnVzW3RwXS5pc19yZWdpc3RlcmVkID0gdHJ1ZTsKPiAr CQlwM2gyeDR4X2h1Yi0+aHViX2NvbmZpZy50cF9jb25maWdbdHBdLmFsd2F5c19lbmFibGUgPSB0 cnVlOwo+ICsJfQo+ICsJcmV0dXJuIHJlZ21hcF93cml0ZShwM2gyeDR4X2h1Yi0+cmVnbWFwLCBQ M0gyWDRYX1RQX05FVF9DT05fQ09ORiwgbnR3a19tYXNrKTsKCltTZXZlcml0eTogSGlnaF0KQmVj YXVzZSBhbHdheXNfZW5hYmxlIGlzIHNldCB0byB0cnVlIGluIHRoZSBsb29wLCBzdWJzZXF1ZW50 IHBvcnQgZW5hYmxlIGFuZApkaXNhYmxlIGNhbGxiYWNrcyBiZWNvbWUgbm8tb3BzLiBIb3dldmVy LCB0aGUgaGFyZHdhcmUgcmVnaXN0ZXIKUDNIMlg0WF9UUF9ORVRfQ09OX0NPTkYgaXNuJ3QgYWN0 dWFsbHkgd3JpdHRlbiB1bnRpbCB0aGUgdmVyeSBlbmQgb2YgdGhlIGxvb3AuCgpEb2VzIHRoaXMg bGVhdmUgYSB3aW5kb3cgd2hlcmUgdGhlIHBvcnQgaXMgZXhwb3NlZCBidXQgcGh5c2ljYWxseQpk aXNjb25uZWN0ZWQ/IElmIGFuIEkzQyB0cmFuc2ZlciBpcyBpbml0aWF0ZWQgY29uY3VycmVudGx5 IGJlZm9yZSB0aGUgbG9vcApmaW5pc2hlcywgd29uJ3QgaXQgZmFpbCBkdWUgdG8gdGhlIHNvZnR3 YXJlIGFzc3VtaW5nIHRoZSBwb3J0IGlzIGFsd2F5cwplbmFibGVkIHdoaWxlIHRoZSBoYXJkd2Fy ZSBoYXNuJ3QgYmVlbiB1cGRhdGVkIHlldD8KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRw czovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA5MjIxMDM1NTEuMjc1NDYxMy0xLWxha3No YXkucGlwbGFuaUBueHAuY29tP3BhcnQ9NwoKLS0gCmxpbnV4LWkzYyBtYWlsaW5nIGxpc3QKbGlu dXgtaTNjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1pM2MK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 575A73939C9; Tue, 22 Sep 2026 10:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790074518; cv=none; b=U+v1J0J9GHT+kqFv0vZoJ3bIeWVBFTIkXblIm32AziaeKoEejyrt6zyq7gt2Ggz4XhjCjCXgV4O2HB2etIi6IvK3X7GPA/HZMtc5djS78POQluft0xAXktPgB4/tKWOzRTTJJOhN0EfUYBAfzFmFZ6CVzlMHNzUEdgndBF6B1MY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790074518; c=relaxed/simple; bh=qo9THL6VKsT/lL5P22xZ9s6iyQubCi4QytGRN/QPJF8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=CKyBDbTU8DKkK3ud0lA79UO/eK+8H2rZ6sASBlEtXcPBxfv545XfudYafQcxuzDGFrZZt7s0f2c0R0+zI9XBHfhd8qKSUy8BRxFmZ2LSFKTdqrObinNiBqpeCEiSVIZMgKrhEHcxiH8dagtoHUNKAS3z/eKRV5YE2+hXRGwxdDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Mf9m3cXB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Mf9m3cXB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3D811F000FF; Tue, 22 Sep 2026 10:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790074510; bh=s/+QYMob5+87WiegSIyEa79IoXlYo95rJzrQ1G3FftY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Mf9m3cXBnrivcj+3uhYb2gw+lRy12PHKU/CD6qXTKQ+KjBesvuX23lptmMf4MgLXD GF96MJR1PQgMFS8FjDkWNFc+JneBve0WC7cDNfQALYCFZThNwrHxOHjP3D+3UiQ/kl 3op3FD5LTjwbcEyb0JnDe16St4Nqkf0d460G0b1unK5lJNhY5TuSX98NNEocH1FSAH CHFGA2LM+uS4dB4FykHEWYY2liehqnKdB1uPw1axYgdIs4Lra6zjxsuonKYhKtUlZI U+Pak5xw9fASmCznT59HA+elvFOkz4yb2kBS3jBz67ilUvY4c7UNVsgsgXgMMeiX9B fMJKLPgzbCjcA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v20 7/8] i3c: hub: p3h2x4x: Add support for NXP P3H2x4x I3C hub functionality Reply-To: sashiko-reviews@lists.linux.dev To: "Lakshay Piplani" Cc: devicetree@vger.kernel.org, Frank.Li@kernel.org, lee@kernel.org, linux-i3c@lists.infradead.org, conor+dt@kernel.org, robh@kernel.org, "Alexandre Belloni" , mfd@lists.linux.dev In-Reply-To: <20260922103551.2754613-8-lakshay.piplani@nxp.com> References: <20260922103551.2754613-1-lakshay.piplani@nxp.com> <20260922103551.2754613-8-lakshay.piplani@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 22 Sep 2026 10:55:09 +0000 Message-Id: <20260922105509.C3D811F000FF@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] i3c: hub: TOCTOU race and disconnect during I3C master registration - [Medium] i3c: hub: inconsistent DT child parsing allows port usurpation -- commit 0eedb3548ed97f556aa49d9f3afacf2b02004acb Author: Aman Kumar Pandey i3c: hub: p3h2x4x: Add support for NXP P3H2x4x I3C hub functionality This commit adds I3C hub functionality for the NXP P3H2x4x family. It enables I3C/I2C communication between host and hub, transparent communicati= on with downstream devices, and target port configuration. > diff --git a/drivers/i3c/hub/p3h2840_i3c_hub_common.c b/drivers/i3c/hub/p= 3h2840_i3c_hub_common.c > --- /dev/null > +++ b/drivers/i3c/hub/p3h2840_i3c_hub_common.c [ ... ] > +static void p3h2x4x_get_target_port_dt_conf(struct device *dev, > + const struct device_node *node) > +{ > + struct p3h2x4x_i3c_hub_dev *p3h2x4x_i3c_hub =3D dev_get_drvdata(dev); > + struct p3h2x4x *p3h2x4x =3D dev_get_drvdata(dev->parent); > + u64 tp_port; > + > + for_each_available_child_of_node_scoped(node, dev_node) { > + if (of_property_read_reg(dev_node, 0, &tp_port, NULL)) > + continue; [Severity: Medium] Does this loop potentially capture unrelated nodes with a "reg" property? Unlike p3h2x4x_parse_tp_dt_settings() below which checks if the node name is "i3c" or "smbus", this loop iterates over all children of the MFD node with= out checking the node name. If an unrelated child has a "reg" property, it might usurp a valid target port slot and incorrectly default to P3H2X4X_TP_MODE_I= 3C. [ ... ] > +static int p3h2x4x_parse_tp_dt_settings(struct device *dev, > + const struct device_node *node, > + struct tp_configuration tp_config[]) > +{ > + struct p3h2x4x *p3h2x4x =3D dev_get_drvdata(dev->parent); > + u64 id; > + int ret; > + > + for_each_available_child_of_node_scoped(node, tp_node) { > + enum p3h2x4x_tp_mode mode; > + > + /* > + * Only "i3c" and "smbus" children describe target ports. Skip any > + * other child (for example the MFD "regulators" container), which > + * has no "reg" property. > + */ > + if (of_node_name_eq(tp_node, "i3c")) > + mode =3D P3H2X4X_TP_MODE_I3C; > + else if (of_node_name_eq(tp_node, "smbus")) > + mode =3D P3H2X4X_TP_MODE_SMBUS; > + else > + continue; [ ... ] > diff --git a/drivers/i3c/hub/p3h2840_i3c_hub_i3c.c b/drivers/i3c/hub/p3h2= 840_i3c_hub_i3c.c > --- /dev/null > +++ b/drivers/i3c/hub/p3h2840_i3c_hub_i3c.c [ ... ] > +int p3h2x4x_tp_i3c_algo(struct p3h2x4x_i3c_hub_dev *p3h2x4x_hub) > +{ [ ... ] > + ret =3D i3c_master_register_fwnode(controller, > + p3h2x4x_hub->dev, > + of_fwnode_handle(p3h2x4x_hub->tp_bus[tp].of_node), > + &i3c_hub_master_ops, > + false); [Severity: High] Could this lead to a physical port disconnection and subsequent transfer failures? When i3c_master_register_fwnode() is called here, it triggers DAA. At this time, the always_enable flag is false, meaning p3h2x4x_hub_enable_port() and p3h2x4x_hub_disable_port() will actively manipulate P3H2X4X_TP_NET_CON_CONF. After DAA completes, the port is left physically disconnected. > + if (ret) > + return ret; > + > + ret =3D devm_add_action_or_reset(p3h2x4x_hub->dev, > + p3h2x4x_unregister_i3c_master, > + controller); > + if (ret) > + return ret; > + > + ntwk_mask |=3D p3h2x4x_hub->tp_bus[tp].tp_mask; > + p3h2x4x_hub->tp_bus[tp].is_registered =3D true; > + p3h2x4x_hub->hub_config.tp_config[tp].always_enable =3D true; > + } > + return regmap_write(p3h2x4x_hub->regmap, P3H2X4X_TP_NET_CON_CONF, ntwk_= mask); [Severity: High] Because always_enable is set to true in the loop, subsequent port enable and disable callbacks become no-ops. However, the hardware register P3H2X4X_TP_NET_CON_CONF isn't actually written until the very end of the lo= op. Does this leave a window where the port is exposed but physically disconnected? If an I3C transfer is initiated concurrently before the loop finishes, won't it fail due to the software assuming the port is always enabled while the hardware hasn't been updated yet? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260922103551.2754= 613-1-lakshay.piplani@nxp.com?part=3D7