From: sashiko-bot@kernel.org
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v3 6/7] perf mem record: Request PERF_SAMPLE_CPU by default
Date: Tue, 22 Sep 2026 12:34:25 +0000 [thread overview]
Message-ID: <20260922123426.473E21F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922122623.1029132-7-acme@kernel.org>
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> The data type profiling per-sample stream keys cross-CPU contention on
> sample->cpu; without PERF_SAMPLE_CPU that field is the (u32)-1 "no CPU
> info" sentinel, so same-instance accesses from different cores are
> indistinguishable from same-CPU traffic. 'perf mem record' already
> passes -d (addr) and -W (weight) explicitly to the record parser, add
> --sample-cpu as well and document it in perf-mem(1).
>
> The rec_argv array only had room for nine arguments per PMU plus the
> user arguments, not counting the up to eight __cmd_record() adds itself,
> which a new argument would overflow on PMUs with separate load and store
> events; reserve space for the fixed arguments too.
>
> Assisted-by: LLM
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260922122623.1029132-1-acme@kernel.org?part=6
next prev parent reply other threads:[~2026-09-22 12:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 12:26 [PATCH v3 0/7] perf annotate-data: Fix hangs on broken debug info, data type browser sample count, AMD mem record Arnaldo Carvalho de Melo
2026-09-22 12:26 ` [PATCH v3 1/7] perf dwarf-aux: Bound the type chases for broken debug info Arnaldo Carvalho de Melo
2026-09-22 12:37 ` sashiko-bot
2026-09-22 12:26 ` [PATCH v3 2/7] perf dwarf-aux: Add die_same_file() and die_get_type_die() Arnaldo Carvalho de Melo
2026-09-22 12:35 ` sashiko-bot
2026-09-22 12:26 ` [PATCH v3 3/7] perf annotate-data: Resolve type DIEs in the debug file they came from Arnaldo Carvalho de Melo
2026-09-22 12:36 ` sashiko-bot
2026-09-22 12:26 ` [PATCH v3 4/7] perf annotate-data: Bound the member nesting recursion Arnaldo Carvalho de Melo
2026-09-22 12:33 ` sashiko-bot
2026-09-22 12:26 ` [PATCH v3 5/7] perf annotate-data: Show the sample count in the data-type browser Arnaldo Carvalho de Melo
2026-09-22 12:33 ` sashiko-bot
2026-09-22 12:26 ` [PATCH v3 6/7] perf mem record: Request PERF_SAMPLE_CPU by default Arnaldo Carvalho de Melo
2026-09-22 12:34 ` sashiko-bot [this message]
2026-09-22 12:26 ` [PATCH v3 7/7] perf mem record: Use the IBS swfilt filter when available Arnaldo Carvalho de Melo
2026-09-22 12:38 ` sashiko-bot
2026-09-24 17:46 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922123426.473E21F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=acme@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.