All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Michal Luczaj" <mhal@rbox.co>
Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez" <eperezma@redhat.com>,
	virtualization@lists.linux.dev
Subject: Re: [PATCH net v3 7/8] vsock: handle listen() racing connect()
Date: Tue, 22 Sep 2026 13:43:44 +0000	[thread overview]
Message-ID: <20260922134345.985D01F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922-vsock-connect-reset-closing-v3-7-78907b8200d4@rbox.co>

> Socket can flip to TCP_LISTEN when connect() schedules out. Respect
> listen() winning the race: let connect() time out, but don't reset the
> socket.
> 
> sk is CLOSE UNCONNECTED
> non-blocking connect():
>   sk := SYN_SENT CONNECTING
>   enqueue vsock_connect_timeout()
>                                    blocking connect():
>                                      release_sock()
>                                      schedule_timeout()
> vsock_connect_timeout():
>   sk := CLOSE UNCONNECTED
> listen():
>   sk := LISTEN UNCONNECTED
>                                      lock_sock()
>                                      sk is TCP_LISTEN UNCONNECTED
> 
> Signed-off-by: Michal Luczaj <mhal@rbox.co>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260922-vsock-connect-reset-closing-v3-0-78907b8200d4@rbox.co?part=7


  reply	other threads:[~2026-09-22 13:43 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 13:14 [PATCH net v3 0/8] vsock: fix connect() races Michal Luczaj
2026-09-22 13:14 ` [PATCH net v3 1/8] vhost/vsock: Fix socket state constant Michal Luczaj
2026-09-22 13:43   ` sashiko-bot
2026-09-22 13:14 ` [PATCH net v3 2/8] vsock: simplify error check condition Michal Luczaj
2026-09-22 13:43   ` sashiko-bot
2026-09-28 10:12   ` Luigi Leonardi
2026-09-22 13:14 ` [PATCH net v3 3/8] vsock: do not preserve transport assignment Michal Luczaj
2026-09-22 13:43   ` sashiko-bot
2026-09-24 13:15   ` netdev-bot+sashiko
2026-09-24 21:27     ` Michal Luczaj
2026-09-22 13:14 ` [PATCH net v3 4/8] vsock: drop the re-assignment logic Michal Luczaj
2026-09-22 13:43   ` sashiko-bot
2026-09-24 13:15   ` netdev-bot+sashiko
2026-09-24 21:27     ` Michal Luczaj
2026-09-22 13:14 ` [PATCH net v3 5/8] vsock: treat TCP_CLOSING as once-established Michal Luczaj
2026-09-22 13:43   ` sashiko-bot
2026-09-24 13:15   ` netdev-bot+sashiko
2026-09-24 21:27     ` Michal Luczaj
2026-09-22 13:15 ` [PATCH net v3 6/8] vsock: handle socket bricking due to transport event Michal Luczaj
2026-09-22 13:43   ` sashiko-bot
2026-09-24 13:15   ` netdev-bot+sashiko
2026-09-24 21:28     ` Michal Luczaj
2026-09-22 13:15 ` [PATCH net v3 7/8] vsock: handle listen() racing connect() Michal Luczaj
2026-09-22 13:43   ` sashiko-bot [this message]
2026-09-24 13:15   ` netdev-bot+sashiko
2026-09-24 21:28     ` Michal Luczaj
2026-09-22 13:15 ` [PATCH net v3 8/8] vsock: enforce no-transport invariant for TCP_LISTEN sockets Michal Luczaj
2026-09-22 13:43   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260922134345.985D01F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mhal@rbox.co \
    --cc=mst@redhat.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.